Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <ross.burton@arm.com>, <openembedded-core@lists.openembedded.org>
Cc: <daniel.turull@ericsson.com>
Subject: Re: [OE-core] [PATCH 1/3] classes/meson: use ninja explicitly when compiling
Date: Tue, 30 Jun 2026 10:13:42 +0200	[thread overview]
Message-ID: <DJM8EZJFQZCJ.2860UZRX5PB0Q@bootlin.com> (raw)
In-Reply-To: <20260629141559.1305873-1-ross.burton@arm.com>

On Mon Jun 29, 2026 at 4:15 PM CEST, Ross Burton via lists.openembedded.org wrote:
> "meson compile" is essentially a glorified wrapper around calling ninja
> that doesn't support all of the options that ninja does, so calling it
> directly means builds are fractionally faster and we get direct control
> over the flags that ninja is passed.
>
> A longer rationale can be found in the Gentoo change by Eli Schwartz
> that caused this patch, who is both a Gentoo and Meson developer:
>
> https://github.com/gentoo/gentoo/commit/66011abd663671947fe07835f0d9cc360f5de317
>
> The only change is that the compile target doesn't support the optional
> convenience target type, but this is rarely used.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/classes-recipe/meson.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/meson.bbclass b/meta/classes-recipe/meson.bbclass
> index 9bed293603c..a4643591103 100644
> --- a/meta/classes-recipe/meson.bbclass
> +++ b/meta/classes-recipe/meson.bbclass
> @@ -180,7 +180,7 @@ meson_do_configure() {
>  
>  do_compile[progress] = "outof:^\[(\d+)/(\d+)\]\s+"
>  meson_do_compile() {
> -    meson compile -v ${PARALLEL_MAKE} ${MESON_TARGET}
> +    ninja --verbose ${PARALLEL_MAKE} ${MESON_TARGET}
>  }
>  
>  meson_do_install() {

Hi Ross, Hi Daniel,

I just note this this patch is conflicting with the one from Daniel [1],
as it does use 'MESON_TARGET = "systemd-hwdb:executable"'. Depending on
which patch is merged first, the other might have to be rebased and
fixed.

[1]: https://lore.kernel.org/all/20260626073812.769193-4-daniel.turull@ericsson.com/

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  parent reply	other threads:[~2026-06-30  8:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 14:15 [PATCH 1/3] classes/meson: use ninja explicitly when compiling Ross Burton
2026-06-29 14:15 ` [PATCH 2/3] systemd-systemctl-native: update MESON_TARGET for direct ninja use Ross Burton
2026-06-29 14:15 ` [PATCH 3/3] systemd-systemctl-native: remove systemd-sysv-install logic Ross Burton
2026-06-29 14:32 ` [OE-core] [PATCH 1/3] classes/meson: use ninja explicitly when compiling Khem Raj
2026-06-29 15:57   ` Ross Burton
2026-06-29 18:17     ` Khem Raj
2026-06-30  8:13 ` Mathieu Dubois-Briand [this message]
2026-06-30  8:20   ` Daniel Turull
2026-06-30  9:16     ` Mathieu Dubois-Briand
2026-06-30  9:17     ` Ross Burton
2026-06-30  9:20       ` Daniel Turull
2026-06-30  9:57         ` Daniel Turull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJM8EZJFQZCJ.2860UZRX5PB0Q@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=daniel.turull@ericsson.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox