From: Daniel Turull <daniel.turull@ericsson.com>
To: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
"ross.burton@arm.com" <ross.burton@arm.com>,
"mathieu.dubois-briand@bootlin.com"
<mathieu.dubois-briand@bootlin.com>
Subject: Re: [OE-core] [PATCH 1/3] classes/meson: use ninja explicitly when compiling
Date: Tue, 30 Jun 2026 08:20:52 +0000 [thread overview]
Message-ID: <ed70423e6ae6dfa9da7e739fd3c59a8f041a8773.camel@ericsson.com> (raw)
In-Reply-To: <DJM8EZJFQZCJ.2860UZRX5PB0Q@bootlin.com>
On Tue, 2026-06-30 at 10:13 +0200, Mathieu Dubois-Briand wrote:
> On Mon Jun 29, 2026 at 4:15 PM CEST, Ross Burton via
> lists.openembedded.org wrote:
> > "meson compile" is essentially a glorified wrapper around calling
> > ninja
> > that doesn't support all of the options that ninja does, so calling
> > it
> > directly means builds are fractionally faster and we get direct
> > control
> > over the flags that ninja is passed.
> >
> > A longer rationale can be found in the Gentoo change by Eli
> > Schwartz
> > that caused this patch, who is both a Gentoo and Meson developer:
> >
> >
> > The only change is that the compile target doesn't support the
> > optional
> > convenience target type, but this is rarely used.
> >
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> > meta/classes-recipe/meson.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes-recipe/meson.bbclass b/meta/classes-
> > recipe/meson.bbclass
> > index 9bed293603c..a4643591103 100644
> > --- a/meta/classes-recipe/meson.bbclass
> > +++ b/meta/classes-recipe/meson.bbclass
> > @@ -180,7 +180,7 @@ meson_do_configure() {
> >
> > do_compile[progress] = "outof:^\[(\d+)/(\d+)\]\s+"
> > meson_do_compile() {
> > - meson compile -v ${PARALLEL_MAKE} ${MESON_TARGET}
> > + ninja --verbose ${PARALLEL_MAKE} ${MESON_TARGET}
> > }
> >
> > meson_do_install() {
>
> Hi Ross, Hi Daniel,
>
> I just note this this patch is conflicting with the one from Daniel
> [1],
> as it does use 'MESON_TARGET = "systemd-hwdb:executable"'. Depending
> on
> which patch is merged first, the other might have to be rebased and
> fixed.
>
Do you know why is conflicting? the systemd patch doesn't touch
meson.bbclass
Is is a different format expected for MESON_TARGET content?
Daniel
> [1]:
>
> Thanks,
> Mathieu
>
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
next prev parent reply other threads:[~2026-06-30 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 14:15 [PATCH 1/3] classes/meson: use ninja explicitly when compiling Ross Burton
2026-06-29 14:15 ` [PATCH 2/3] systemd-systemctl-native: update MESON_TARGET for direct ninja use Ross Burton
2026-06-29 14:15 ` [PATCH 3/3] systemd-systemctl-native: remove systemd-sysv-install logic Ross Burton
2026-06-29 14:32 ` [OE-core] [PATCH 1/3] classes/meson: use ninja explicitly when compiling Khem Raj
2026-06-29 15:57 ` Ross Burton
2026-06-29 18:17 ` Khem Raj
2026-06-30 8:13 ` Mathieu Dubois-Briand
2026-06-30 8:20 ` Daniel Turull [this message]
2026-06-30 9:16 ` Mathieu Dubois-Briand
2026-06-30 9:17 ` Ross Burton
2026-06-30 9:20 ` Daniel Turull
2026-06-30 9:57 ` Daniel Turull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed70423e6ae6dfa9da7e739fd3c59a8f041a8773.camel@ericsson.com \
--to=daniel.turull@ericsson.com \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox