Re: [OE-core] [PATCH] lib/oe/patch: avoid duplicated "From:" in generated patches

["Yoann Congal" <yoann.congal@smile.fr>]

On Thu Jul 16, 2026 at 8:56 PM CEST, Alexander Kanavin wrote:
> On Thu, 16 Jul 2026 at 19:08, Yoann Congal <yoann.congal@smile.fr> wrote:
>> >> To fix the double "From:" header, use the --no-from option for
>> >> git-format-patch to override this configuration and generate only one
>> >> "From: Original Author <...>" header.
>> >
>> > I don't understand. Why is the above problematic and why does it need fixing?
>> >
>> I really don't like this double "From:" header and I manually remove it
>> every time I (re)generate a patch with devtool.
>>
>> I admit this is a matter of taste and that the problem only appears in
>> my configuration (it seems).
>>
>> I won't mind is this patch is dropped, but, on the other hand it only
>> does force the default (--no-from)
>
> Can you provide a reproducer? What is the sequence of steps where this happens?
>
> Alex

Sure, I can reproduce this from a pristine CROPS:debian-11:
  $ git config --global user.name 'Yoann Congal'
  $ git config --global user.email yoann.congal@smile.fr

  # Config to avoid groups.io "From:" rewrites issues
  $ git config --global format.from true
  $ git config --global format.forceInBodyFrom true

  # Basic poky-master setup with bitbake-setup

  $ devtool modify bash
  $ cd workspace/sources/bash

  # Emulate cherry-picking a commit from the upstream git tree
  $ echo TEST >> README
  $ git commit -a --author 'Original Author <author@example.org>' -s -m "This is a test"

  $ devtool update-recipe bash
  $ head ../../../../layers/openembedded-core/meta/recipes-extended/bash/bash/0001-This-is-a-test.patch
  From 8bbac77f0b749fc62e5ca5d924066d311e29c963 Mon Sep 17 00:00:00 2001
  From: Yoann Congal <yoann.congal@smile.fr>
  Date: Thu, 16 Jul 2026 19:31:55 +0000
  Subject: [PATCH] This is a test
  
  From: Original Author <author@example.org>
  
  Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
  ---
   README | 1 +
  # Notice the double "From:" header above

Here, I usually edit the patch to replace my "From:" with the original
author's one.

Regards,
-- 
Yoann Congal
Smile ECS