Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Alexander Kanavin" <alex.kanavin@gmail.com>
Cc: <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] lib/oe/patch: avoid duplicated "From:" in generated patches
Date: Sat, 18 Jul 2026 11:19:46 +0200	[thread overview]
Message-ID: <DK1L3DOJNAUX.136YZMPFO6SY6@smile.fr> (raw)
In-Reply-To: <CANNYZj9Ze5O-f8fNhhEFKNdgSHARgagvQHkHSyisPfid2gwO9Q@mail.gmail.com>

On Fri Jul 17, 2026 at 5:27 PM CEST, Alexander Kanavin wrote:
> On Thu, 16 Jul 2026 at 21:36, Yoann Congal <yoann.congal@smile.fr> wrote:
>>   # Config to avoid groups.io "From:" rewrites issues
>>   $ git config --global format.from true
>>   $ git config --global format.forceInBodyFrom true
>
> Thanks, I was going to say this should not be set globally, but only
> for repositories which explicitly use groups.io (e.g. oe-core). Then
> devtool managed repos in devtool workspace will not have this problem.
> But I see how this can be tedious to set in every bitbake-setup
> checkout, and it's for some users easier as a global setting.
>
> So the patch is right, but can you fold this additional discussion
> into the commit message?

Hello,

v2 sent with more context. I hope that'll be enough.

Thanks for the review :)

>
> Alex
-- 
Yoann Congal
Smile ECS



      reply	other threads:[~2026-07-18  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 18:52 [PATCH] lib/oe/patch: avoid duplicated "From:" in generated patches Yoann Congal
2026-07-13 12:59 ` [OE-core] " Alexander Kanavin
2026-07-16 17:08   ` Yoann Congal
2026-07-16 18:56     ` Alexander Kanavin
2026-07-16 19:36       ` Yoann Congal
2026-07-17 15:27         ` Alexander Kanavin
2026-07-18  9:19           ` Yoann Congal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK1L3DOJNAUX.136YZMPFO6SY6@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox