Re: [OE-core] [AUH] glslang: upgrading to 1.4.357.0 SUCCEEDED

["Yoann Congal" <yoann.congal@smile.fr>]

On Thu Jul 30, 2026 at 12:02 PM CEST, Daniel Turull wrote:
> On Thu, 2026-07-30 at 11:32 +0200, Yoann Congal wrote:
>> On Wed Jul 29, 2026 at 9:24 AM CEST, Auto Upgrade Helper via lists.openembedded.org wrote:
>> > Hello,
>> >
>> > this email is a notification from the Auto Upgrade Helper
>> > that the automatic attempt to upgrade the recipe(s) *glslang* to *1.4.357.0* has Succeeded.
>> >
>> > Next steps:
>> >      - apply the patch: git am 0001-glslang-upgrade-1.4.350.1-1.4.357.0.patch
>> >      - check the changes to upstream patches and summarize them in the commit message,
>> >      - compile an image that contains the package
>> >      - perform some basic sanity tests
>> >      - amend the patch and sign it off: git commit -s --reset-author --amend
>> >      - send it to the appropriate mailing list
>> >
>> > Alternatively, if you believe the recipe should not be upgraded at this time,
>> > you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that
>> > automatic upgrades would no longer be attempted.
>> >
>> > Please review the attached files for further information and build/update failures.
>> > Any problem please file a bug at
>> > https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler
>> >
>> > Regards,
>> > The Upgrade Helper
>> >
>> > -- >8 --
>> > From 4a9231cb33f3d14661cb97c9a7b45f33eef2589a Mon Sep 17 00:00:00 2001
>> > From: Upgrade Helper <auh@yoctoproject.org>
>> > Date: Wed, 29 Jul 2026 06:14:19 +0000
>> > Subject: [PATCH] glslang: upgrade 1.4.350.1 -> 1.4.357.0
>> >
>> > Source: CHANGES.md
>> >
>> > * Add support for GL_EXT_opacity_micromap_ray_query_mode
>> >
>> > ## 16.4.0 2026-07-14
>> >
>> > ### Descriptor Heap
>> >
>> > * Implement `GLSL_EXT_structured_descriptor_heap` with SPIR-V layout generation, heap offset
>> > access, buffer references, matrix layout decorations, and correct `readonly`/`writeonly`
>> > qualifier propagation for buffer and image descriptors
>> > * Fix descriptor heap-bound buffer access to use typed pointers
>> > * Omit `NonUniform` decoration when using descriptor heaps, as the SPIR-V spec does not require
>> > it
>> > * Add `--relax-set-binding-limits` option to allow large `layout(set)` and `layout(binding)`
>> > values for descriptor heap-style workflows with sparse set spaces
>> > * Reject combined image samplers with `descriptor_heap`
>> >
>> > ### Compute Shader Derivatives
>> >
>> > * Fix `GL_KHR_compute_shader_derivatives` regressions on shaders using the `GL_NV` variant
>> > * Update compute shader derivative rules to allow texture operations with implicit derivatives
>> > without extensions, falling back to LoD 0
>> >
>> > ### New Extensions
>> >
>> > * Implement `GL_EXT_ocp_microscaling_types`
>> > * Implement `GL_NV_cooperative_matrix_decode_vector`
>> > * Add basic support for `GL_NV_desktop_lowp_mediump`
>> > * Implement `GL_EXT_opacity_micromap_ray_query_mode`
>> >
>> > ### Bug Fixes
>> >
>> > * Fix generated decoration string from `UTF8EncodingKHR` to `UTFEncodingKHR`
>> > * Fix missing SPIR-V extension emission for `float16` derivative functions with
>> > `SPV_AMD_gpu_shader_half_float`
>> > * Apply `NoContraction` decoration to `dot()` when `noContraction` is set
>> > * Fix `OpStore` of buffer device address pointer to use 8-byte alignment, consistent with loads
>> > * Fix `RayTracingOpacityMicromapKHR` capability emission to only occur when
>> > `gl_RayFlagsForceOpacityMicromap2StateEXT` is actually used, fixing SPIR-V validation failures
>> > in ray query shaders outside ray-tracing pipeline stages
>> > * Fix `setInvertY()` to apply Y-inversion to GLSL vertex, geometry, and tessellation-evaluation
>> > shaders (previously only affected HLSL)
>> > * Fix `.length()` on arrays of long/cooperative vectors to use `OpArrayLength` instead of a
>> > constant component count
>> > * Fix unnecessary cooperative matrix conversions when creating arrays of KHR cooperative
>> > matrices
>> > * Add error for cooperative matrix `*=` with bf16/fp8 scalar operands
>> > * Fix out-of-bounds access in `elseSeen` at maximum `#if`/`#ifdef` nesting depth
>> > * Fix out-of-bounds read on empty struct texture template types
>> > * Fix crash in `layoutObjectCheck` when accessing members of an empty block
>> > * Emit an error when HLSL [numthreads] is given more than three arguments instead of crashing
>> > the compiler.
>> > * Emit error when attempting to convert a literal string to an incompatible type
>> > * Fix `abortKHR` to preserve the original user-defined string without modification
>> > * Fix out-of-bounds indexing in `TDefaultIoResolverBase::addStage` when a negative `EShLanguage`
>> > value is passed
>> >
>> > ### Other
>> >
>> > * Add `--discard-is-terminate` option to emit `OpTerminateInvocation` instead of
>> > `OpDemoteToHelperInvocation` for GLSL `discard` when tar
>> >
>> > [Changelog truncated as it exceeds 3000 characters;
>> > the full changelog can be found in an attachment to the AUH email]
>>
>> Hello David,
> I guess Daniel ;-)

Oh right, sorry!
(That explain why I couldn't find your emails -_-')

>> Would it be possible to get the upstream URL for the changelog in this
>> truncated case? ... or even in every case?
>
> The changelog comes from doing a diff into Source: CHANGES.md and then it is truncated.
> There is no URL. Having URL will required some heuristics.
>
> In the AUH email, there is the full changelog changes glslang-changelog.txt, but in the commit
> message, it is truncated. It is a configuration option. In this particular case only by 2 lines, so
> extending from 3000 characters will fix this case but longer changelogs will have the same issue.
> The idea was that if the changelog, the person submitting needs to resume it and edit it.
>
> """
> ### Other
>
> * Add `--discard-is-terminate` option to emit `OpTerminateInvocation` instead of
> `OpDemoteToHelperInvocation` for GLSL `discard` when targeting SPIR-V 1.6+
> * Add REUSE license compliance infrastructure
> """
>
> There was a suggestion from Tim to include the github compare url. If it is worth I can try to
> create it but it will add some extra logic and hardcoding of github urls.
> https://lore.kernel.org/all/CANx9H-C+LOXUqnctwK3LicLdZb-qeW4erwH5SkOWTTiGOA3Uyw@mail.gmail.com/

I have not followed that development closely, so, I'm not sure it's
worth it.

If I remember correctly, patchtest checks for patches sent with AUH
author left in it. Maybe we can implement a similar check for this to
ensure this was seen by the contributor?
Something like:
* AUH puts a tag in its truncation message and
* patchtest check its absence

Thanks!
-- 
Yoann Congal
Smile ECS