From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Ayoub Zaki" <ayoub.zaki@embetrix.com>
Cc: <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
Date: Mon, 19 Oct 2026 14:22:33 +0200 [thread overview]
Message-ID: <DM8T7ZKV7U1M.1U1MVCGG316S3@smile.fr> (raw)
In-Reply-To: <2054b497-3add-46b9-8dcc-051fae96262c@embetrix.com>
On Mon Oct 19, 2026 at 2:09 PM CEST, Ayoub Zaki wrote:
> Hi Yoann,
> On 10/19/26 10:16, Yoann Congal wrote:
>> Le lun. 19 oct. 2026 à 10:04, Ayoub Zaki <ayoub.zaki@embetrix.com
>> <mailto:ayoub.zaki@embetrix.com>> a écrit :
>>
>> Hi Yoann,
>> On 10/19/26 08:43, Yoann Congal wrote:
>> > On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via
>> lists.openembedded.org <http://lists.openembedded.org> wrote:
>> >> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
>> >>
>> >> glibc 2.42 added support for arbitrary termios baud rates on
>> Linux and
>> >> changed the Bxxx speed constants from bitmasks to integer baud
>> rates.
>> >> The macros combine these values directly with c_cflag, resulting in
>> >> incorrect baud rates and garbled UART output. Use the libc functions
>> >> instead.
>> >>
>> >> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com
>> <mailto:ayoub.zaki@embetrix.com>>
>> >> ---
>> >> ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++
>> ++++++++
>> >> meta/recipes-extended/minicom/minicom_2.10.bb <http://
>> minicom_2.10.bb> | 4 +-
>> >> 2 files changed, 44 insertions(+), 1 deletion(-)
>> >> create mode 100644 meta/recipes-extended/minicom/files/0001-
>> src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
>> >
>> > Hello,
>> >
>> > I think this patch is breaking tests:
>> > [...]
>> >
>> >
>> > Can you look into this please?
>>
>> Thanks for reporting this:
>> The patch exposes a hardcoded minicom/ directory assumption in the
>> devtool selftests:
>> https://github.com/openembedded/openembedded-core/blob/master/meta/lib/
>> oeqa/selftest/cases/devtool.py#L1360 <https://github.com/
>> openembedded/openembedded-core/blob/master/meta/lib/oeqa/selftest/
>> cases/devtool.py#L1360>.
>>
>> devtool puts generated patches in the existing files/ directory but the
>> tests stage and clean up minicom/ causing both failures.
>>
>> Could we fix those selftest assumptions separately?
>>
>>
>> Yes, the test must be updated to match the modified recipe. Can you send
>> a v2 as a series, with the test fix included?
>>
>
> The same directory assumptions affect several other devtool selftests.
> I’ll send separate fixes for master and wrynose to address this more
> generally.
>
> Once the selftest fix is applied to wrynose, the original minicom patch
> can be applied unchanged.
Sounds good!
Please ping this patch when all that happened.
Thanks!
--
Yoann Congal
Smile ECS
prev parent reply other threads:[~2026-10-19 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 11:18 [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer Ayoub Zaki
2026-10-19 6:43 ` [OE-core] " Yoann Congal
2026-10-19 8:04 ` Ayoub Zaki
2026-10-19 8:16 ` Yoann Congal
2026-10-19 12:09 ` Ayoub Zaki
2026-10-19 12:22 ` Yoann Congal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8T7ZKV7U1M.1U1MVCGG316S3@smile.fr \
--to=yoann.congal@smile.fr \
--cc=ayoub.zaki@embetrix.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox