Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: <ayoub.zaki@embetrix.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
Date: Mon, 19 Oct 2026 08:43:14 +0200	[thread overview]
Message-ID: <DM8M06OIXDWR.1KFR0FLAQLZC2@smile.fr> (raw)
In-Reply-To: <20261017111813.53186-1-ayoub.zaki@embetrix.com>

On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via lists.openembedded.org wrote:
> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
>
> glibc 2.42 added support for arbitrary termios baud rates on Linux and
> changed the Bxxx speed constants from bitmasks to integer baud rates.
> The macros combine these values directly with c_cflag, resulting in
> incorrect baud rates and garbled UART output. Use the libc functions
> instead.
>
> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
> ---
>  ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++++++++++
>  meta/recipes-extended/minicom/minicom_2.10.bb |  4 +-
>  2 files changed, 44 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch

Hello,

I think this patch is breaking tests:
* oe-selftest-armhost ubuntu2404-vk-arm1 wrynose completed at 2026-10-19 03:27:48+00:00
  https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/5117
* oe-selftest-debian ubuntu2604-vk-3 wrynose completed at 2026-10-19 01:47:03+00:00
  https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/5086
* oe-selftest-fedora opensuse156-vk-1 wrynose completed at 2026-10-19 01:47:59+00:00
  https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4898

| 2026-10-18 23:09:29,596 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_update_recipe (subunit.RemotedTestCase)
| 2026-10-18 23:09:29,597 - oe-selftest - INFO -  ... FAIL
| 
| Stderr:
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
| 2026-10-18 23:09:29,599 - oe-selftest - INFO - 0: 6/66 96/678 (58.37s) (0 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe)
| 2026-10-18 23:09:29,599 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 1215, in test_devtool_update_recipe
|     result = runCmd('git add minicom', cwd=os.path.dirname(recipefile))
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 214, in runCmd
|     raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
| AssertionError: Command 'git add minicom' returned non-zero exit status 128:
| fatal: pathspec 'minicom' did not match any files
| 
| 2026-10-18 23:09:37,115 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_update_recipe_append (subunit.RemotedTestCase)
| 2026-10-18 23:09:37,115 - oe-selftest - INFO -  ... FAIL
| 
| Stderr:
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
| 2026-10-18 23:09:37,116 - oe-selftest - INFO - 0: 7/66 97/678 (7.52s) (2 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe_append)
| 2026-10-18 23:09:37,116 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 1305, in test_devtool_update_recipe_append
|     self._check_repo_status(os.path.dirname(recipefile), [])
|     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 138, in _check_repo_status
|     self.fail('Unexpected modified file in line: %s' % line)
|     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3.14/unittest/case.py", line 750, in fail
|     raise self.failureException(msg)
| AssertionError: Unexpected modified file in line: ?? meta/recipes-extended/minicom/files/0001-Change-the-README.patch


Can you look into this please?

Thanks!
-- 
Yoann Congal
Smile ECS



  reply	other threads:[~2026-10-19  6:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 11:18 [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer Ayoub Zaki
2026-10-19  6:43 ` Yoann Congal [this message]
2026-10-19  8:04   ` [OE-core] " Ayoub Zaki
2026-10-19  8:16     ` Yoann Congal
2026-10-19 12:09       ` Ayoub Zaki
2026-10-19 12:22         ` Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8M06OIXDWR.1KFR0FLAQLZC2@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=ayoub.zaki@embetrix.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox