Openembedded Core Discussions
 help / color / mirror / Atom feed
* [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
@ 2026-10-17 11:18 Ayoub Zaki
  2026-10-19  6:43 ` [OE-core] " Yoann Congal
  0 siblings, 1 reply; 6+ messages in thread
From: Ayoub Zaki @ 2026-10-17 11:18 UTC (permalink / raw)
  To: openembedded-core; +Cc: Ayoub Zaki

Backport the upstream baud rate fix to minicom 2.10 in wrynose.

glibc 2.42 added support for arbitrary termios baud rates on Linux and
changed the Bxxx speed constants from bitmasks to integer baud rates.
The macros combine these values directly with c_cflag, resulting in
incorrect baud rates and garbled UART output. Use the libc functions
instead.

Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
---
 ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++++++++++
 meta/recipes-extended/minicom/minicom_2.10.bb |  4 +-
 2 files changed, 44 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch

diff --git a/meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch b/meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
new file mode 100644
index 0000000000..3b1136768a
--- /dev/null
+++ b/meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
@@ -0,0 +1,41 @@
+From 964ae563cb5a78545ae1a4a3b6784c69ec73bc48 Mon Sep 17 00:00:00 2001
+From: Stefan Becker <chemobejk@gmail.com>
+Date: Mon, 17 Nov 2025 11:57:32 +0200
+Subject: [PATCH] src/sysdep.h: remove cfset{i,o}speed macros for glibc
+
+glibc 2.42 added support for arbitrary termios speeds on Linux, i.e.
+speed_t and Bxxx defines changed from bitmasks to unsigned integers:
+Therefore speed_t can no longer be used together with c_flag's internal
+bitmask CBAUD.
+
+When minicom is compiled on such a system the baudrate setting is broken
+and the user experiences garbled UART output.
+
+Remove the macros for glibc, i.e. call cfset{i,o}speed() instead.
+
+Fixes #17
+
+Upstream-Status: Backport [https://salsa.debian.org/minicom-team/minicom/-/commit/964ae563cb5a78545ae1a4a3b6784c69ec73bc48]
+
+Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
+---
+ src/sysdep.h | 9 ---------
+ 1 file changed, 9 deletions(-)
+
+diff --git a/src/sysdep.h b/src/sysdep.h
+index b11945c..9ba8836 100644
+--- a/src/sysdep.h
++++ b/src/sysdep.h
+@@ -141,12 +141,3 @@
+ #  define cfsetospeed(tty, spd)
+ #endif
+ #endif
+-
+-/* Redefine cfset{i,o}speed for Linux > 1.1.68 && libc < 4.5.21 */
+-#if defined (__GLIBC__) && defined(CBAUDEX)
+-#  undef cfsetispeed
+-#  undef cfsetospeed
+-#  define cfsetispeed(xtty, xspd) \
+-		((xtty)->c_cflag = ((xtty)->c_cflag & ~CBAUD) | (xspd))
+-#  define cfsetospeed(tty, spd)
+-#endif
diff --git a/meta/recipes-extended/minicom/minicom_2.10.bb b/meta/recipes-extended/minicom/minicom_2.10.bb
index 20ce5662c2..c78d70f21a 100644
--- a/meta/recipes-extended/minicom/minicom_2.10.bb
+++ b/meta/recipes-extended/minicom/minicom_2.10.bb
@@ -7,7 +7,9 @@ LICENSE = "GPL-2.0-or-later"
 LIC_FILES_CHKSUM = "file://COPYING;md5=420477abc567404debca0a2a1cb6b645 \
                     file://src/minicom.h;beginline=1;endline=12;md5=a58838cb709f0db517f4e42730c49e81"
 
-SRC_URI = "${DEBIAN_MIRROR}/main/m/${BPN}/${BPN}_${PV}.orig.tar.bz2"
+SRC_URI = "${DEBIAN_MIRROR}/main/m/${BPN}/${BPN}_${PV}.orig.tar.bz2 \
+           file://0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch \
+           "
 
 SRC_URI[sha256sum] = "90e7ce2856b3eaaa3f452354d17981c49d32c426a255b6f0d3063a227c101538"
 
-- 
2.53.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
  2026-10-17 11:18 [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer Ayoub Zaki
@ 2026-10-19  6:43 ` Yoann Congal
  2026-10-19  8:04   ` Ayoub Zaki
  0 siblings, 1 reply; 6+ messages in thread
From: Yoann Congal @ 2026-10-19  6:43 UTC (permalink / raw)
  To: ayoub.zaki, openembedded-core

On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via lists.openembedded.org wrote:
> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
>
> glibc 2.42 added support for arbitrary termios baud rates on Linux and
> changed the Bxxx speed constants from bitmasks to integer baud rates.
> The macros combine these values directly with c_cflag, resulting in
> incorrect baud rates and garbled UART output. Use the libc functions
> instead.
>
> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
> ---
>  ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++++++++++
>  meta/recipes-extended/minicom/minicom_2.10.bb |  4 +-
>  2 files changed, 44 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch

Hello,

I think this patch is breaking tests:
* oe-selftest-armhost ubuntu2404-vk-arm1 wrynose completed at 2026-10-19 03:27:48+00:00
  https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/5117
* oe-selftest-debian ubuntu2604-vk-3 wrynose completed at 2026-10-19 01:47:03+00:00
  https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/5086
* oe-selftest-fedora opensuse156-vk-1 wrynose completed at 2026-10-19 01:47:59+00:00
  https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4898

| 2026-10-18 23:09:29,596 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_update_recipe (subunit.RemotedTestCase)
| 2026-10-18 23:09:29,597 - oe-selftest - INFO -  ... FAIL
| 
| Stderr:
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
| 2026-10-18 23:09:29,599 - oe-selftest - INFO - 0: 6/66 96/678 (58.37s) (0 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe)
| 2026-10-18 23:09:29,599 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 1215, in test_devtool_update_recipe
|     result = runCmd('git add minicom', cwd=os.path.dirname(recipefile))
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 214, in runCmd
|     raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
| AssertionError: Command 'git add minicom' returned non-zero exit status 128:
| fatal: pathspec 'minicom' did not match any files
| 
| 2026-10-18 23:09:37,115 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_update_recipe_append (subunit.RemotedTestCase)
| 2026-10-18 23:09:37,115 - oe-selftest - INFO -  ... FAIL
| 
| Stderr:
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
| 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
| 2026-10-18 23:09:37,116 - oe-selftest - INFO - 0: 7/66 97/678 (7.52s) (2 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe_append)
| 2026-10-18 23:09:37,116 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 1305, in test_devtool_update_recipe_append
|     self._check_repo_status(os.path.dirname(recipefile), [])
|     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 138, in _check_repo_status
|     self.fail('Unexpected modified file in line: %s' % line)
|     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3.14/unittest/case.py", line 750, in fail
|     raise self.failureException(msg)
| AssertionError: Unexpected modified file in line: ?? meta/recipes-extended/minicom/files/0001-Change-the-README.patch


Can you look into this please?

Thanks!
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
  2026-10-19  6:43 ` [OE-core] " Yoann Congal
@ 2026-10-19  8:04   ` Ayoub Zaki
  2026-10-19  8:16     ` Yoann Congal
  0 siblings, 1 reply; 6+ messages in thread
From: Ayoub Zaki @ 2026-10-19  8:04 UTC (permalink / raw)
  To: Yoann Congal, openembedded-core

Hi Yoann,


On 10/19/26 08:43, Yoann Congal wrote:
> On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via lists.openembedded.org wrote:
>> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
>>
>> glibc 2.42 added support for arbitrary termios baud rates on Linux and
>> changed the Bxxx speed constants from bitmasks to integer baud rates.
>> The macros combine these values directly with c_cflag, resulting in
>> incorrect baud rates and garbled UART output. Use the libc functions
>> instead.
>>
>> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
>> ---
>>   ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++++++++++
>>   meta/recipes-extended/minicom/minicom_2.10.bb |  4 +-
>>   2 files changed, 44 insertions(+), 1 deletion(-)
>>   create mode 100644 meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
> 
> Hello,
> 
> I think this patch is breaking tests:
> * oe-selftest-armhost ubuntu2404-vk-arm1 wrynose completed at 2026-10-19 03:27:48+00:00
>    https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/5117
> * oe-selftest-debian ubuntu2604-vk-3 wrynose completed at 2026-10-19 01:47:03+00:00
>    https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/5086
> * oe-selftest-fedora opensuse156-vk-1 wrynose completed at 2026-10-19 01:47:59+00:00
>    https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4898
> 
> | 2026-10-18 23:09:29,596 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_update_recipe (subunit.RemotedTestCase)
> | 2026-10-18 23:09:29,597 - oe-selftest - INFO -  ... FAIL
> |
> | Stderr:
> | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
> | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
> | 2026-10-18 23:09:29,599 - oe-selftest - INFO - 0: 6/66 96/678 (58.37s) (0 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe)
> | 2026-10-18 23:09:29,599 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
> |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 1215, in test_devtool_update_recipe
> |     result = runCmd('git add minicom', cwd=os.path.dirname(recipefile))
> |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 214, in runCmd
> |     raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
> | AssertionError: Command 'git add minicom' returned non-zero exit status 128:
> | fatal: pathspec 'minicom' did not match any files
> |
> | 2026-10-18 23:09:37,115 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_update_recipe_append (subunit.RemotedTestCase)
> | 2026-10-18 23:09:37,115 - oe-selftest - INFO -  ... FAIL
> |
> | Stderr:
> | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
> | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
> | 2026-10-18 23:09:37,116 - oe-selftest - INFO - 0: 7/66 97/678 (7.52s) (2 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe_append)
> | 2026-10-18 23:09:37,116 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
> |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 1305, in test_devtool_update_recipe_append
> |     self._check_repo_status(os.path.dirname(recipefile), [])
> |     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py", line 138, in _check_repo_status
> |     self.fail('Unexpected modified file in line: %s' % line)
> |     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |   File "/usr/lib/python3.14/unittest/case.py", line 750, in fail
> |     raise self.failureException(msg)
> | AssertionError: Unexpected modified file in line: ?? meta/recipes-extended/minicom/files/0001-Change-the-README.patch
> 
> 
> Can you look into this please?



Thanks for reporting this:
The patch exposes a hardcoded minicom/ directory assumption in the 
devtool selftests:
https://github.com/openembedded/openembedded-core/blob/master/meta/lib/
oeqa/selftest/cases/devtool.py#L1360.

devtool puts generated patches in the existing files/ directory but the 
tests stage and clean up minicom/ causing both failures.

Could we fix those selftest assumptions separately?




Mit freundlichen Grüßen / Kind regards

-- 
Ayoub Zaki
Embedded Systems Consultant

Vaihinger Straße 2/1
D-71634 Ludwigsburg

Email    : ayoub.zaki@embetrix.com
Homepage : https://embetrix.com
VAT No.  : DE313902634



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
  2026-10-19  8:04   ` Ayoub Zaki
@ 2026-10-19  8:16     ` Yoann Congal
  2026-10-19 12:09       ` Ayoub Zaki
  0 siblings, 1 reply; 6+ messages in thread
From: Yoann Congal @ 2026-10-19  8:16 UTC (permalink / raw)
  To: Ayoub Zaki; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 5841 bytes --]

Le lun. 19 oct. 2026 à 10:04, Ayoub Zaki <ayoub.zaki@embetrix.com> a écrit :

> Hi Yoann,
>
>
> On 10/19/26 08:43, Yoann Congal wrote:
> > On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via
> lists.openembedded.org wrote:
> >> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
> >>
> >> glibc 2.42 added support for arbitrary termios baud rates on Linux and
> >> changed the Bxxx speed constants from bitmasks to integer baud rates.
> >> The macros combine these values directly with c_cflag, resulting in
> >> incorrect baud rates and garbled UART output. Use the libc functions
> >> instead.
> >>
> >> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
> >> ---
> >>   ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++++++++++
> >>   meta/recipes-extended/minicom/minicom_2.10.bb |  4 +-
> >>   2 files changed, 44 insertions(+), 1 deletion(-)
> >>   create mode 100644
> meta/recipes-extended/minicom/files/0001-src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
> >
> > Hello,
> >
> > I think this patch is breaking tests:
> > * oe-selftest-armhost ubuntu2404-vk-arm1 wrynose completed at 2026-10-19
> 03:27:48+00:00
> >
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/5117
> > * oe-selftest-debian ubuntu2604-vk-3 wrynose completed at 2026-10-19
> 01:47:03+00:00
> >
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/5086
> > * oe-selftest-fedora opensuse156-vk-1 wrynose completed at 2026-10-19
> 01:47:59+00:00
> >
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4898
> >
> > | 2026-10-18 23:09:29,596 - oe-selftest - INFO -
> devtool.DevtoolUpdateTests.test_devtool_update_recipe
> (subunit.RemotedTestCase)
> > | 2026-10-18 23:09:29,597 - oe-selftest - INFO -  ... FAIL
> > |
> > | Stderr:
> > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
> selftest.inc" in
> /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
> > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
> bblayers.inc" in bblayers.conf
> > | 2026-10-18 23:09:29,599 - oe-selftest - INFO - 0: 6/66 96/678 (58.37s)
> (0 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe)
> > | 2026-10-18 23:09:29,599 - oe-selftest - INFO -
> testtools.testresult.real._StringException: Traceback (most recent call
> last):
> > |   File
> "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py",
> line 1215, in test_devtool_update_recipe
> > |     result = runCmd('git add minicom', cwd=os.path.dirname(recipefile))
> > |   File
> "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py",
> line 214, in runCmd
> > |     raise AssertionError("Command '%s' returned non-zero exit status
> %d:\n%s" % (command, result.status, exc_output))
> > | AssertionError: Command 'git add minicom' returned non-zero exit
> status 128:
> > | fatal: pathspec 'minicom' did not match any files
> > |
> > | 2026-10-18 23:09:37,115 - oe-selftest - INFO -
> devtool.DevtoolUpdateTests.test_devtool_update_recipe_append
> (subunit.RemotedTestCase)
> > | 2026-10-18 23:09:37,115 - oe-selftest - INFO -  ... FAIL
> > |
> > | Stderr:
> > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
> selftest.inc" in
> /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-1224754/conf/local.conf
> > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
> bblayers.inc" in bblayers.conf
> > | 2026-10-18 23:09:37,116 - oe-selftest - INFO - 0: 7/66 97/678 (7.52s)
> (2 failed) (devtool.DevtoolUpdateTests.test_devtool_update_recipe_append)
> > | 2026-10-18 23:09:37,116 - oe-selftest - INFO -
> testtools.testresult.real._StringException: Traceback (most recent call
> last):
> > |   File
> "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py",
> line 1305, in test_devtool_update_recipe_append
> > |     self._check_repo_status(os.path.dirname(recipefile), [])
> > |     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > |   File
> "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py",
> line 138, in _check_repo_status
> > |     self.fail('Unexpected modified file in line: %s' % line)
> > |     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > |   File "/usr/lib/python3.14/unittest/case.py", line 750, in fail
> > |     raise self.failureException(msg)
> > | AssertionError: Unexpected modified file in line: ??
> meta/recipes-extended/minicom/files/0001-Change-the-README.patch
> >
> >
> > Can you look into this please?
>
>
>
> Thanks for reporting this:
> The patch exposes a hardcoded minicom/ directory assumption in the
> devtool selftests:
> https://github.com/openembedded/openembedded-core/blob/master/meta/lib/
> oeqa/selftest/cases/devtool.py#L1360
> <https://github.com/openembedded/openembedded-core/blob/master/meta/lib/oeqa/selftest/cases/devtool.py#L1360>
> .
>
> devtool puts generated patches in the existing files/ directory but the
> tests stage and clean up minicom/ causing both failures.
>
> Could we fix those selftest assumptions separately?
>

Yes, the test must be updated to match the modified recipe. Can you send a
v2 as a series, with the test fix included?

Thanks!


>
>
> Mit freundlichen Grüßen / Kind regards
>
> --
> Ayoub Zaki
> Embedded Systems Consultant
>
> Vaihinger Straße 2/1
> D-71634 Ludwigsburg
>
> Email    : ayoub.zaki@embetrix.com
> Homepage : https://embetrix.com
> VAT No.  : DE313902634
>
>

-- 
Yoann Congal
Smile ECS

[-- Attachment #2: Type: text/html, Size: 7841 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
  2026-10-19  8:16     ` Yoann Congal
@ 2026-10-19 12:09       ` Ayoub Zaki
  2026-10-19 12:22         ` Yoann Congal
  0 siblings, 1 reply; 6+ messages in thread
From: Ayoub Zaki @ 2026-10-19 12:09 UTC (permalink / raw)
  To: Yoann Congal; +Cc: openembedded-core

Hi Yoann,

On 10/19/26 10:16, Yoann Congal wrote:
> 
> 
> Le lun. 19 oct. 2026 à 10:04, Ayoub Zaki <ayoub.zaki@embetrix.com 
> <mailto:ayoub.zaki@embetrix.com>> a écrit :
> 
>     Hi Yoann,
> 
> 
>     On 10/19/26 08:43, Yoann Congal wrote:
>      > On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via
>     lists.openembedded.org <http://lists.openembedded.org> wrote:
>      >> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
>      >>
>      >> glibc 2.42 added support for arbitrary termios baud rates on
>     Linux and
>      >> changed the Bxxx speed constants from bitmasks to integer baud
>     rates.
>      >> The macros combine these values directly with c_cflag, resulting in
>      >> incorrect baud rates and garbled UART output. Use the libc functions
>      >> instead.
>      >>
>      >> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com
>     <mailto:ayoub.zaki@embetrix.com>>
>      >> ---
>      >>   ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++
>     ++++++++
>      >>   meta/recipes-extended/minicom/minicom_2.10.bb <http://
>     minicom_2.10.bb> |  4 +-
>      >>   2 files changed, 44 insertions(+), 1 deletion(-)
>      >>   create mode 100644 meta/recipes-extended/minicom/files/0001-
>     src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
>      >
>      > Hello,
>      >
>      > I think this patch is breaking tests:
>      > * oe-selftest-armhost ubuntu2404-vk-arm1 wrynose completed at
>     2026-10-19 03:27:48+00:00
>      > https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/
>     builds/5117 <https://autobuilder.yoctoproject.org/valkyrie/#/
>     builders/23/builds/5117>
>      > * oe-selftest-debian ubuntu2604-vk-3 wrynose completed at
>     2026-10-19 01:47:03+00:00
>      > https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/
>     builds/5086 <https://autobuilder.yoctoproject.org/valkyrie/#/
>     builders/35/builds/5086>
>      > * oe-selftest-fedora opensuse156-vk-1 wrynose completed at
>     2026-10-19 01:47:59+00:00
>      > https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/
>     builds/4898 <https://autobuilder.yoctoproject.org/valkyrie/#/
>     builders/48/builds/4898>
>      >
>      > | 2026-10-18 23:09:29,596 - oe-selftest - INFO -
>     devtool.DevtoolUpdateTests.test_devtool_update_recipe
>     (subunit.RemotedTestCase)
>      > | 2026-10-18 23:09:29,597 - oe-selftest - INFO -  ... FAIL
>      > |
>      > | Stderr:
>      > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
>     selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/
>     build/build-st-1224754/conf/local.conf
>      > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
>     bblayers.inc" in bblayers.conf
>      > | 2026-10-18 23:09:29,599 - oe-selftest - INFO - 0: 6/66 96/678
>     (58.37s) (0 failed)
>     (devtool.DevtoolUpdateTests.test_devtool_update_recipe)
>      > | 2026-10-18 23:09:29,599 - oe-selftest - INFO -
>     testtools.testresult.real._StringException: Traceback (most recent
>     call last):
>      > |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/
>     layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py",
>     line 1215, in test_devtool_update_recipe
>      > |     result = runCmd('git add minicom',
>     cwd=os.path.dirname(recipefile))
>      > |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/
>     layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 214,
>     in runCmd
>      > |     raise AssertionError("Command '%s' returned non-zero exit
>     status %d:\n%s" % (command, result.status, exc_output))
>      > | AssertionError: Command 'git add minicom' returned non-zero
>     exit status 128:
>      > | fatal: pathspec 'minicom' did not match any files
>      > |
>      > | 2026-10-18 23:09:37,115 - oe-selftest - INFO -
>     devtool.DevtoolUpdateTests.test_devtool_update_recipe_append
>     (subunit.RemotedTestCase)
>      > | 2026-10-18 23:09:37,115 - oe-selftest - INFO -  ... FAIL
>      > |
>      > | Stderr:
>      > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
>     selftest.inc" in /srv/pokybuild/yocto-worker/oe-selftest-debian/
>     build/build-st-1224754/conf/local.conf
>      > | 2026-10-18 23:00:35,915 - oe-selftest - INFO - Adding: "include
>     bblayers.inc" in bblayers.conf
>      > | 2026-10-18 23:09:37,116 - oe-selftest - INFO - 0: 7/66 97/678
>     (7.52s) (2 failed)
>     (devtool.DevtoolUpdateTests.test_devtool_update_recipe_append)
>      > | 2026-10-18 23:09:37,116 - oe-selftest - INFO -
>     testtools.testresult.real._StringException: Traceback (most recent
>     call last):
>      > |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/
>     layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py",
>     line 1305, in test_devtool_update_recipe_append
>      > |     self._check_repo_status(os.path.dirname(recipefile), [])
>      > |     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>      > |   File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/
>     layers/openembedded-core/meta/lib/oeqa/selftest/cases/devtool.py",
>     line 138, in _check_repo_status
>      > |     self.fail('Unexpected modified file in line: %s' % line)
>      > |     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>      > |   File "/usr/lib/python3.14/unittest/case.py", line 750, in fail
>      > |     raise self.failureException(msg)
>      > | AssertionError: Unexpected modified file in line: ?? meta/
>     recipes-extended/minicom/files/0001-Change-the-README.patch
>      >
>      >
>      > Can you look into this please?
> 
> 
> 
>     Thanks for reporting this:
>     The patch exposes a hardcoded minicom/ directory assumption in the
>     devtool selftests:
>     https://github.com/openembedded/openembedded-core/blob/master/meta/lib/
>     oeqa/selftest/cases/devtool.py#L1360 <https://github.com/
>     openembedded/openembedded-core/blob/master/meta/lib/oeqa/selftest/
>     cases/devtool.py#L1360>.
> 
>     devtool puts generated patches in the existing files/ directory but the
>     tests stage and clean up minicom/ causing both failures.
> 
>     Could we fix those selftest assumptions separately?
> 
> 
> Yes, the test must be updated to match the modified recipe. Can you send 
> a v2 as a series, with the test fix included?
> 

The same directory assumptions affect several other devtool selftests. 
I’ll send separate fixes for master and wrynose to address this more 
generally.

Once the selftest fix is applied to wrynose, the original minicom patch 
can be applied unchanged.

Thanks,


Mit freundlichen Grüßen / Kind regards

-- 
Ayoub Zaki
Embedded Systems Consultant

Vaihinger Straße 2/1
D-71634 Ludwigsburg

Mobile   : +4917662901545
Email    : ayoub.zaki@embetrix.com
Homepage : https://embetrix.com
VAT No.  : DE313902634



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer
  2026-10-19 12:09       ` Ayoub Zaki
@ 2026-10-19 12:22         ` Yoann Congal
  0 siblings, 0 replies; 6+ messages in thread
From: Yoann Congal @ 2026-10-19 12:22 UTC (permalink / raw)
  To: Ayoub Zaki; +Cc: openembedded-core

On Mon Oct 19, 2026 at 2:09 PM CEST, Ayoub Zaki wrote:
> Hi Yoann,
> On 10/19/26 10:16, Yoann Congal wrote:
>> Le lun. 19 oct. 2026 à 10:04, Ayoub Zaki <ayoub.zaki@embetrix.com 
>> <mailto:ayoub.zaki@embetrix.com>> a écrit :
>> 
>>     Hi Yoann,
>>     On 10/19/26 08:43, Yoann Congal wrote:
>>      > On Sat Oct 17, 2026 at 1:18 PM CEST, Ayoub Zaki via
>>     lists.openembedded.org <http://lists.openembedded.org> wrote:
>>      >> Backport the upstream baud rate fix to minicom 2.10 in wrynose.
>>      >>
>>      >> glibc 2.42 added support for arbitrary termios baud rates on
>>     Linux and
>>      >> changed the Bxxx speed constants from bitmasks to integer baud
>>     rates.
>>      >> The macros combine these values directly with c_cflag, resulting in
>>      >> incorrect baud rates and garbled UART output. Use the libc functions
>>      >> instead.
>>      >>
>>      >> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com
>>     <mailto:ayoub.zaki@embetrix.com>>
>>      >> ---
>>      >>   ...ove-cfset-i-o-speed-macros-for-glibc.patch | 41 +++++++++++
>>     ++++++++
>>      >>   meta/recipes-extended/minicom/minicom_2.10.bb <http://
>>     minicom_2.10.bb> |  4 +-
>>      >>   2 files changed, 44 insertions(+), 1 deletion(-)
>>      >>   create mode 100644 meta/recipes-extended/minicom/files/0001-
>>     src-sysdep.h-remove-cfset-i-o-speed-macros-for-glibc.patch
>>      >
>>      > Hello,
>>      >
>>      > I think this patch is breaking tests:
>>      > [...]
>>      >
>>      >
>>      > Can you look into this please?
>> 
>>     Thanks for reporting this:
>>     The patch exposes a hardcoded minicom/ directory assumption in the
>>     devtool selftests:
>>     https://github.com/openembedded/openembedded-core/blob/master/meta/lib/
>>     oeqa/selftest/cases/devtool.py#L1360 <https://github.com/
>>     openembedded/openembedded-core/blob/master/meta/lib/oeqa/selftest/
>>     cases/devtool.py#L1360>.
>> 
>>     devtool puts generated patches in the existing files/ directory but the
>>     tests stage and clean up minicom/ causing both failures.
>> 
>>     Could we fix those selftest assumptions separately?
>> 
>> 
>> Yes, the test must be updated to match the modified recipe. Can you send 
>> a v2 as a series, with the test fix included?
>> 
>
> The same directory assumptions affect several other devtool selftests. 
> I’ll send separate fixes for master and wrynose to address this more 
> generally.
>
> Once the selftest fix is applied to wrynose, the original minicom patch 
> can be applied unchanged.

Sounds good!
Please ping this patch when all that happened.

Thanks!
-- 
Yoann Congal
Smile ECS



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-10-19 12:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-17 11:18 [wrynose][PATCH] minicom: fix baud rate setting with glibc 2.42 and newer Ayoub Zaki
2026-10-19  6:43 ` [OE-core] " Yoann Congal
2026-10-19  8:04   ` Ayoub Zaki
2026-10-19  8:16     ` Yoann Congal
2026-10-19 12:09       ` Ayoub Zaki
2026-10-19 12:22         ` Yoann Congal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox