* [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd
2026-10-19 8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
@ 2026-10-19 8:23 ` Jinwang Li
2026-10-20 7:55 ` [OE-core] " Yoann Congal
2026-10-19 8:23 ` [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd Jinwang Li
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Jinwang Li @ 2026-10-19 8:23 UTC (permalink / raw)
To: openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
jinwang.li, xiuzhuo.shang
Return BAD_STATE instead of BAD_ACP_SEID when the SEID maps to a
valid local SEP.
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
...ix-error-handling-for-AVDTP_OPEN-cmd.patch | 49 +++++++++++++++++++
2 files changed, 50 insertions(+)
create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index d857c23a57..169269d377 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -76,6 +76,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
file://0001-src-device-Fix-stored-gatt-cache-DB-Hash-value-no.patch \
file://0001-profile-Set-L2CAP-IMTU-for-OBEX-profile-listeners.patch \
file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \
+ file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
"
S = "${UNPACKDIR}/bluez-${PV}"
diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch
new file mode 100644
index 0000000000..0d346a2258
--- /dev/null
+++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch
@@ -0,0 +1,49 @@
+From 4e0aba5a8ebd969b68cd3442e9f8066a4b15a366 Mon Sep 17 00:00:00 2001
+From: Simon Mikuda <simon.mikuda@streamunlimited.com>
+Date: Mon, 8 Jun 2026 13:29:23 +0200
+Subject: [PATCH] avdtp: Fix error handling for AVDTP_OPEN cmd
+
+We have to return BAD_STATE when local SEP is available instead of
+BAD_ACP_SEID.
+
+This fixes: AVDTP/SNK/ACP/SIG/SMG/BI-26-C
+Upstream-Status: Backport [https://github.com/bluez/bluez/commit/7c1c90f7b6d0f653c581878a039e2d02362f33f5]
+Signed-off-by: Simon Mikuda <simon.mikuda@streamunlimited.com>
+Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
+---
+ profiles/audio/avdtp.c | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
+index b57ba609b..56d27b973 100644
+--- a/profiles/audio/avdtp.c
++++ b/profiles/audio/avdtp.c
+@@ -1777,13 +1777,14 @@ static gboolean avdtp_open_cmd(struct avdtp *session, uint8_t transaction,
+ return FALSE;
+ }
+
+- stream = find_stream_by_lseid(session, req->acp_seid);
+- if (!stream) {
++ sep = find_local_sep_by_seid(session, req->acp_seid);
++ if (!sep) {
+ err = AVDTP_BAD_ACP_SEID;
+ goto failed;
+ }
+
+- if (stream->state != AVDTP_STATE_CONFIGURED) {
++ stream = find_stream_by_lsep(session, sep);
++ if (!stream || stream->state != AVDTP_STATE_CONFIGURED) {
+ err = AVDTP_BAD_STATE;
+ goto failed;
+ }
+@@ -1796,7 +1797,6 @@ static gboolean avdtp_open_cmd(struct avdtp *session, uint8_t transaction,
+ AVDTP_OPEN, NULL, 0);
+ }
+
+- sep = stream->lsep;
+ if (sep->ind && sep->ind->open && !session->pending_open) {
+ if (!sep->ind->open(session, sep, stream, &err,
+ sep->user_data))
+--
+2.34.1
+
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd
2026-10-19 8:23 ` [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd Jinwang Li
@ 2026-10-20 7:55 ` Yoann Congal
0 siblings, 0 replies; 11+ messages in thread
From: Yoann Congal @ 2026-10-20 7:55 UTC (permalink / raw)
To: jinwang.li, openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
xiuzhuo.shang
On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
> Return BAD_STATE instead of BAD_ACP_SEID when the SEID maps to a
> valid local SEP.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
> ...ix-error-handling-for-AVDTP_OPEN-cmd.patch | 49 +++++++++++++++++++
> 2 files changed, 50 insertions(+)
> create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index d857c23a57..169269d377 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -76,6 +76,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> file://0001-src-device-Fix-stored-gatt-cache-DB-Hash-value-no.patch \
> file://0001-profile-Set-L2CAP-IMTU-for-OBEX-profile-listeners.patch \
> file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \
> + file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
> "
> S = "${UNPACKDIR}/bluez-${PV}"
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch
> new file mode 100644
> index 0000000000..0d346a2258
> --- /dev/null
> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch
> @@ -0,0 +1,49 @@
> +From 4e0aba5a8ebd969b68cd3442e9f8066a4b15a366 Mon Sep 17 00:00:00 2001
> +From: Simon Mikuda <simon.mikuda@streamunlimited.com>
> +Date: Mon, 8 Jun 2026 13:29:23 +0200
> +Subject: [PATCH] avdtp: Fix error handling for AVDTP_OPEN cmd
> +
> +We have to return BAD_STATE when local SEP is available instead of
> +BAD_ACP_SEID.
> +
> +This fixes: AVDTP/SNK/ACP/SIG/SMG/BI-26-C
> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/7c1c90f7b6d0f653c581878a039e2d02362f33f5]
> +Signed-off-by: Simon Mikuda <simon.mikuda@streamunlimited.com>
> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
Hello,
Simon Mikuda's SoB is not in the upstream commit.
Please remove it.
Regards,
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 11+ messages in thread
* [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd
2026-10-19 8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
2026-10-19 8:23 ` [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd Jinwang Li
@ 2026-10-19 8:23 ` Jinwang Li
2026-10-20 7:55 ` [OE-core] " Yoann Congal
2026-10-19 8:23 ` [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse Jinwang Li
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Jinwang Li @ 2026-10-19 8:23 UTC (permalink / raw)
To: openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
jinwang.li, xiuzhuo.shang
Check the resolved stream instead of an always-NULL sep pointer
when testing for BAD_ACP_SEID.
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
...0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch | 37 +++++++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index 169269d377..7e05bda4f1 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -77,6 +77,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
file://0001-profile-Set-L2CAP-IMTU-for-OBEX-profile-listeners.patch \
file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \
file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
+ file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
"
S = "${UNPACKDIR}/bluez-${PV}"
diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch
new file mode 100644
index 0000000000..eb1738f75c
--- /dev/null
+++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch
@@ -0,0 +1,37 @@
+From 8e5ca68aeee22970e3ccf3bbb30c050938ba09a2 Mon Sep 17 00:00:00 2001
+From: Simon Mikuda <simon.mikuda@streamunlimited.com>
+Date: Mon, 8 Jun 2026 13:29:22 +0200
+Subject: [PATCH] avdtp: Fix GET_CONFIGURATION cmd
+
+This fixes AVDTP/SNK/ACP/SIG/SMG/BV-12-C
+Upstream-Status: Backport [https://github.com/bluez/bluez/commit/60437c06560e46d211aaf99620cc9510dfd8081f]
+Signed-off-by: Simon Mikuda <simon.mikuda@streamunlimited.com>
+Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
+---
+ profiles/audio/avdtp.c | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
+index d475a545e..7cfc9a80d 100644
+--- a/profiles/audio/avdtp.c
++++ b/profiles/audio/avdtp.c
+@@ -1641,7 +1641,6 @@ static gboolean avdtp_getconf_cmd(struct avdtp *session, uint8_t transaction,
+ struct seid_req *req, int size)
+ {
+ GSList *l;
+- struct avdtp_local_sep *sep = NULL;
+ struct avdtp_stream *stream;
+ int rsp_size;
+ uint8_t err;
+@@ -1656,7 +1655,7 @@ static gboolean avdtp_getconf_cmd(struct avdtp *session, uint8_t transaction,
+ memset(buf, 0, sizeof(buf));
+
+ stream = find_stream_by_lseid(session, req->acp_seid);
+- if (!sep) {
++ if (!stream) {
+ err = AVDTP_BAD_ACP_SEID;
+ goto failed;
+ }
+--
+2.34.1
+
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd
2026-10-19 8:23 ` [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd Jinwang Li
@ 2026-10-20 7:55 ` Yoann Congal
0 siblings, 0 replies; 11+ messages in thread
From: Yoann Congal @ 2026-10-20 7:55 UTC (permalink / raw)
To: jinwang.li, openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
xiuzhuo.shang
On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
> Check the resolved stream instead of an always-NULL sep pointer
> when testing for BAD_ACP_SEID.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
> ...0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch | 37 +++++++++++++++++++
> 2 files changed, 38 insertions(+)
> create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 169269d377..7e05bda4f1 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -77,6 +77,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> file://0001-profile-Set-L2CAP-IMTU-for-OBEX-profile-listeners.patch \
> file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \
> file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
> + file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
> "
> S = "${UNPACKDIR}/bluez-${PV}"
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch
> new file mode 100644
> index 0000000000..eb1738f75c
> --- /dev/null
> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch
> @@ -0,0 +1,37 @@
> +From 8e5ca68aeee22970e3ccf3bbb30c050938ba09a2 Mon Sep 17 00:00:00 2001
> +From: Simon Mikuda <simon.mikuda@streamunlimited.com>
> +Date: Mon, 8 Jun 2026 13:29:22 +0200
> +Subject: [PATCH] avdtp: Fix GET_CONFIGURATION cmd
> +
> +This fixes AVDTP/SNK/ACP/SIG/SMG/BV-12-C
> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/60437c06560e46d211aaf99620cc9510dfd8081f]
> +Signed-off-by: Simon Mikuda <simon.mikuda@streamunlimited.com>
> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
Hello,
Simon Mikuda's SoB is not in the upstream commit.
Please remove it.
Regards,
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 11+ messages in thread
* [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse
2026-10-19 8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
2026-10-19 8:23 ` [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd Jinwang Li
2026-10-19 8:23 ` [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd Jinwang Li
@ 2026-10-19 8:23 ` Jinwang Li
2026-10-20 7:56 ` [OE-core] " Yoann Congal
2026-10-19 8:23 ` [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded Jinwang Li
2026-10-19 8:23 ` [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4] Jinwang Li
4 siblings, 1 reply; 11+ messages in thread
From: Jinwang Li @ 2026-10-19 8:23 UTC (permalink / raw)
To: openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
jinwang.li, xiuzhuo.shang
Reject AVDTP_SET_CONFIGURATION with SEP_IN_USE when the SEID is
already bound to an active stream.
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
...turn-correct-error-when-SEP-is-inuse.patch | 33 +++++++++++++++++++
2 files changed, 34 insertions(+)
create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index 7e05bda4f1..de9835e5a7 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -78,6 +78,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \
file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
+ file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
"
S = "${UNPACKDIR}/bluez-${PV}"
diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch
new file mode 100644
index 0000000000..76121a7eb6
--- /dev/null
+++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch
@@ -0,0 +1,33 @@
+From f1bbe63447bcc69beb546bc1e26a4e99c529d70e Mon Sep 17 00:00:00 2001
+From: Simon Mikuda <simon.mikuda@streamunlimited.com>
+Date: Tue, 9 Jun 2026 23:30:13 +0200
+Subject: [PATCH] avdtp: Return correct error when SEP is inuse
+
+This fixes AVDTP/SNK/ACP/SIG/SMG/BI-08-C
+Upstream-Status: Backport [https://github.com/bluez/bluez/commit/39ad431de60b896a03904887a0f1d0285b719edd]
+Signed-off-by: Simon Mikuda <simon.mikuda@streamunlimited.com>
+Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
+---
+ profiles/audio/avdtp.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
+index 7cfc9a80d..b57ba609b 100644
+--- a/profiles/audio/avdtp.c
++++ b/profiles/audio/avdtp.c
+@@ -1556,6 +1556,12 @@ static gboolean avdtp_setconf_cmd(struct avdtp *session, uint8_t transaction,
+ goto failed;
+ }
+
++ /* check if SEID is in use */
++ if (find_stream_by_lsep(session, sep)) {
++ err = AVDTP_SEP_IN_USE;
++ goto failed;
++ }
++
+ switch (sep->info.type) {
+ case AVDTP_SEP_TYPE_SOURCE:
+ service = btd_device_get_service(session->device,
+--
+2.34.1
+
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse
2026-10-19 8:23 ` [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse Jinwang Li
@ 2026-10-20 7:56 ` Yoann Congal
0 siblings, 0 replies; 11+ messages in thread
From: Yoann Congal @ 2026-10-20 7:56 UTC (permalink / raw)
To: jinwang.li, openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
xiuzhuo.shang
On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
> Reject AVDTP_SET_CONFIGURATION with SEP_IN_USE when the SEID is
> already bound to an active stream.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
> ...turn-correct-error-when-SEP-is-inuse.patch | 33 +++++++++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 7e05bda4f1..de9835e5a7 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -78,6 +78,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \
> file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
> file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
> + file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
> "
> S = "${UNPACKDIR}/bluez-${PV}"
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch
> new file mode 100644
> index 0000000000..76121a7eb6
> --- /dev/null
> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch
> @@ -0,0 +1,33 @@
> +From f1bbe63447bcc69beb546bc1e26a4e99c529d70e Mon Sep 17 00:00:00 2001
> +From: Simon Mikuda <simon.mikuda@streamunlimited.com>
> +Date: Tue, 9 Jun 2026 23:30:13 +0200
> +Subject: [PATCH] avdtp: Return correct error when SEP is inuse
> +
> +This fixes AVDTP/SNK/ACP/SIG/SMG/BI-08-C
> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/39ad431de60b896a03904887a0f1d0285b719edd]
> +Signed-off-by: Simon Mikuda <simon.mikuda@streamunlimited.com>
> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
Hello,
Simon Mikuda's SoB is not in the upstream commit.
Please remove it.
Regards,
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 11+ messages in thread
* [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded
2026-10-19 8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
` (2 preceding siblings ...)
2026-10-19 8:23 ` [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse Jinwang Li
@ 2026-10-19 8:23 ` Jinwang Li
2026-10-20 7:57 ` [OE-core] " Yoann Congal
2026-10-19 8:23 ` [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4] Jinwang Li
4 siblings, 1 reply; 11+ messages in thread
From: Jinwang Li @ 2026-10-19 8:23 UTC (permalink / raw)
To: openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
jinwang.li, xiuzhuo.shang
Send the ABORT response after transfer_complete(), since it clears
the pending tx queue and was discarding the response first.
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
...x-Fix-ABORT-response-being-discarded.patch | 44 +++++++++++++++++++
2 files changed, 45 insertions(+)
create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index de9835e5a7..db650acdd0 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -79,6 +79,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
+ file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
"
S = "${UNPACKDIR}/bluez-${PV}"
diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
new file mode 100644
index 0000000000..5c0d7414ee
--- /dev/null
+++ b/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
@@ -0,0 +1,44 @@
+From 38a88cc433e0bc3cccb6dab126e484fc06ccd8bb Mon Sep 17 00:00:00 2001
+From: Jinwang Li <jinwang.li@oss.qualcomm.com>
+Date: Thu, 27 Aug 2026 16:36:51 +0800
+Subject: [PATCH] gobex: Fix ABORT response being discarded
+
+g_obex_drop_tx_queue() in transfer_complete() clears any pending tx,
+so the ABORT success response should be enqueued after transfer_complete().
+
+Fixes the following PTS test cases:
+- OPP/SR/OPH/BV-27-I
+- FTP/SR/OTR/BV-02-C
+- PBAP/PSE/PDF/BV-06-I
+- PBAP/PSE/PBF/BV-03-I
+
+Fixes: 7a35c12a6ceb ("gobex: Fix segfault caused by interrupted transfer")
+Upstream-Status: Backport [https://github.com/bluez/bluez/commit/d094be10ff0cc9d48714d35557e0fd297f36f907]
+Assisted-by: Claude:claude-sonnet-5
+Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
+---
+ gobex/gobex-transfer.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/gobex/gobex-transfer.c b/gobex/gobex-transfer.c
+index c94d018b2..e4c7c557d 100644
+--- a/gobex/gobex-transfer.c
++++ b/gobex/gobex-transfer.c
+@@ -314,11 +314,12 @@ static void transfer_abort_req(GObex *obex, GObexPacket *req, gpointer user_data
+
+ err = g_error_new(G_OBEX_ERROR, G_OBEX_ERROR_CANCELLED,
+ "Request was aborted");
+- rsp = g_obex_packet_new(G_OBEX_RSP_SUCCESS, TRUE, G_OBEX_HDR_INVALID);
+- g_obex_send(obex, rsp, NULL);
+
+ transfer_complete(transfer, err);
+ g_error_free(err);
++
++ rsp = g_obex_packet_new(G_OBEX_RSP_SUCCESS, TRUE, G_OBEX_HDR_INVALID);
++ g_obex_send(obex, rsp, NULL);
+ }
+
+ static guint8 put_get_bytes(struct transfer *transfer, GObexPacket *req)
+--
+2.34.1
+
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded
2026-10-19 8:23 ` [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded Jinwang Li
@ 2026-10-20 7:57 ` Yoann Congal
0 siblings, 0 replies; 11+ messages in thread
From: Yoann Congal @ 2026-10-20 7:57 UTC (permalink / raw)
To: jinwang.li, openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
xiuzhuo.shang
On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
> Send the ABORT response after transfer_complete(), since it clears
> the pending tx queue and was discarding the response first.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
> ...x-Fix-ABORT-response-being-discarded.patch | 44 +++++++++++++++++++
> 2 files changed, 45 insertions(+)
> create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index de9835e5a7..db650acdd0 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -79,6 +79,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
> file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
> file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
> + file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
> "
> S = "${UNPACKDIR}/bluez-${PV}"
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
> new file mode 100644
> index 0000000000..5c0d7414ee
> --- /dev/null
> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
> @@ -0,0 +1,44 @@
> +From 38a88cc433e0bc3cccb6dab126e484fc06ccd8bb Mon Sep 17 00:00:00 2001
> +From: Jinwang Li <jinwang.li@oss.qualcomm.com>
> +Date: Thu, 27 Aug 2026 16:36:51 +0800
> +Subject: [PATCH] gobex: Fix ABORT response being discarded
> +
> +g_obex_drop_tx_queue() in transfer_complete() clears any pending tx,
> +so the ABORT success response should be enqueued after transfer_complete().
> +
> +Fixes the following PTS test cases:
> +- OPP/SR/OPH/BV-27-I
> +- FTP/SR/OTR/BV-02-C
> +- PBAP/PSE/PDF/BV-06-I
> +- PBAP/PSE/PBF/BV-03-I
> +
> +Fixes: 7a35c12a6ceb ("gobex: Fix segfault caused by interrupted transfer")
> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/d094be10ff0cc9d48714d35557e0fd297f36f907]
> +Assisted-by: Claude:claude-sonnet-5
> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
Hello,
Is that commit included in master and blacksail? If not, can you send
the needed upgrades/backports so I can merge this here?
Thanks!
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 11+ messages in thread
* [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4]
2026-10-19 8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
` (3 preceding siblings ...)
2026-10-19 8:23 ` [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded Jinwang Li
@ 2026-10-19 8:23 ` Jinwang Li
2026-10-20 7:58 ` [OE-core] " Yoann Congal
4 siblings, 1 reply; 11+ messages in thread
From: Jinwang Li @ 2026-10-19 8:23 UTC (permalink / raw)
To: openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
jinwang.li, xiuzhuo.shang
data[3] was used twice, skipping data[4] in the output string.
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
...p-Fix-u128_to_string-skipping-data-4.patch | 33 +++++++++++++++++++
2 files changed, 34 insertions(+)
create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index db650acdd0..75d76cf96d 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -80,6 +80,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
+ file://0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch \
"
S = "${UNPACKDIR}/bluez-${PV}"
diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
new file mode 100644
index 0000000000..338bc228c1
--- /dev/null
+++ b/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
@@ -0,0 +1,33 @@
+From 198f4e0785644cea2b2154b383fc4ad354707947 Mon Sep 17 00:00:00 2001
+From: Jinwang Li <jinwang.li@oss.qualcomm.com>
+Date: Wed, 23 Sep 2026 11:29:57 +0800
+Subject: [PATCH] obexd/pbap: Fix u128_to_string skipping data[4]
+
+u128_to_string uses data[3] twice causing data[4] to be skipped and
+DatabaseIdentifier, PrimaryCounter and SecondaryCounter properties to
+be printed with wrong values.
+
+Fixes: 5ee26d43c65c ("obexd/client: Add DatabaseIdentifier property")
+Upstream-Status: Backport [https://github.com/bluez/bluez/commit/8b4a4176063831476bc9244d20f43b552e4b5554]
+Assisted-by: opencode:claude-sonnet-5
+Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
+---
+ obexd/client/pbap.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
+index 0f575e61e..d89b6aafa 100644
+--- a/obexd/client/pbap.c
++++ b/obexd/client/pbap.c
+@@ -1098,7 +1098,7 @@ static int u128_to_string(uint8_t *data, char *str, size_t len)
+ return snprintf(str, len, "%02X%02X%02X%02X%02X%02X%02X%02X"
+ "%02X%02X%02X%02X%02X%02X%02X%02X",
+ data[0], data[1], data[2], data[3],
+- data[3], data[5], data[6], data[7],
++ data[4], data[5], data[6], data[7],
+ data[8], data[9], data[10], data[11],
+ data[12], data[13], data[14], data[15]);
+ }
+--
+2.34.1
+
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4]
2026-10-19 8:23 ` [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4] Jinwang Li
@ 2026-10-20 7:58 ` Yoann Congal
0 siblings, 0 replies; 11+ messages in thread
From: Yoann Congal @ 2026-10-20 7:58 UTC (permalink / raw)
To: jinwang.li, openembedded-core
Cc: cheng.jiang, quic_chezhou, wei.deng, shuai.zhang, mengshi.wu,
xiuzhuo.shang
On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
> data[3] was used twice, skipping data[4] in the output string.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
> ...p-Fix-u128_to_string-skipping-data-4.patch | 33 +++++++++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index db650acdd0..75d76cf96d 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -80,6 +80,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
> file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
> file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
> + file://0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch \
> "
> S = "${UNPACKDIR}/bluez-${PV}"
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
> new file mode 100644
> index 0000000000..338bc228c1
> --- /dev/null
> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
> @@ -0,0 +1,33 @@
> +From 198f4e0785644cea2b2154b383fc4ad354707947 Mon Sep 17 00:00:00 2001
> +From: Jinwang Li <jinwang.li@oss.qualcomm.com>
> +Date: Wed, 23 Sep 2026 11:29:57 +0800
> +Subject: [PATCH] obexd/pbap: Fix u128_to_string skipping data[4]
> +
> +u128_to_string uses data[3] twice causing data[4] to be skipped and
> +DatabaseIdentifier, PrimaryCounter and SecondaryCounter properties to
> +be printed with wrong values.
> +
> +Fixes: 5ee26d43c65c ("obexd/client: Add DatabaseIdentifier property")
> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/8b4a4176063831476bc9244d20f43b552e4b5554]
> +Assisted-by: opencode:claude-sonnet-5
> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
Hello,
Is that commit included in master and blacksail? If not, can you send
the needed upgrades/backports so I can merge this here?
Thanks!
--
Yoann Congal
Smile ECS
^ permalink raw reply [flat|nested] 11+ messages in thread