Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Markus Volk <f_l_k@t-online.de>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org, ross.burton@arm.com
Subject: Re: [oe-core][PATCH] wic-imager-direct.py: use fstab update also for root device
Date: Thu, 29 Sep 2022 17:56:04 +0200	[thread overview]
Message-ID: <GXAZIR.UGYTFTPVEII43@t-online.de> (raw)
In-Reply-To: <f0eca98f9324c537e2aee3c655258f98372d7926.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Am Do, 29. Sep 2022 um 16:32:40 +0100 schrieb Richard Purdie 
<richard.purdie@linuxfoundation.org>:
> Do we need to worry here about whether we're actually adding a new 
> root
> entry? Is there a case it does need to be preserved?

wic does run the fstab_update by default and adds entries for all vaild 
partitions. Single partitions can be prohibited using 
'--no-fstab-update' in the .wks file. You can choose to use /dev/foo 
format, uuid (--use-uuid) or label (--use-label). The fstab_update can 
also be disabled globally by setting:

WIC_CREATE_EXTRA_ARGS ?= "--no-fstab-update"

In that case the stock fstab file wont be touched by wic at all.

This has been active for some months now but got reverted here
<https://git.yoctoproject.org/poky/commit/?id=e7619f7650e1f545dccba327bbc8d03a7b34fc4e>

because systemd-fstab-generator got confused by trying to create two 
different '-.mount' files.



[-- Attachment #2: Type: text/html, Size: 1287 bytes --]

  reply	other threads:[~2022-09-29 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 12:57 [oe-core][PATCH] wic-imager-direct.py: use fstab update also for root device Markus Volk
2022-09-29 13:08 ` Alexander Kanavin
2022-09-29 15:10   ` Markus Volk
2022-09-29 15:32 ` Richard Purdie
2022-09-29 15:56   ` Markus Volk [this message]
     [not found]   ` <17195FE5AE38CC13.31922@lists.openembedded.org>
2022-09-29 16:27     ` Markus Volk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GXAZIR.UGYTFTPVEII43@t-online.de \
    --to=f_l_k@t-online.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=ross.burton@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox