Re: [oe-core][PATCH] wic-imager-direct.py: use fstab update also for root device

[Markus Volk <f_l_k@t-online.de>]

[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]

Sure. I've sent a v2

Am Do, 29. Sep 2022 um 15:08:48 +0200 schrieb Alexander Kanavin 
<alex.kanavin@gmail.com>:
> Can you describe in more detail what the problem is (e.g. an example
> of incorrect output), and what changes with this patch?
> 
> Alex
> 
> On Thu, 29 Sept 2022 at 14:58, Markus Volk <f_l_k@t-online.de 
> <mailto:f_l_k@t-online.de>> wrote:
>> 
>>  Remove the hardcoded root device entry from fstab when updating to
>>  avoid duplicate entries.
>> 
>>  Signed-off-by: Markus Volk <f_l_k@t-online.de 
>> <mailto:f_l_k@t-online.de>>
>>  ---
>>   scripts/lib/wic/plugins/imager/direct.py | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>>  diff --git a/scripts/lib/wic/plugins/imager/direct.py 
>> b/scripts/lib/wic/plugins/imager/direct.py
>>  index da483daed5..fd86a094d9 100644
>>  --- a/scripts/lib/wic/plugins/imager/direct.py
>>  +++ b/scripts/lib/wic/plugins/imager/direct.py
>>  @@ -117,7 +117,7 @@ class DirectPlugin(ImagerPlugin):
>>           updated = False
>>           for part in self.parts:
>>               if not part.realnum or not part.mountpoint \
>>  -               or part.mountpoint == "/" or not 
>> part.mountpoint.startswith('/'):
>>  +               or not part.mountpoint.startswith('/'):
>>                   continue
>> 
>>               if part.use_uuid:
>>  @@ -145,6 +145,11 @@ class DirectPlugin(ImagerPlugin):
>>               fstab_lines.append(line)
>>               updated = True
>> 
>>  +        for line in fstab_lines:
>>  +            if '/dev/root' in line:
>>  +                fstab_lines.remove(line)
>>  +                updated = True
>>  +
>>           if updated:
>>               self.updated_fstab_path = os.path.join(self.workdir, 
>> "fstab")
>>               with open(self.updated_fstab_path, "w") as f:
>>  --
>>  2.34.1
>> 
>> 
>> 
>> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171187): 
> <https://lists.openembedded.org/g/openembedded-core/message/171187>
> Mute This Topic: <https://lists.openembedded.org/mt/93993381/3618223>
> Group Owner: openembedded-core+owner@lists.openembedded.org 
> <mailto:openembedded-core+owner@lists.openembedded.org>
> Unsubscribe: 
> <https://lists.openembedded.org/g/openembedded-core/unsub> 
> [f_l_k@t-online.de <mailto:f_l_k@t-online.de>]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


[-- Attachment #2: Type: text/html, Size: 2742 bytes --]