From: Markus Volk <f_l_k@t-online.de>
To: Ross Burton <Ross.Burton@arm.com>
Cc: tobiasschmidl@siemens.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [meta-oe][PATCH] wic/direct.py: ignore root mountpoint in fstab updater
Date: Tue, 02 Aug 2022 16:05:14 +0200 [thread overview]
Message-ID: <Q4RZFR.Q72GTSVZXCK3@t-online.de> (raw)
In-Reply-To: <536911C2-925C-47AF-A369-9453B5900916@arm.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
Maybe we could do like this in base-files.bb ?
FSTAB_HAVE_WIC = "${@bb.utils.contains('IMAGE_FSTYPES', 'wic', 'true',
'false', d)}"
FSTAB_WIC_UPDATER = "${@bb.utils.contains('WIC_CREATE_EXTRA_ARGS',
'--no-fstab-update', 'false', 'true', d)}"
do_install:append() {
if [ ${FSTAB_HAVE_WIC} = true ] && [ ${FSTAB_WIC_UPDATER} = true ];
then
sed -i '/\/dev\/root/d' ${D}${sysconfdir}/fstab
fi
}
This would remove the hardcoded '/dev/root' entry if all conditions
are met to add the root entry with wic fstab-update
> \rIt’s looking like the easiest fix here is to revert your patch, so
> at least we don’t have warnings and unexpected behaviour on boot.
> Unless you’re willing to rework your patch so that it allows edits
> to the root mount point but doesn’t end up creating duplicates?
[-- Attachment #2: Type: text/html, Size: 1299 bytes --]
prev parent reply other threads:[~2022-08-02 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 13:45 [meta-oe][PATCH] wic/direct.py: ignore root mountpoint in fstab updater Markus Volk
2022-07-27 15:44 ` [OE-core] " Ross Burton
2022-07-27 16:31 ` Markus Volk
[not found] ` <1705BCB17DD12169.1380@lists.openembedded.org>
2022-07-27 17:04 ` Markus Volk
2022-07-28 16:15 ` Ross Burton
2022-08-02 14:05 ` Markus Volk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Q4RZFR.Q72GTSVZXCK3@t-online.de \
--to=f_l_k@t-online.de \
--cc=Ross.Burton@arm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tobiasschmidl@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox