Re: [OE-core] [meta-oe][PATCH] wic/direct.py: ignore root mountpoint in fstab updater

[Markus Volk <f_l_k@t-online.de>]

[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]

Yes. With the patch the warning disappears from dmesg

Am Mi, 27. Jul 2022 um 15:44:48 +0000 schrieb Ross Burton 
<ross.burton@arm.com>:
> This looks like a fix for 
> <https://bugzilla.yoctoproject.org/show_bug.cgi?id=14865>, can you 
> confirm that?
> 
> Ross
> 
>>  On 27 Jul 2022, at 14:45, Markus Volk via lists.openembedded.org 
>> <f_l_k=t-online.de@lists.openembedded.org 
>> <mailto:f_l_k=t-online.de@lists.openembedded.org>> wrote:
>> 
>>  We already have a root entry in fstab. This commit prevents 
>> processing root
>>  mountpoint in fstab_updater and thus avoids duplicate entries for 
>> root in fstab.
>> 
>>  Signed-off-by: Markus Volk <f_l_k@t-online.de 
>> <mailto:f_l_k@t-online.de>>
>>  ---
>>  scripts/lib/wic/plugins/imager/direct.py | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>>  diff --git a/scripts/lib/wic/plugins/imager/direct.py 
>> b/scripts/lib/wic/plugins/imager/direct.py
>>  index c44159b235..75004ab320 100644
>>  --- a/scripts/lib/wic/plugins/imager/direct.py
>>  +++ b/scripts/lib/wic/plugins/imager/direct.py
>>  @@ -117,7 +117,8 @@ class DirectPlugin(ImagerPlugin):
>>          updated = False
>>          for part in self.parts:
>>              if not part.realnum or not part.mountpoint \
>>  -               or not part.mountpoint.startswith('/'):
>>  +               or not part.mountpoint.startswith('/') \
>>  +               or part.mountpoint == "/":
>>                  continue
>> 
>>              if part.use_uuid:
>>  --
>>  2.34.1
>> 
>> 
>> 
>> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168572): 
> <https://lists.openembedded.org/g/openembedded-core/message/168572>
> Mute This Topic: <https://lists.openembedded.org/mt/92649199/3618223>
> Group Owner: openembedded-core+owner@lists.openembedded.org 
> <mailto:openembedded-core+owner@lists.openembedded.org>
> Unsubscribe: 
> <https://lists.openembedded.org/g/openembedded-core/unsub> 
> [f_l_k@t-online.de <mailto:f_l_k@t-online.de>]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


[-- Attachment #2: Type: text/html, Size: 2532 bytes --]