* Re: [OE-core] [PATCH] strace_5.13 -> strace 5.14
2021-09-29 20:57 [PATCH] strace_5.13 -> strace 5.14 Khem Raj
@ 2021-09-29 21:13 ` Bruce Ashfield
2021-09-29 22:29 ` Bruce Ashfield
2021-09-30 6:46 ` Alexandre Belloni
2 siblings, 0 replies; 5+ messages in thread
From: Bruce Ashfield @ 2021-09-29 21:13 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer, Persian Prince
On Wed, Sep 29, 2021 at 4:57 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> From: Persian Prince <persianpros@yahoo.com>
>
> Strace 5.13 won't compile with 5.14 headers:
>
> | ../../strace-5.13/src/fs_x_ioctl.c: In function 'fs_x_ioctl':
> | ../../strace-5.13/src/fs_x_ioctl.c:64:14: error: invalid application of 'sizeof' to incomplete type 'struct fsxattr'
> | 64 | case FS_IOC_FSGETXATTR:
> | | ^~~~~~~~~~~~~~~~~
> | ../../strace-5.13/src/fs_x_ioctl.c:71:14: error: invalid application of 'sizeof' to incomplete type 'struct fsxattr'
> | 71 | case FS_IOC_FSSETXATTR:
> | | ^~~~~~~~~~~~~~~~~
> | make[3]: *** [Makefile:5011: libstrace_a-fs_x_ioctl.o] Error 1
> | make[3]: *** Waiting for unfinished jobs....
>
> According to https://strace.io/files/5.14/:
>
> * Improvements
> * Implemented decoding of memfd_secret and quotactl_fd syscalls,
> introduced in Linux 5.14.
> * Enhanced prctl syscall decoding.
> * Enhanced decoding of IFLA_* netlink attributes.
> * Enhanced decoding of MDBA_ROUTER_PATTR_* mdb router port netlink attributes.
> * Updated lists of BPF_*, IORING_*, MADV_*, MOUNT_ATTR_*, SCTP_*,
> and UFFD_* constants.
> * Updated lists of ioctl commands from Linux 5.14.
Interesting that none of our oe-core build coverage picked this up.
I'll send out a patch that adds the packagegroup containing strace to
core-image-kernel-dev, so it won't be missed on future libc-header
updates.
Cheers,
Bruce
>
> Persian Prince <persianpros@yahoo.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> rename meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} (96%)
>
> diff --git a/meta/recipes-devtools/strace/strace_5.13.bb b/meta/recipes-devtools/strace/strace_5.14.bb
> similarity index 96%
> rename from meta/recipes-devtools/strace/strace_5.13.bb
> rename to meta/recipes-devtools/strace/strace_5.14.bb
> index 7d93f2da98..02a4843edf 100644
> --- a/meta/recipes-devtools/strace/strace_5.13.bb
> +++ b/meta/recipes-devtools/strace/strace_5.14.bb
> @@ -15,7 +15,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
> file://uintptr_t.patch \
> file://0001-strace-fix-reproducibilty-issues.patch \
> "
> -SRC_URI[sha256sum] = "5acc34888b9d510ad6ac915d4a8df08f51cf1ae920ea24649f6a4bb984d0b656"
> +SRC_URI[sha256sum] = "901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"
>
> inherit autotools ptest
>
> --
> 2.33.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156475): https://lists.openembedded.org/g/openembedded-core/message/156475
> Mute This Topic: https://lists.openembedded.org/mt/85959484/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] strace_5.13 -> strace 5.14
2021-09-29 20:57 [PATCH] strace_5.13 -> strace 5.14 Khem Raj
2021-09-29 21:13 ` [OE-core] " Bruce Ashfield
@ 2021-09-29 22:29 ` Bruce Ashfield
2021-09-30 6:46 ` Alexandre Belloni
2 siblings, 0 replies; 5+ messages in thread
From: Bruce Ashfield @ 2021-09-29 22:29 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer, Persian Prince
On Wed, Sep 29, 2021 at 4:57 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> From: Persian Prince <persianpros@yahoo.com>
>
> Strace 5.13 won't compile with 5.14 headers:
>
> | ../../strace-5.13/src/fs_x_ioctl.c: In function 'fs_x_ioctl':
> | ../../strace-5.13/src/fs_x_ioctl.c:64:14: error: invalid application of 'sizeof' to incomplete type 'struct fsxattr'
> | 64 | case FS_IOC_FSGETXATTR:
> | | ^~~~~~~~~~~~~~~~~
> | ../../strace-5.13/src/fs_x_ioctl.c:71:14: error: invalid application of 'sizeof' to incomplete type 'struct fsxattr'
> | 71 | case FS_IOC_FSSETXATTR:
> | | ^~~~~~~~~~~~~~~~~
> | make[3]: *** [Makefile:5011: libstrace_a-fs_x_ioctl.o] Error 1
> | make[3]: *** Waiting for unfinished jobs....
>
> According to https://strace.io/files/5.14/:
>
> * Improvements
> * Implemented decoding of memfd_secret and quotactl_fd syscalls,
> introduced in Linux 5.14.
> * Enhanced prctl syscall decoding.
> * Enhanced decoding of IFLA_* netlink attributes.
> * Enhanced decoding of MDBA_ROUTER_PATTR_* mdb router port netlink attributes.
> * Updated lists of BPF_*, IORING_*, MADV_*, MOUNT_ATTR_*, SCTP_*,
> and UFFD_* constants.
> * Updated lists of ioctl commands from Linux 5.14.
>
I am curious for a bit more information about the configuration that
was used for the broken build, since I was able to build the existing
strace with 5.14 libc-headers and the 5.14 kernel on two different
machines.
The bump is fine, but I'd just like to understand what configuration
triggered it, so we can catch it next time.
Bruce
> Persian Prince <persianpros@yahoo.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> rename meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} (96%)
>
> diff --git a/meta/recipes-devtools/strace/strace_5.13.bb b/meta/recipes-devtools/strace/strace_5.14.bb
> similarity index 96%
> rename from meta/recipes-devtools/strace/strace_5.13.bb
> rename to meta/recipes-devtools/strace/strace_5.14.bb
> index 7d93f2da98..02a4843edf 100644
> --- a/meta/recipes-devtools/strace/strace_5.13.bb
> +++ b/meta/recipes-devtools/strace/strace_5.14.bb
> @@ -15,7 +15,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
> file://uintptr_t.patch \
> file://0001-strace-fix-reproducibilty-issues.patch \
> "
> -SRC_URI[sha256sum] = "5acc34888b9d510ad6ac915d4a8df08f51cf1ae920ea24649f6a4bb984d0b656"
> +SRC_URI[sha256sum] = "901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"
>
> inherit autotools ptest
>
> --
> 2.33.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156475): https://lists.openembedded.org/g/openembedded-core/message/156475
> Mute This Topic: https://lists.openembedded.org/mt/85959484/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] strace_5.13 -> strace 5.14
2021-09-29 20:57 [PATCH] strace_5.13 -> strace 5.14 Khem Raj
2021-09-29 21:13 ` [OE-core] " Bruce Ashfield
2021-09-29 22:29 ` Bruce Ashfield
@ 2021-09-30 6:46 ` Alexandre Belloni
2021-09-30 15:23 ` Khem Raj
2 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2021-09-30 6:46 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core, Persian Prince
Hello,
On 29/09/2021 13:57:10-0700, Khem Raj wrote:
> From: Persian Prince <persianpros@yahoo.com>
>
> Strace 5.13 won't compile with 5.14 headers:
>
> | ../../strace-5.13/src/fs_x_ioctl.c: In function 'fs_x_ioctl':
> | ../../strace-5.13/src/fs_x_ioctl.c:64:14: error: invalid application of 'sizeof' to incomplete type 'struct fsxattr'
> | 64 | case FS_IOC_FSGETXATTR:
> | | ^~~~~~~~~~~~~~~~~
> | ../../strace-5.13/src/fs_x_ioctl.c:71:14: error: invalid application of 'sizeof' to incomplete type 'struct fsxattr'
> | 71 | case FS_IOC_FSSETXATTR:
> | | ^~~~~~~~~~~~~~~~~
> | make[3]: *** [Makefile:5011: libstrace_a-fs_x_ioctl.o] Error 1
> | make[3]: *** Waiting for unfinished jobs....
>
> According to https://strace.io/files/5.14/:
>
> * Improvements
> * Implemented decoding of memfd_secret and quotactl_fd syscalls,
> introduced in Linux 5.14.
> * Enhanced prctl syscall decoding.
> * Enhanced decoding of IFLA_* netlink attributes.
> * Enhanced decoding of MDBA_ROUTER_PATTR_* mdb router port netlink attributes.
> * Updated lists of BPF_*, IORING_*, MADV_*, MOUNT_ATTR_*, SCTP_*,
> and UFFD_* constants.
> * Updated lists of ioctl commands from Linux 5.14.
>
> Persian Prince <persianpros@yahoo.com>
I guess this should have been an SoB.
However, this is not applicable as we already carry a similar patch in
kirkstone-next.
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> rename meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} (96%)
>
> diff --git a/meta/recipes-devtools/strace/strace_5.13.bb b/meta/recipes-devtools/strace/strace_5.14.bb
> similarity index 96%
> rename from meta/recipes-devtools/strace/strace_5.13.bb
> rename to meta/recipes-devtools/strace/strace_5.14.bb
> index 7d93f2da98..02a4843edf 100644
> --- a/meta/recipes-devtools/strace/strace_5.13.bb
> +++ b/meta/recipes-devtools/strace/strace_5.14.bb
> @@ -15,7 +15,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
> file://uintptr_t.patch \
> file://0001-strace-fix-reproducibilty-issues.patch \
> "
> -SRC_URI[sha256sum] = "5acc34888b9d510ad6ac915d4a8df08f51cf1ae920ea24649f6a4bb984d0b656"
> +SRC_URI[sha256sum] = "901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"
>
> inherit autotools ptest
>
> --
> 2.33.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156475): https://lists.openembedded.org/g/openembedded-core/message/156475
> Mute This Topic: https://lists.openembedded.org/mt/85959484/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] strace_5.13 -> strace 5.14
2021-09-30 6:46 ` Alexandre Belloni
@ 2021-09-30 15:23 ` Khem Raj
0 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2021-09-30 15:23 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Persian Prince, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 3520 bytes --]
On Wed, Sep 29, 2021 at 11:46 PM Alexandre Belloni <
alexandre.belloni@bootlin.com> wrote:
> Hello,
>
> On 29/09/2021 13:57:10-0700, Khem Raj wrote:
> > From: Persian Prince <persianpros@yahoo.com>
> >
> > Strace 5.13 won't compile with 5.14 headers:
> >
> > | ../../strace-5.13/src/fs_x_ioctl.c: In function 'fs_x_ioctl':
> > | ../../strace-5.13/src/fs_x_ioctl.c:64:14: error: invalid application
> of 'sizeof' to incomplete type 'struct fsxattr'
> > | 64 | case FS_IOC_FSGETXATTR:
> > | | ^~~~~~~~~~~~~~~~~
> > | ../../strace-5.13/src/fs_x_ioctl.c:71:14: error: invalid application
> of 'sizeof' to incomplete type 'struct fsxattr'
> > | 71 | case FS_IOC_FSSETXATTR:
> > | | ^~~~~~~~~~~~~~~~~
> > | make[3]: *** [Makefile:5011: libstrace_a-fs_x_ioctl.o] Error 1
> > | make[3]: *** Waiting for unfinished jobs....
> >
> > According to https://strace.io/files/5.14/:
> >
> > * Improvements
> > * Implemented decoding of memfd_secret and quotactl_fd syscalls,
> > introduced in Linux 5.14.
> > * Enhanced prctl syscall decoding.
> > * Enhanced decoding of IFLA_* netlink attributes.
> > * Enhanced decoding of MDBA_ROUTER_PATTR_* mdb router port netlink
> attributes.
> > * Updated lists of BPF_*, IORING_*, MADV_*, MOUNT_ATTR_*, SCTP_*,
> > and UFFD_* constants.
> > * Updated lists of ioctl commands from Linux 5.14.
> >
> > Persian Prince <persianpros@yahoo.com>
>
> I guess this should have been an SoB.
>
> However, this is not applicable as we already carry a similar patch in
> kirkstone-next.
If you do that’s fine see if commit msg makes sense and perhaps transplant
that part to what you are staging
>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > rename meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb}
> (96%)
> >
> > diff --git a/meta/recipes-devtools/strace/strace_5.13.bb
> b/meta/recipes-devtools/strace/strace_5.14.bb
> > similarity index 96%
> > rename from meta/recipes-devtools/strace/strace_5.13.bb
> > rename to meta/recipes-devtools/strace/strace_5.14.bb
> > index 7d93f2da98..02a4843edf 100644
> > --- a/meta/recipes-devtools/strace/strace_5.13.bb
> > +++ b/meta/recipes-devtools/strace/strace_5.14.bb
> > @@ -15,7 +15,7 @@ SRC_URI = "
> https://strace.io/files/${PV}/strace-${PV}.tar.xz \
> > file://uintptr_t.patch \
> > file://0001-strace-fix-reproducibilty-issues.patch \
> > "
> > -SRC_URI[sha256sum] =
> "5acc34888b9d510ad6ac915d4a8df08f51cf1ae920ea24649f6a4bb984d0b656"
> > +SRC_URI[sha256sum] =
> "901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"
> >
> > inherit autotools ptest
> >
> > --
> > 2.33.0
> >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#156475):
> https://lists.openembedded.org/g/openembedded-core/message/156475
> > Mute This Topic: https://lists.openembedded.org/mt/85959484/3617179
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
[-- Attachment #2: Type: text/html, Size: 6068 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread