Re: [OE-core] [PATCH] linux-firmware: add new fw file to ${PN}-qcom-adreno-a660

Re: [OE-core] [PATCH] linux-firmware: add new fw file to ${PN}-qcom-adreno-a660

[Vivek Puar]

Hi Richard,

Can you please review this?

On 10/22/2024 10:51 PM, Vivek Puar wrote:
> Extend the linux-firmware-qcom-adreno-a660 package
> with gpu firmware file for qcom QCM6490 variant
>
> Signed-off-by: Vivek Puar <quic_vpuar@quicinc.com>
> ---
>   meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
> index f40723cbca..d18e7414db 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
> @@ -1482,7 +1482,7 @@ FILES:${PN}-qcom-adreno-a4xx = "${nonarch_base_libdir}/firmware/qcom/a4*_*.fw*"
>   FILES:${PN}-qcom-adreno-a530 = "${nonarch_base_libdir}/firmware/qcom/a530*.fw*"
>   FILES:${PN}-qcom-adreno-a630 = "${nonarch_base_libdir}/firmware/qcom/a630*.*"
>   FILES:${PN}-qcom-adreno-a650 = "${nonarch_base_libdir}/firmware/qcom/a650*.*"
> -FILES:${PN}-qcom-adreno-a660 = "${nonarch_base_libdir}/firmware/qcom/a660*.*"
> +FILES:${PN}-qcom-adreno-a660 = "${nonarch_base_libdir}/firmware/qcom/a660*.* ${nonarch_base_libdir}/firmware/qcom/qcm6490/a660_zap.mbn*"
>   FILES:${PN}-qcom-adreno-a702 = "${nonarch_base_libdir}/firmware/qcom/a702*.*"
>   FILES:${PN}-qcom-adreno-g750 = "${nonarch_base_libdir}/firmware/qcom/gen70500_*.*"
>   FILES:${PN}-qcom-apq8016-modem = "${nonarch_base_libdir}/firmware/qcom/apq8016/mba.mbn* ${nonarch_base_libdir}/firmware/qcom/apq8016/modem.mbn*"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#206169): https://lists.openembedded.org/g/openembedded-core/message/206169
> Mute This Topic: https://lists.openembedded.org/mt/109156102/8903276
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [quic_vpuar@quicinc.com]
> -=-=-=-=-=-=-=-=-=-=-=-

Regards,

Vivek

Re: [OE-core] [PATCH] linux-firmware: add new fw file to ${PN}-qcom-adreno-a660

[Mathieu Dubois-Briand]

On Fri, Oct 25, 2024 at 11:49:12AM +0530, Vivek Puar wrote:
> Hi Richard,
> 
> Can you please review this?
> 

Hi Vivek,

As a quick update, your two patches are currently in my master-next
branch and have been built by the autobuilder without raising any issue
yet. If no other issue arise, they might land in master in the coming
days.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] linux-firmware: add new fw file to ${PN}-qcom-adreno-a660

[Dmitry Baryshkov]

On Tue, 22 Oct 2024 at 20:21, Vivek Puar via lists.openembedded.org
<quic_vpuar=quicinc.com@lists.openembedded.org> wrote:
>
> Extend the linux-firmware-qcom-adreno-a660 package
> with gpu firmware file for qcom QCM6490 variant

Could you please explain one thing: why can't you look around and copy
the existing approach? MBN files are platform-dependent, so they
should not go to the platform-independent qcom-adreno-aNNN packages.
That's how all the rest of the platforms are handled, but for some
reason you don't copy that design.

Nico, Ricardo, could you please make sure that future linux-firmware
recipe changes from the Qualcomm side get dmitry.baryshkov@linaro.org
in CC list? I usually don't follow the mailing list closely, so I
missed this.  I'll send a series to fix the issues with QCM6490 /
QCS6490  but I'd really like to be able to prevent such invalid or
half-baked solutions from hitting the repository in the future.

>
> Signed-off-by: Vivek Puar <quic_vpuar@quicinc.com>
> ---
>  meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
> index f40723cbca..d18e7414db 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
> @@ -1482,7 +1482,7 @@ FILES:${PN}-qcom-adreno-a4xx = "${nonarch_base_libdir}/firmware/qcom/a4*_*.fw*"
>  FILES:${PN}-qcom-adreno-a530 = "${nonarch_base_libdir}/firmware/qcom/a530*.fw*"
>  FILES:${PN}-qcom-adreno-a630 = "${nonarch_base_libdir}/firmware/qcom/a630*.*"
>  FILES:${PN}-qcom-adreno-a650 = "${nonarch_base_libdir}/firmware/qcom/a650*.*"
> -FILES:${PN}-qcom-adreno-a660 = "${nonarch_base_libdir}/firmware/qcom/a660*.*"
> +FILES:${PN}-qcom-adreno-a660 = "${nonarch_base_libdir}/firmware/qcom/a660*.* ${nonarch_base_libdir}/firmware/qcom/qcm6490/a660_zap.mbn*"
>  FILES:${PN}-qcom-adreno-a702 = "${nonarch_base_libdir}/firmware/qcom/a702*.*"
>  FILES:${PN}-qcom-adreno-g750 = "${nonarch_base_libdir}/firmware/qcom/gen70500_*.*"
>  FILES:${PN}-qcom-apq8016-modem = "${nonarch_base_libdir}/firmware/qcom/apq8016/mba.mbn* ${nonarch_base_libdir}/firmware/qcom/apq8016/modem.mbn*"
> --
> 2.34.1

-- 
With best wishes
Dmitry

Re: [OE-core] [PATCH] linux-firmware: add new fw file to ${PN}-qcom-adreno-a660

[Vivek Puar]

[-- Attachment #1: Type: text/plain, Size: 2548 bytes --]

Hi Dmitry,

This will be taken care of in the future and such mistakes won't be 
repeated.

On 11/2/2024 2:46 AM, Dmitry Baryshkov wrote:
> On Tue, 22 Oct 2024 at 20:21, Vivek Puar via lists.openembedded.org
> <quic_vpuar=quicinc.com@lists.openembedded.org> wrote:
>> Extend the linux-firmware-qcom-adreno-a660 package
>> with gpu firmware file for qcom QCM6490 variant
> Could you please explain one thing: why can't you look around and copy
> the existing approach? MBN files are platform-dependent, so they
> should not go to the platform-independent qcom-adreno-aNNN packages.
> That's how all the rest of the platforms are handled, but for some
> reason you don't copy that design.
>
> Nico, Ricardo, could you please make sure that future linux-firmware
> recipe changes from the Qualcomm side getdmitry.baryshkov@linaro.org
> in CC list? I usually don't follow the mailing list closely, so I
> missed this.  I'll send a series to fix the issues with QCM6490 /
> QCS6490  but I'd really like to be able to prevent such invalid or
> half-baked solutions from hitting the repository in the future.
>
>> Signed-off-by: Vivek Puar<quic_vpuar@quicinc.com>
>> ---
>>   meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
>> index f40723cbca..d18e7414db 100644
>> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
>> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb
>> @@ -1482,7 +1482,7 @@ FILES:${PN}-qcom-adreno-a4xx = "${nonarch_base_libdir}/firmware/qcom/a4*_*.fw*"
>>   FILES:${PN}-qcom-adreno-a530 = "${nonarch_base_libdir}/firmware/qcom/a530*.fw*"
>>   FILES:${PN}-qcom-adreno-a630 = "${nonarch_base_libdir}/firmware/qcom/a630*.*"
>>   FILES:${PN}-qcom-adreno-a650 = "${nonarch_base_libdir}/firmware/qcom/a650*.*"
>> -FILES:${PN}-qcom-adreno-a660 = "${nonarch_base_libdir}/firmware/qcom/a660*.*"
>> +FILES:${PN}-qcom-adreno-a660 = "${nonarch_base_libdir}/firmware/qcom/a660*.* ${nonarch_base_libdir}/firmware/qcom/qcm6490/a660_zap.mbn*"
>>   FILES:${PN}-qcom-adreno-a702 = "${nonarch_base_libdir}/firmware/qcom/a702*.*"
>>   FILES:${PN}-qcom-adreno-g750 = "${nonarch_base_libdir}/firmware/qcom/gen70500_*.*"
>>   FILES:${PN}-qcom-apq8016-modem = "${nonarch_base_libdir}/firmware/qcom/apq8016/mba.mbn* ${nonarch_base_libdir}/firmware/qcom/apq8016/modem.mbn*"
>> --
>> 2.34.1

Regards,

Vivek

[-- Attachment #2: Type: text/html, Size: 3532 bytes --]