python test files installed in image on purpose?

python test files installed in image on purpose?

[Andrew Geissler]

Hi,

We've been running into some flash space issues over in the openbmc
project. I noticed the python.bb file (python_2.7.14.bb for us) is
installing some test folders/files in our rootfs image.

# find /usr/lib/python2.7/ -name "test" -print
/usr/lib/python2.7/ctypes/test
/usr/lib/python2.7/email/test

I'm looking to see if there's any functional reason these tests are
included in the image.

In our compressed filesystem we're talking about ~150KB of space but
right now that's a pretty big deal for us. Would the community be
interested in a patch to not install (or make it an option like is
done with INCLUDE_PYCS) these test files?  Or is this something we
should just handle in a .bbappend file for our distro?

Here's a complete list of test directories in the python package.
./Python-2.7.14/Lib/bsddb/test
./Python-2.7.14/Lib/sqlite3/test
./Python-2.7.14/Lib/ctypes/test
./Python-2.7.14/Lib/unittest/test
./Python-2.7.14/Lib/lib-tk/test
./Python-2.7.14/Lib/email/test

Thanks,
Andrew

Re: python test files installed in image on purpose?

[Alejandro Enedino Hernandez Samaniego]

Hey Andrew,


I seem to remember some of them were required, both unittest and and 
sqlite3-tests can be removed from the python-modules package,

as for the others, you would need to remove them at do_install() , and I 
would not mind making it optional.


Cheers,

Alejandro


On 09/07/2018 12:02 PM, Andrew Geissler wrote:
> Hi,
>
> We've been running into some flash space issues over in the openbmc
> project. I noticed the python.bb file (python_2.7.14.bb for us) is
> installing some test folders/files in our rootfs image.
>
> # find /usr/lib/python2.7/ -name "test" -print
> /usr/lib/python2.7/ctypes/test
> /usr/lib/python2.7/email/test
>
> I'm looking to see if there's any functional reason these tests are
> included in the image.
>
> In our compressed filesystem we're talking about ~150KB of space but
> right now that's a pretty big deal for us. Would the community be
> interested in a patch to not install (or make it an option like is
> done with INCLUDE_PYCS) these test files?  Or is this something we
> should just handle in a .bbappend file for our distro?
>
> Here's a complete list of test directories in the python package.
> ./Python-2.7.14/Lib/bsddb/test
> ./Python-2.7.14/Lib/sqlite3/test
> ./Python-2.7.14/Lib/ctypes/test
> ./Python-2.7.14/Lib/unittest/test
> ./Python-2.7.14/Lib/lib-tk/test
> ./Python-2.7.14/Lib/email/test
>
> Thanks,
> Andrew

Re: python test files installed in image on purpose?

[Richard Purdie]

On Fri, 2018-09-07 at 14:02 -0500, Andrew Geissler wrote:
> Hi,
> 
> We've been running into some flash space issues over in the openbmc
> project. I noticed the python.bb file (python_2.7.14.bb for us) is
> installing some test folders/files in our rootfs image.
> 
> # find /usr/lib/python2.7/ -name "test" -print
> /usr/lib/python2.7/ctypes/test
> /usr/lib/python2.7/email/test
> 
> I'm looking to see if there's any functional reason these tests are
> included in the image.
> 
> In our compressed filesystem we're talking about ~150KB of space but
> right now that's a pretty big deal for us. Would the community be
> interested in a patch to not install (or make it an option like is
> done with INCLUDE_PYCS) these test files?  Or is this something we
> should just handle in a .bbappend file for our distro?
> 
> Here's a complete list of test directories in the python package.
> ./Python-2.7.14/Lib/bsddb/test
> ./Python-2.7.14/Lib/sqlite3/test
> ./Python-2.7.14/Lib/ctypes/test
> ./Python-2.7.14/Lib/unittest/test
> ./Python-2.7.14/Lib/lib-tk/test
> ./Python-2.7.14/Lib/email/test

These definitely sound like they should be put into a different package
which is related to testing and not installed otherwise. 

So yes, in principle these are exactly the kinds of fixes which should
be going into core!

Cheers,

Richard