[PATCH] icu: Skip buildpaths QA check, if TMPDIR is /build/tmp

[PATCH] icu: Skip buildpaths QA check, if TMPDIR is /build/tmp

[Jörg Sommer]

From: Jörg Sommer <joerg.sommer@navimatix.de>

The file udatatst.c really contains the string /build/tmp. When building
with kas-container the build directory is /build and hence the TMPDIR
becomes /build/tmp.

% grep -n -C2 /build/tmp source/test/cintltst/udatatst.c
136-    char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
137-                                           + strlen(U_ICUDATA_NAME)
138:                                           + strlen("/build/tmp/..")+1 ) );
139-
140-    char        *icuDataFilePath = 0;

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 meta/recipes-support/icu/icu_78.2.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-support/icu/icu_78.2.bb b/meta/recipes-support/icu/icu_78.2.bb
index 1e99803105..b2e3e1a588 100644
--- a/meta/recipes-support/icu/icu_78.2.bb
+++ b/meta/recipes-support/icu/icu_78.2.bb
@@ -122,6 +122,9 @@ SRC_URI[data.sha256sum] = "582968cf174c9498b2046b4f4e7f786def5f18222bd8d98432d7a
 UPSTREAM_CHECK_REGEX = "releases/tag/release-(?P<pver>(?!.+rc).+)"
 GITHUB_BASE_URI = "https://github.com/unicode-org/icu/releases"
 
+# The file source/test/cintltst/udatatst.c contains the string "/build/tmp/.."
+INSANE_SKIP:${PN}-src += "${@'buildpaths' if d.getVar('TMPDIR') == '/build/tmp' else ''}"
+
 EXTRA_OECONF:append:libc-musl = " ac_cv_func_strtod_l=no"
 
 PACKAGECONFIG ?= ""
-- 
2.53.0

Re: [OE-core] [PATCH] icu: Skip buildpaths QA check, if TMPDIR is /build/tmp

[Ross Burton]

On 18 Mar 2026, at 08:21, Jörg Sommer via lists.openembedded.org <joerg.sommer=navimatix.de@lists.openembedded.org> wrote:
> +# The file source/test/cintltst/udatatst.c contains the string "/build/tmp/.."
> +INSANE_SKIP:${PN}-src += "${@'buildpaths' if d.getVar('TMPDIR') == '/build/tmp' else '’}”

This INSANE_SKIP is quite ugly…

As this is just test data, would it be possible to patch it to something that isn’t likely to be a build path instead? (and ideally, upstream that patch)

Ross

Re: [OE-core] [PATCH] icu: Skip buildpaths QA check, if TMPDIR is /build/tmp

[joerg.sommer]

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

Ross Burton schrieb am Mi 25. Mär, 12:27 (+0000):
> On 18 Mar 2026, at 08:21, Jörg Sommer via lists.openembedded.org <joerg.sommer=navimatix.de@lists.openembedded.org> wrote:
> > +# The file source/test/cintltst/udatatst.c contains the string "/build/tmp/.."
> > +INSANE_SKIP:${PN}-src += "${@'buildpaths' if d.getVar('TMPDIR') == '/build/tmp' else '’}”
> 
> This INSANE_SKIP is quite ugly…

Yes, I fully agree.

> As this is just test data, would it be possible to patch it to something
> that isn’t likely to be a build path instead? (and ideally, upstream that
> patch)

I don't know. But as far as I can see the “build” part is also hardcoded in
ctest_dataOutDir[1] and I fear in more places. I didn't try but a simple
change of this string might break the tests, or needs changes anywhere
else.

[1]: https://github.com/unicode-org/icu/blob/1659052025f132eabc9b088ffa5dd10f733993c9/icu4c/source/test/cintltst/cintltst.c#L386 

-- 
Navimatix GmbH           T: 03641 - 327 99 0
Tatzendpromenade 2       F: 03641 - 526 306
07745 Jena               www.navimatix.de

Geschäftsführer: Steffen Späthe, Jan Rommeley
Registergericht: Amtsgericht Jena, HRB 501480

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5000 bytes --]

Re: [OE-core] [PATCH] icu: Skip buildpaths QA check, if TMPDIR is /build/tmp

[Jörg Sommer]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

Jörg Sommer via lists.openembedded.org schrieb am Mi 25. Mär, 18:34 (+0100):
> Ross Burton schrieb am Mi 25. Mär, 12:27 (+0000):
> > On 18 Mar 2026, at 08:21, Jörg Sommer via lists.openembedded.org <joerg.sommer=navimatix.de@lists.openembedded.org> wrote:
> > > +# The file source/test/cintltst/udatatst.c contains the string "/build/tmp/.."
> > > +INSANE_SKIP:${PN}-src += "${@'buildpaths' if d.getVar('TMPDIR') == '/build/tmp' else '’}”
> > 
> > This INSANE_SKIP is quite ugly…
> 
> Yes, I fully agree.
> 
> > As this is just test data, would it be possible to patch it to something
> > that isn’t likely to be a build path instead? (and ideally, upstream that
> > patch)
> 
> I don't know. But as far as I can see the “build” part is also hardcoded in
> ctest_dataOutDir[1] and I fear in more places. I didn't try but a simple
> change of this string might break the tests, or needs changes anywhere
> else.

Because the error is

ERROR: icu-78.2-r0 do_package_qa: QA Issue: File /usr/src/debug/icu/78.2/test/cintltst/udatatst.c in package icu-src contains reference to TMPDIR [buildpaths]

we could rewrite the string to `strlen("/build""/tmp/..")`

-- 
Navimatix GmbH           T: 03641 - 327 99 0
Tatzendpromenade 2       F: 03641 - 526 306
07745 Jena               www.navimatix.de

Geschäftsführer: Steffen Späthe, Jan Rommeley
Registergericht: Amtsgericht Jena, HRB 501480

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5000 bytes --]

Re: [OE-core] [PATCH] icu: Skip buildpaths QA check, if TMPDIR is /build/tmp

[Ross Burton]

On 25 Mar 2026, at 20:03, Jörg Sommer <joerg.sommer@navimatix.de> wrote:
> 
> Jörg Sommer via lists.openembedded.org schrieb am Mi 25. Mär, 18:34 (+0100):
>> Ross Burton schrieb am Mi 25. Mär, 12:27 (+0000):
>>> On 18 Mar 2026, at 08:21, Jörg Sommer via lists.openembedded.org <joerg.sommer=navimatix.de@lists.openembedded.org> wrote:
>>>> +# The file source/test/cintltst/udatatst.c contains the string "/build/tmp/.."
>>>> +INSANE_SKIP:${PN}-src += "${@'buildpaths' if d.getVar('TMPDIR') == '/build/tmp' else '’}”
>>> 
>>> This INSANE_SKIP is quite ugly…
>> 
>> Yes, I fully agree.
>> 
>>> As this is just test data, would it be possible to patch it to something
>>> that isn’t likely to be a build path instead? (and ideally, upstream that
>>> patch)
>> 
>> I don't know. But as far as I can see the “build” part is also hardcoded in
>> ctest_dataOutDir[1] and I fear in more places. I didn't try but a simple
>> change of this string might break the tests, or needs changes anywhere
>> else.
> 
> Because the error is
> 
> ERROR: icu-78.2-r0 do_package_qa: QA Issue: File /usr/src/debug/icu/78.2/test/cintltst/udatatst.c in package icu-src contains reference to TMPDIR [buildpaths]
> 
> we could rewrite the string to `strlen("/build""/tmp/..”)

Yes, that would work, without changing the actual string.

Ros

[PATCH v2] icu: Workaround buildpaths QA check, if TMPDIR is /build/tmp

[Jörg Sommer]

From: Jörg Sommer <joerg.sommer@navimatix.de>

The file udatatst.c really contains the string /build/tmp. When building
with kas-container the build directory is /build and hence the TMPDIR
becomes /build/tmp. This triggers the QA check *buildpaths*. To work around
this, slightly modify the string in the source code.

% grep -n -C2 /build/tmp source/test/cintltst/udatatst.c
136-    char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
137-                                           + strlen(U_ICUDATA_NAME)
138:                                           + strlen("/build/tmp/..")+1 ) );
139-
140-    char        *icuDataFilePath = 0;

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 .../icu/icu/mangle-build-tmp.patch            | 32 +++++++++++++++++++
 meta/recipes-support/icu/icu_78.3.bb          |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-support/icu/icu/mangle-build-tmp.patch

diff --git a/meta/recipes-support/icu/icu/mangle-build-tmp.patch b/meta/recipes-support/icu/icu/mangle-build-tmp.patch
new file mode 100644
index 0000000000..cf24e53b88
--- /dev/null
+++ b/meta/recipes-support/icu/icu/mangle-build-tmp.patch
@@ -0,0 +1,32 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=B6rg=20Sommer?= <joerg.sommer@navimatix.de>
+Date: Sat, 28 Mar 2026 20:29:53 +0100
+Subject: [PATCH] test/udatatst: Mangle /build/tmp
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This string matches $TMPDIR (in a kas-container) which triggers the QA
+check buildpaths:
+
+ERROR: icu-78.2-r0 do_package_qa: QA Issue: File /usr/src/debug/icu/78.2/test/cintltst/udatatst.c in package icu-src contains reference to TMPDIR [buildpaths] 
+
+Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
+---
+Upstream-Status: Inappropriate [This QA check collision of Yocto specific]
+
+ test/cintltst/udatatst.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test/cintltst/udatatst.c b/test/cintltst/udatatst.c
+index 003d7d4..7175725 100644
+--- a/test/cintltst/udatatst.c
++++ b/test/cintltst/udatatst.c
+@@ -135,7 +135,7 @@ static void TestUDataOpen(void){
+ 
+     char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
+                                            + strlen(U_ICUDATA_NAME)
+-                                           + strlen("/build/tmp/..")+1 ) );
++                                           + strlen("/""build/tmp/..")+1 ) );
+ 
+     char        *icuDataFilePath = 0;
+     
diff --git a/meta/recipes-support/icu/icu_78.3.bb b/meta/recipes-support/icu/icu_78.3.bb
index 367e2641e7..ad920f3ef4 100644
--- a/meta/recipes-support/icu/icu_78.3.bb
+++ b/meta/recipes-support/icu/icu_78.3.bb
@@ -111,6 +111,7 @@ SRC_URI = "${BASE_SRC_URI};name=code \
            file://0001-test-Add-support-ptest.patch \
            file://run-ptest \
            file://0001-Make-ICU-test-output-compatible-with-Automake-format.patch \
+           file://mangle-build-tmp.patch \
           "
 
 SRC_URI:append:class-target = "\
-- 
2.53.0

Patchtest results for [PATCH v2] icu: Workaround buildpaths QA check, if TMPDIR is /build/tmp

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/v2-icu-Workaround-buildpaths-QA-check-if-TMPDIR-is-build-tmp.patch

FAIL: test Upstream-Status presence: Upstream-Status is present only after the patch scissors. It must be placed in the patch header before the scissors line. (test_patch.TestPatch.test_upstream_status_presence_format)

PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!