Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Peter Suti <peter.suti@streamunlimited.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues
Date: Mon, 31 Jul 2023 12:06:02 +0100	[thread overview]
Message-ID: <aecc7e66bc7cbc16c365c2432d4e850b938bc7e3.camel@linuxfoundation.org> (raw)
In-Reply-To: <CACMGZgbCCj9jsTTxjVCZoU=1LPxmca5Gei_tKDgpKhxb+X2wog@mail.gmail.com>

On Mon, 2023-07-31 at 12:43 +0200, Peter Suti wrote:
> On Mon, Jul 31, 2023 at 12:15 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > On Mon, 2023-07-31 at 11:34 +0200, Peter Suti wrote:
> > > Fixes [YOCTO #15164]
> > > 
> > > Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set instead.
> > > 
> > > This seems to fix the compile issues where the populate_sysroot task was
> > > not run when an externalsrc recipe was built as a dependency.
> > > 
> > > Signed-off-by: Peter Suti <peter.suti@streamunlimited.com>
> > > ---
> > >  meta/classes/externalsrc.bbclass | 7 +++----
> > >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > I think this is going to swap one set of issues for another.
> > 
> > Setting the skip creation option will stop sstate from being generated
> > but it won't stop bitbake reusing existing sstate. In the case of
> > externalsrc, we need to stop it using sstate at all so this patch won't
> > always have the effect we need :(
> > 
> > Cheers,
> > 
> > Richard
> > 
> 
> Thank you for taking the time to think about this patch!
> 
> I see your point, but wouldn't inheriting EXTERNALSRC cause enough
> changes that the hash of the old sstate would no longer match?
> 
> This should in my opinion ensure that sstate is never used because:
> A) old sstate would not be reused because of not matching hash
> B) sstate with matching hash would never be created.
> 
> Please correct me if I missed something and this logic is wrong.

For some cases, yes, this is definitely true. 

Sstate applies to intermediate tasks and you have to keep in mind hash
equivalence though. For example it would be possible for the package
task to generate the same output and hence the sstate hashes of the
package_write_ipk/rpm/deb tasks to be mapped as equivalent so sstate
would then start to match.

For those tasks I mention above in the example it probably doesn't
matter too much in the context of externalsrc but I'm not sure the same
can be said for all tasks which is one of my worries with this.

Cheers,

Richard






  reply	other threads:[~2023-07-31 11:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  9:34 [PATCH] externalsrc: fix dependency chain issues Peter Suti
2023-07-31 10:15 ` [OE-core] " Richard Purdie
2023-07-31 10:43   ` Peter Suti
2023-07-31 11:06     ` Richard Purdie [this message]
2023-07-31 12:08       ` Peter Suti
2023-07-31 12:33         ` Richard Purdie
2023-08-02  9:26           ` Peter Suti
2023-08-04 14:47             ` Richard Purdie
2023-08-07 11:19               ` Peter Suti
2023-08-07 12:55                 ` Richard Purdie
2023-08-07 14:15                   ` Peter Suti
2023-08-08  7:21                     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aecc7e66bc7cbc16c365c2432d4e850b938bc7e3.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.suti@streamunlimited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox