From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Peter Suti <peter.suti@streamunlimited.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues
Date: Mon, 31 Jul 2023 11:15:54 +0100 [thread overview]
Message-ID: <fe958ac3d572d910e9f4eb861b18c4df40381a1e.camel@linuxfoundation.org> (raw)
In-Reply-To: <20230731093415.261532-1-peter.suti@streamunlimited.com>
On Mon, 2023-07-31 at 11:34 +0200, Peter Suti wrote:
> Fixes [YOCTO #15164]
>
> Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set instead.
>
> This seems to fix the compile issues where the populate_sysroot task was
> not run when an externalsrc recipe was built as a dependency.
>
> Signed-off-by: Peter Suti <peter.suti@streamunlimited.com>
> ---
> meta/classes/externalsrc.bbclass | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
I think this is going to swap one set of issues for another.
Setting the skip creation option will stop sstate from being generated
but it won't stop bitbake reusing existing sstate. In the case of
externalsrc, we need to stop it using sstate at all so this patch won't
always have the effect we need :(
Cheers,
Richard
>
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index a649bcdff8..12f2718850 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -76,6 +76,8 @@ python () {
>
> # Dummy value because the default function can't be called with blank SRC_URI
> d.setVar('SRCPV', '999')
> + # sstate is never going to work for external source trees, disable it
> + d.setVar('SSTATE_SKIP_CREATION', '1')
>
> if d.getVar('CONFIGUREOPT_DEPTRACK') == '--disable-dependency-tracking':
> d.setVar('CONFIGUREOPT_DEPTRACK', '')
> @@ -83,10 +85,7 @@ python () {
> tasks = filter(lambda k: d.getVarFlag(k, "task"), d.keys())
>
> for task in tasks:
> - if task.endswith("_setscene"):
> - # sstate is never going to work for external source trees, disable it
> - bb.build.deltask(task, d)
> - elif os.path.realpath(d.getVar('S')) == os.path.realpath(d.getVar('B')):
> + if os.path.realpath(d.getVar('S')) == os.path.realpath(d.getVar('B')):
> # Since configure will likely touch ${S}, ensure only we lock so one task has access at a time
> d.appendVarFlag(task, "lockfiles", " ${S}/singletask.lock")
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#185127): https://lists.openembedded.org/g/openembedded-core/message/185127
> Mute This Topic: https://lists.openembedded.org/mt/100458147/1686473
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [richard.purdie@linuxfoundation.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2023-07-31 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 9:34 [PATCH] externalsrc: fix dependency chain issues Peter Suti
2023-07-31 10:15 ` Richard Purdie [this message]
2023-07-31 10:43 ` [OE-core] " Peter Suti
2023-07-31 11:06 ` Richard Purdie
2023-07-31 12:08 ` Peter Suti
2023-07-31 12:33 ` Richard Purdie
2023-08-02 9:26 ` Peter Suti
2023-08-04 14:47 ` Richard Purdie
2023-08-07 11:19 ` Peter Suti
2023-08-07 12:55 ` Richard Purdie
2023-08-07 14:15 ` Peter Suti
2023-08-08 7:21 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe958ac3d572d910e9f4eb861b18c4df40381a1e.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.suti@streamunlimited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox