From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?
Date: Tue, 13 Jan 2015 05:14:30 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.11.1501130512080.23356@localhost> (raw)
In-Reply-To: <CAJTo0LZSPW=igWoL+-1+dzrMB1_Cr54FOxtaq6H0XWJQmRQKAw@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1273 bytes --]
On Tue, 13 Jan 2015, Burton, Ross wrote:
>
> On 13 January 2015 at 12:57, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> setting S that way in the recipe obviously doesn't do any
> harm, but is it accurate to say that, at least in this case, it's
> unnecessary?
>
>
> Correct. A patch from the student is welcome. :)
actually, there appears to be quite a lot of that scattered
throughout oe-core, so i'm not sure it's worth trying to clean it up
piecemeal as opposed to just doing it in one large patch. as i said, i
realize it doesn't hurt, but i'm a big fan of not having lines where
lines are unnecessary.
i'll defer to the list ... is it worth tracking down all the recipes
that are doing that and just deleting that redundant line from them?
or is that just unnecessary code churn?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2015-01-13 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 12:57 in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant? Robert P. J. Day
2015-01-13 13:01 ` Burton, Ross
2015-01-13 13:14 ` Robert P. J. Day [this message]
2015-01-21 11:35 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1501130512080.23356@localhost \
--to=rpjday@crashcourse.ca \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox