in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?

in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?

[Robert P. J. Day]

  more nitpickery, but was demonstrating OE recipe structure to class
yesterday, arbitrarily picked sysfsutils_2.1.0.bb, going through it
line by line, and a sharp-eyed student noticed this line:

S = "${WORKDIR}/sysfsutils-${PV}"

and wondered what it was doing there, since bitbake.conf sets the
default of:

S = "${WORKDIR}/${BP}"

and since, by default:

BP = "${BPN}-${PV}"

the source directory for sysfsutils would already appear to be
correct. setting S that way in the recipe obviously doesn't do any
harm, but is it accurate to say that, at least in this case, it's
unnecessary?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

On 13 January 2015 at 12:57, Robert P. J. Day <rpjday@crashcourse.ca> wrote:

> setting S that way in the recipe obviously doesn't do any
> harm, but is it accurate to say that, at least in this case, it's
> unnecessary?
>

Correct.  A patch from the student is welcome. :)

Ross

[-- Attachment #2: Type: text/html, Size: 708 bytes --]

Re: in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?

[Robert P. J. Day]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1273 bytes --]

On Tue, 13 Jan 2015, Burton, Ross wrote:

>
> On 13 January 2015 at 12:57, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>       setting S that way in the recipe obviously doesn't do any
>       harm, but is it accurate to say that, at least in this case, it's
>       unnecessary?
>
>
> Correct.  A patch from the student is welcome. :)

  actually, there appears to be quite a lot of that scattered
throughout oe-core, so i'm not sure it's worth trying to clean it up
piecemeal as opposed to just doing it in one large patch. as i said, i
realize it doesn't hurt, but i'm a big fan of not having lines where
lines are unnecessary.

  i'll defer to the list ... is it worth tracking down all the recipes
that are doing that and just deleting that redundant line from them?
or is that just unnecessary code churn?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

On 13 January 2015 at 13:14, Robert P. J. Day <rpjday@crashcourse.ca> wrote:

>   i'll defer to the list ... is it worth tracking down all the recipes
> that are doing that and just deleting that redundant line from them?
> or is that just unnecessary code churn?
>

A single patch to clean up all of oe-core would be clean and as you say,
removing redundancy is good.

Ross

[-- Attachment #2: Type: text/html, Size: 798 bytes --]