From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: can "IMAGE_INSTALL ?= ..." not be written in a more obvious way?
Date: Sat, 10 Dec 2016 06:40:27 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.20.1612100630310.23762@localhost.localdomain> (raw)
i've nattered about this before but not sure i ever got an answer --
here's the last bit of core-image.bbclass:
CORE_IMAGE_BASE_INSTALL = '\
packagegroup-core-boot \
packagegroup-base-extended \
\
${CORE_IMAGE_EXTRA_INSTALL} \
'
CORE_IMAGE_EXTRA_INSTALL ?= ""
IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}"
the first time i saw that (long ago), it took me a few looks to figure
out what was happening. can this not be written in a more obvious way:
CORE_IMAGE_BASE_INSTALL = '\
packagegroup-core-boot \
packagegroup-base-extended \
'
CORE_IMAGE_EXTRA_INSTALL ?= ""
IMAGE_INSTALL ?= " \
${CORE_IMAGE_BASE_INSTALL} \
${CORE_IMAGE_EXTRA_INSTALL} \
"
is that not equivalent, or am i missing something? it's certainly
clearer as to what's happening if people are perusing the code.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next reply other threads:[~2016-12-10 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 11:40 Robert P. J. Day [this message]
2016-12-10 21:15 ` can "IMAGE_INSTALL ?= ..." not be written in a more obvious way? Khem Raj
2016-12-13 8:52 ` Peter Kjellerstedt
2016-12-13 16:29 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1612100630310.23762@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox