[PATCH] wic: Introduce empty plugin to create unformatted empty partitions

[PATCH] wic: Introduce empty plugin to create unformatted empty partitions

[Diego Sueiro]

The empty wic plugin is used to create unformatted empty partitions for wic
images.

To use it you must pass "empty" as argument for the "--source" parameter in
the wks file. For example:
    part foo --source empty --ondisk sda --size="1024" --align 1024

Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 scripts/lib/wic/plugins/source/empty.py | 32 +++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 scripts/lib/wic/plugins/source/empty.py

diff --git a/scripts/lib/wic/plugins/source/empty.py b/scripts/lib/wic/plugins/source/empty.py
new file mode 100644
index 0000000000..041617d648
--- /dev/null
+++ b/scripts/lib/wic/plugins/source/empty.py
@@ -0,0 +1,32 @@
+#
+# SPDX-License-Identifier: MIT
+#
+
+# The empty wic plugin is used to create unformatted empty partitions for wic
+# images.
+# To use it you must pass "empty" as argument for the "--source" parameter in
+# the wks file. For example:
+# part foo --source empty --ondisk sda --size="1024" --align 1024
+
+import logging
+
+from wic.pluginbase import SourcePlugin
+
+logger = logging.getLogger('wic')
+
+class EmptyPartitionPlugin(SourcePlugin):
+    """
+    Populate unformatted empty partition.
+    """
+
+    name = 'empty'
+
+    @classmethod
+    def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
+                             oe_builddir, bootimg_dir, kernel_dir,
+                             rootfs_dir, native_sysroot):
+        """
+        Called to do the actual content population for a partition i.e. it
+        'prepares' the partition to be incorporated into the image.
+        """
+        return
-- 
2.17.1

Re: [OE-core] [PATCH] wic: Introduce empty plugin to create unformatted empty partitions

[Richard Purdie]

On Thu, 2020-12-03 at 15:35 +0000, Diego Sueiro wrote:
> The empty wic plugin is used to create unformatted empty partitions for wic
> images.
> 
> To use it you must pass "empty" as argument for the "--source" parameter in
> the wks file. For example:
>     part foo --source empty --ondisk sda --size="1024" --align 1024
> 
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> ---
>  scripts/lib/wic/plugins/source/empty.py | 32 +++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 scripts/lib/wic/plugins/source/empty.py
> 
> diff --git a/scripts/lib/wic/plugins/source/empty.py b/scripts/lib/wic/plugins/source/empty.py
> new file mode 100644
> index 0000000000..041617d648
> --- /dev/null
> +++ b/scripts/lib/wic/plugins/source/empty.py
> @@ -0,0 +1,32 @@
> +#
> +# SPDX-License-Identifier: MIT
> +#
> +
> +# The empty wic plugin is used to create unformatted empty partitions for wic
> +# images.
> +# To use it you must pass "empty" as argument for the "--source" parameter in
> +# the wks file. For example:
> +# part foo --source empty --ondisk sda --size="1024" --align 1024
> +
> +import logging
> +
> +from wic.pluginbase import SourcePlugin
> +
> +logger = logging.getLogger('wic')
> +
> +class EmptyPartitionPlugin(SourcePlugin):
> +    """
> +    Populate unformatted empty partition.
> +    """
> +
> +    name = 'empty'
> +
> +    @classmethod
> +    def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
> +                             oe_builddir, bootimg_dir, kernel_dir,
> +                             rootfs_dir, native_sysroot):
> +        """
> +        Called to do the actual content population for a partition i.e. it
> +        'prepares' the partition to be incorporated into the image.
> +        """
> +        return


Thanks, the wic test coverage is pretty comprehensive, could you add a
test for this please ("oe-selftest -r wic" is the test command).

Cheers,

Richard

Re: [OE-core] [PATCH] wic: Introduce empty plugin to create unformatted empty partitions

[Diego Sueiro]

>-----Original Message-----
>From: Richard Purdie <richard.purdie@linuxfoundation.org>
>Sent: 03 December 2020 22:58
>To: Diego Sueiro <Diego.Sueiro@arm.com>; openembedded-
>core@lists.openembedded.org
>Cc: nd <nd@arm.com>
>Subject: Re: [OE-core] [PATCH] wic: Introduce empty plugin to create
>unformatted empty partitions
>
>On Thu, 2020-12-03 at 15:35 +0000, Diego Sueiro wrote:
>> The empty wic plugin is used to create unformatted empty partitions
>> for wic images.
>>
>> To use it you must pass "empty" as argument for the "--source"
>> parameter in the wks file. For example:
>>     part foo --source empty --ondisk sda --size="1024" --align 1024
>>
>> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
>> ---
>>  scripts/lib/wic/plugins/source/empty.py | 32
>> +++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>  create mode 100644 scripts/lib/wic/plugins/source/empty.py
>>
>> diff --git a/scripts/lib/wic/plugins/source/empty.py
>> b/scripts/lib/wic/plugins/source/empty.py
>> new file mode 100644
>> index 0000000000..041617d648
>> --- /dev/null
>> +++ b/scripts/lib/wic/plugins/source/empty.py
>> @@ -0,0 +1,32 @@
>> +#
>> +# SPDX-License-Identifier: MIT
>> +#
>> +
>> +# The empty wic plugin is used to create unformatted empty partitions
>> +for wic # images.
>> +# To use it you must pass "empty" as argument for the "--source"
>> +parameter in # the wks file. For example:
>> +# part foo --source empty --ondisk sda --size="1024" --align 1024
>> +
>> +import logging
>> +
>> +from wic.pluginbase import SourcePlugin
>> +
>> +logger = logging.getLogger('wic')
>> +
>> +class EmptyPartitionPlugin(SourcePlugin):
>> +    """
>> +    Populate unformatted empty partition.
>> +    """
>> +
>> +    name = 'empty'
>> +
>> +    @classmethod
>> +    def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
>> +                             oe_builddir, bootimg_dir, kernel_dir,
>> +                             rootfs_dir, native_sysroot):
>> +        """
>> +        Called to do the actual content population for a partition i.e. it
>> +        'prepares' the partition to be incorporated into the image.
>> +        """
>> +        return
>
>
>Thanks, the wic test coverage is pretty comprehensive, could you add a test
>for this please ("oe-selftest -r wic" is the test command).

Sure. I'm sending a V2 shortly.

>
>Cheers,
>
>Richard
>