public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH v2] uki.bbclass: fix building of UKI images with multiple initramfs fstypes
@ 2026-01-20  2:43 Dmitry Baryshkov
  2026-01-23 12:53 ` [OE-core] " Paul Barker
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Baryshkov @ 2026-01-20  2:43 UTC (permalink / raw)
  To: openembedded-core

If INITRAMFS_FSTYPES contains more than one entry, ukify build command
will fail as INITRD_ARCHIVE will contain extra strings. Use only the
first initramfs type, letting the user to specify other fstypes in
INITRAMFS_FSTYPES.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 meta/classes-recipe/uki.bbclass | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/classes-recipe/uki.bbclass b/meta/classes-recipe/uki.bbclass
index a2b1c8a82d6f..ea449540db66 100644
--- a/meta/classes-recipe/uki.bbclass
+++ b/meta/classes-recipe/uki.bbclass
@@ -73,8 +73,6 @@ require ../conf/image-uefi.conf
 
 INITRAMFS_IMAGE ?= "core-image-minimal-initramfs"
 
-INITRD_ARCHIVE ?= "${INITRAMFS_IMAGE}-${MACHINE}.${INITRAMFS_FSTYPES}"
-
 do_image_complete[depends] += "${INITRAMFS_IMAGE}:do_image_complete"
 
 UKIFY_CMD ?= "ukify build"
@@ -127,7 +125,8 @@ python do_uki() {
     ukify_cmd += " --stub %s" % (stub)
 
     # initrd
-    initramfs_image = "%s" % (d.getVar('INITRD_ARCHIVE'))
+    uki_fstype = d.getVar("INITRAMFS_FSTYPES").split()[0]
+    initramfs_image = "%s-%s.%s" % (d.getVar('INITRAMFS_IMAGE'), d.getVar('MACHINE'), uki_fstype)
     ukify_cmd += " --initrd=%s" % (os.path.join(deploy_dir_image, initramfs_image))
 
     # kernel
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OE-core] [PATCH v2] uki.bbclass: fix building of UKI images with multiple initramfs fstypes
  2026-01-20  2:43 [PATCH v2] uki.bbclass: fix building of UKI images with multiple initramfs fstypes Dmitry Baryshkov
@ 2026-01-23 12:53 ` Paul Barker
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Barker @ 2026-01-23 12:53 UTC (permalink / raw)
  To: dmitry.baryshkov, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

On Tue, 2026-01-20 at 04:43 +0200, Dmitry Baryshkov via
lists.openembedded.org wrote:
> If INITRAMFS_FSTYPES contains more than one entry, ukify build command
> will fail as INITRD_ARCHIVE will contain extra strings. Use only the
> first initramfs type, letting the user to specify other fstypes in
> INITRAMFS_FSTYPES.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

Hi Dmitry,

The implementation now looks good. The commit message needs a little
rewording, we need to note that INITRD_ARCHIVE is now gone so that it's
easier to notice this change when we're compiling release notes.

Best regards,

-- 
Paul Barker



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-23 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20  2:43 [PATCH v2] uki.bbclass: fix building of UKI images with multiple initramfs fstypes Dmitry Baryshkov
2026-01-23 12:53 ` [OE-core] " Paul Barker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox