Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Jacob Kroon" <jacob.kroon@gmail.com>
To: "T. Ulrich" <timon.ulrich@kabelmail.de>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v2] kernel.bbclass: add lz4 dependency and fix the call to lz4
Date: Fri, 3 Jul 2020 14:46:59 +0200	[thread overview]
Message-ID: <ba256db6-8174-c98d-e145-0ee358afef63@gmail.com> (raw)
In-Reply-To: <20200703123940.24779-1-timon.ulrich@kabelmail.de>

On 7/3/20 2:39 PM, T. Ulrich wrote:
> From: Timon Ulrich <t.ulrich@anapur.de>
> 
> If the initramfs image is type lz4, then a native lz4 is needed.
> 
> Additionally an output filename needs to be specified when calling lz4,
> otherwise STDOUT will be used implicitly.
> 
> Signed-off-by: Timon Ulrich <t.ulrich@anapur.de>
> ---
>   meta/classes/kernel.bbclass | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 6d07b29e2d..9e3c34ad48 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -5,6 +5,7 @@ KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel")
>   
>   PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
>   DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
> +DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", "", d)}"

Should/Could we do a similar thing for "lzop-native" above ? To me it 
looks like that would be possible, assuming I interpreted my taskexp 
correctly.

Jacob

>   PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
>   
>   do_deploy[depends] += "depmodwrapper-cross:do_populate_sysroot"
> @@ -210,7 +211,7 @@ copy_initramfs() {
>   				;;
>   			*lz4)
>   				echo "lz4 decompressing image"
> -				lz4 -df ${B}/usr/${INITRAMFS_IMAGE_NAME}.$img
> +				lz4 -df ${B}/usr/${INITRAMFS_IMAGE_NAME}.$img ${B}/usr/${INITRAMFS_IMAGE_NAME}.cpio
>   				break
>   				;;
>   			*lzo)
> 
> 

  reply	other threads:[~2020-07-03 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <140262>
2020-07-03 12:39 ` [PATCH v2] kernel.bbclass: add lz4 dependency and fix the call to lz4 T. Ulrich
2020-07-03 12:46   ` Jacob Kroon [this message]
2020-07-03 13:10     ` [OE-core] " Jacob Kroon
2020-07-03 13:31       ` Richard Purdie
2020-07-03 13:50         ` [OE-core] [PATCH v2] kernel.bbclass: add lz4 dependency and fixthe " T. Ulrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba256db6-8174-c98d-e145-0ee358afef63@gmail.com \
    --to=jacob.kroon@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=timon.ulrich@kabelmail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox