Re: [OE-core] [PATCH v2] kernel.bbclass: add lz4 dependency and fix the call to lz4

["Jacob Kroon" <jacob.kroon@gmail.com>]

On 7/3/20 2:46 PM, Jacob Kroon wrote:
> On 7/3/20 2:39 PM, T. Ulrich wrote:
>> From: Timon Ulrich <t.ulrich@anapur.de>
>>
>> If the initramfs image is type lz4, then a native lz4 is needed.
>>
>> Additionally an output filename needs to be specified when calling lz4,
>> otherwise STDOUT will be used implicitly.
>>
>> Signed-off-by: Timon Ulrich <t.ulrich@anapur.de>
>> ---
>>   meta/classes/kernel.bbclass | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 6d07b29e2d..9e3c34ad48 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -5,6 +5,7 @@ KERNEL_DEPLOYSUBDIR ??= "${@ "" if 
>> (d.getVar("KERNEL_PACKAGE_NAME") == "kernel")
>>   PROVIDES += "${@ "virtual/kernel" if 
>> (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
>>   DEPENDS += "virtual/${TARGET_PREFIX}binutils 
>> virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native 
>> bison-native"
>> +DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", 
>> "lz4-native", "", d)}"
> 
> Should/Could we do a similar thing for "lzop-native" above ? To me it 
> looks like that would be possible, assuming I interpreted my taskexp 
> correctly.
> 

I took the liberty of doing some more history digging, lzop-native 
dependency was added in OE-Core commit

ee0640cb0c32b959ffaaac6752d582ed1d76e313
kernel.bbclass: add lzop dependency

and it looks to me it'd be worth doing the same fix.

Jacob