public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] utils: Drop is_machine_specific()/machine_path()
Date: Mon, 4 May 2020 16:03:45 +0000	[thread overview]
Message-ID: <c2c7a009fcbf4e92bdd93d1b700d934f@XBOX03.axis.com> (raw)
In-Reply-To: <20200504155258.3231675-1-richard.purdie@linuxfoundation.org>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 4 maj 2020 17:53
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] utils: Drop is_machine_specific()/machine_path()

machine_paths()

> There appear to be no users of these in OE-Core and their functionality
> is questionable at best too. Probably safest to remove that entirely

that -> them

> at this point.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

//Peter

> ---
>  meta/classes/utils.bbclass | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
> index c32b868aa88..120bcc64a64 100644
> --- a/meta/classes/utils.bbclass
> +++ b/meta/classes/utils.bbclass
> @@ -1,20 +1,3 @@
> -def machine_paths(d):
> -    """List any existing machine specific filespath directories"""
> -    machine = d.getVar("MACHINE")
> -    for basepath in d.getVar("FILESPATHBASE").split(":"):
> -        machinepath = os.path.join(basepath, machine)
> -        if os.path.isdir(machinepath):
> -            yield machinepath
> -
> -def is_machine_specific(d):
> -    """Determine whether the current recipe is machine specific"""
> -    machinepaths = set(machine_paths(d))
> -    srcuri = d.getVar("SRC_URI").split()
> -    for url in srcuri:
> -        fetcher = bb.fetch2.Fetch([srcuri], d)
> -        if url.startswith("file://"):
> -            if any(fetcher.localpath(url).startswith(mp + "/") for mp in machinepaths):
> -                return True
> 
>  oe_soinstall() {
>  	# Purpose: Install shared library file and
> --
> 2.25.1


      parent reply	other threads:[~2020-05-04 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 15:52 [PATCH] utils: Drop is_machine_specific()/machine_path() Richard Purdie
2020-05-04 16:02 ` ✗ patchtest: failure for " Patchwork
2020-05-04 16:03 ` Peter Kjellerstedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2c7a009fcbf4e92bdd93d1b700d934f@XBOX03.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox