[PATCH] utils: Drop is_machine_specific()/machine_path()

[PATCH] utils: Drop is_machine_specific()/machine_path()

[Richard Purdie]

There appear to be no users of these in OE-Core and their functionality
is questionable at best too. Probably safest to remove that entirely
at this point.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/utils.bbclass | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index c32b868aa88..120bcc64a64 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -1,20 +1,3 @@
-def machine_paths(d):
-    """List any existing machine specific filespath directories"""
-    machine = d.getVar("MACHINE")
-    for basepath in d.getVar("FILESPATHBASE").split(":"):
-        machinepath = os.path.join(basepath, machine)
-        if os.path.isdir(machinepath):
-            yield machinepath
-
-def is_machine_specific(d):
-    """Determine whether the current recipe is machine specific"""
-    machinepaths = set(machine_paths(d))
-    srcuri = d.getVar("SRC_URI").split()
-    for url in srcuri:
-        fetcher = bb.fetch2.Fetch([srcuri], d)
-        if url.startswith("file://"):
-            if any(fetcher.localpath(url).startswith(mp + "/") for mp in machinepaths):
-                return True
 
 oe_soinstall() {
 	# Purpose: Install shared library file and
-- 
2.25.1

✗ patchtest: failure for utils: Drop is_machine_specific()/machine_path()

[Patchwork]

== Series Details ==

Series: utils: Drop is_machine_specific()/machine_path()
Revision: 1
URL   : https://patchwork.openembedded.org/series/23939/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 26eb22191f)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [OE-core] [PATCH] utils: Drop is_machine_specific()/machine_path()

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 4 maj 2020 17:53
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] utils: Drop is_machine_specific()/machine_path()

machine_paths()

> There appear to be no users of these in OE-Core and their functionality
> is questionable at best too. Probably safest to remove that entirely

that -> them

> at this point.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

//Peter

> ---
>  meta/classes/utils.bbclass | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
> index c32b868aa88..120bcc64a64 100644
> --- a/meta/classes/utils.bbclass
> +++ b/meta/classes/utils.bbclass
> @@ -1,20 +1,3 @@
> -def machine_paths(d):
> -    """List any existing machine specific filespath directories"""
> -    machine = d.getVar("MACHINE")
> -    for basepath in d.getVar("FILESPATHBASE").split(":"):
> -        machinepath = os.path.join(basepath, machine)
> -        if os.path.isdir(machinepath):
> -            yield machinepath
> -
> -def is_machine_specific(d):
> -    """Determine whether the current recipe is machine specific"""
> -    machinepaths = set(machine_paths(d))
> -    srcuri = d.getVar("SRC_URI").split()
> -    for url in srcuri:
> -        fetcher = bb.fetch2.Fetch([srcuri], d)
> -        if url.startswith("file://"):
> -            if any(fetcher.localpath(url).startswith(mp + "/") for mp in machinepaths):
> -                return True
> 
>  oe_soinstall() {
>  	# Purpose: Install shared library file and
> --
> 2.25.1