Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>,
	"Burton, Ross" <ross.burton@intel.com>
Cc: Stefan Agner <stefan.agner@toradex.com>,
	Otavio Salvador <otavio@ossystems.com.br>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] waf.bbclass: explicitly pass libdir
Date: Tue, 12 Dec 2017 08:48:58 +0100	[thread overview]
Message-ID: <cde7f929023e7d027409f771c6376765@agner.ch> (raw)
In-Reply-To: <CAP9ODKoD9daGh83bwhLLzEW_7r+i65pH7hm4NwymD_+2LU6bMA@mail.gmail.com>

On 2017-12-11 18:15, Otavio Salvador wrote:
> On Mon, Dec 11, 2017 at 3:09 PM, Burton, Ross <ross.burton@intel.com> wrote:
>> On 11 December 2017 at 15:37, Joshua Watt <jpewhacker@gmail.com> wrote:
>>>
>>> Vanilla waf only supports --prefix, --libdir, and --bindir. Anything else
>>> is a result of loading the gnu_dirs tool, which not all projects are
>>> required to do.
>>>
>>>
>>> Sorry, hit send too soo: waf (at least version 2.0) also errors out on
>>> unknown options. I think the three I listed are the only ones we can do
>>> generically. There might be some way to easily adding the rest if you know
>>> waf is loading gnu_dirs
>>
>>
>> One option would be for waf.bbclass to check if WAF_USES_GNU_DIRS is set
>> (defaulting to 0) and pass the full set of path options automatically.
> 
> Possible. But passing the standard ones solve 99% of the issues.
> 

I am with Otavio here. Also, adding the standard ones and adding the
additional GNU_DIRS would best be done in two independent patches
anyway. For now I'd rather prefer to only add the standard ones.

--
Stefan


  reply	other threads:[~2017-12-12  7:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 13:57 [PATCH] waf.bbclass: explicitly pass libdir Stefan Agner
2017-12-11 14:01 ` Burton, Ross
2017-12-11 14:16   ` Stefan Agner
2017-12-11 14:58     ` Burton, Ross
2017-12-11 15:32       ` Joshua Watt
2017-12-11 15:37         ` Joshua Watt
2017-12-11 17:09           ` Burton, Ross
2017-12-11 17:15             ` Otavio Salvador
2017-12-12  7:48               ` Stefan Agner [this message]
2017-12-12 10:58                 ` Burton, Ross
2017-12-12 11:07                   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cde7f929023e7d027409f771c6376765@agner.ch \
    --to=stefan@agner.ch \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio.salvador@ossystems.com.br \
    --cc=otavio@ossystems.com.br \
    --cc=ross.burton@intel.com \
    --cc=stefan.agner@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox