Re: [PATCH] waf.bbclass: explicitly pass libdir

[Stefan Agner <stefan@agner.ch>]

On 2017-12-12 11:58, Burton, Ross wrote:

> On 12 December 2017 at 07:48, Stefan Agner <stefan@agner.ch> wrote:
> 
>> On 2017-12-11 18:15, Otavio Salvador wrote:
>>> On Mon, Dec 11, 2017 at 3:09 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>>> On 11 December 2017 at 15:37, Joshua Watt <jpewhacker@gmail.com> wrote:
>>>>> 
>>>>> Vanilla waf only supports --prefix, --libdir, and --bindir. Anything else
>>>>> is a result of loading the gnu_dirs tool, which not all projects are
>>>>> required to do.
>>>>> 
>>>>> 
>>>>> Sorry, hit send too soo: waf (at least version 2.0) also errors out on
>>>>> unknown options. I think the three I listed are the only ones we can do
>>>>> generically. There might be some way to easily adding the rest if you know
>>>>> waf is loading gnu_dirs
>>>> 
>>>> 
>>>> One option would be for waf.bbclass to check if WAF_USES_GNU_DIRS is set
>>>> (defaulting to 0) and pass the full set of path options automatically.
>>> 
>>> Possible. But passing the standard ones solve 99% of the issues.
>>> 
>> 
>> I am with Otavio here. Also, adding the standard ones and adding the
>> additional GNU_DIRS would best be done in two independent patches
>> anyway. For now I'd rather prefer to only add the standard ones.
> 
> Fine by me.  Will there be a v2 adding --bindir? 
> 

Yes, will send soon. 

-- 
Stefan