[PATCH 0/1] a bugfix for gcc-runtime recipe

[PATCH 0/1] a bugfix for gcc-runtime recipe

[Nitin A Kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

More details in the commit email.

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: nitin/misc
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc

Thanks,
    Nitin A Kamble <nitin.a.kamble@intel.com>
---


Nitin A Kamble (1):
  gcc-runtime: fix LSB library checks for libstdc++.so.6

 .../recipes-devtools/gcc/gcc-configure-runtime.inc |    3 +++
 meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb     |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)

-- 
1.7.3.4

[PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

[Nitin A Kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

[YOCTO #795]

When we run library check of LSB on qemux86 and qemuppc, we got some failures
about 'libstdc++.so.6'.

Test environment:
Platform: Qemu-x86, Qemu-ppc
lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server)
Library check of LSB: 4.1.0-1

The error log:
Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6
Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*,
char*) const
...

 found that some weak symbols ('W') change into local ('t') during link time
and be stripped. According to compiling log, the option
"-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak
symbols change into local.

see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../recipes-devtools/gcc/gcc-configure-runtime.inc |    3 +++
 meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb     |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
index 6cc11e2..2d214af 100644
--- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
@@ -1,5 +1,8 @@
 require gcc-configure-common.inc
 
+CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden',
+'${CXXFLAGS}', d)}" 
+
 EXTRA_OECONF_PATHS = " \
     --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \
     --with-gxx-include-dir=${includedir}/c++/ \
diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
index 093f9bf..c1e680d 100644
--- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
+++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
@@ -1,4 +1,4 @@
-PR = "r2"
+PR = "r3"
 
 require gcc-${PV}.inc
 require gcc-configure-runtime.inc
-- 
1.7.3.4

Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

[Khem Raj]

On 3/8/2011 5:26 PM, Nitin A Kamble wrote:
> From: Nitin A Kamble<nitin.a.kamble@intel.com>
>
> [YOCTO #795]
>
> When we run library check of LSB on qemux86 and qemuppc, we got some failures
> about 'libstdc++.so.6'.
>
> Test environment:
> Platform: Qemu-x86, Qemu-ppc
> lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server)
> Library check of LSB: 4.1.0-1
>
> The error log:
> Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6
> Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*,
> char*) const
> ...
>
>   found that some weak symbols ('W') change into local ('t') during link time
> and be stripped. According to compiling log, the option
> "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak
> symbols change into local.
>
> see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug.
>
> Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com>
> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>

thank you. Applied it to openembedded-core

Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

[Richard Purdie]

On Tue, 2011-03-08 at 20:54 -0800, Khem Raj wrote:
> On 3/8/2011 5:26 PM, Nitin A Kamble wrote:
> > From: Nitin A Kamble<nitin.a.kamble@intel.com>
> >
> > [YOCTO #795]
> >
> > When we run library check of LSB on qemux86 and qemuppc, we got some failures
> > about 'libstdc++.so.6'.
> >
> > Test environment:
> > Platform: Qemu-x86, Qemu-ppc
> > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server)
> > Library check of LSB: 4.1.0-1
> >
> > The error log:
> > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6
> > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*,
> > char*) const
> > ...
> >
> >   found that some weak symbols ('W') change into local ('t') during link time
> > and be stripped. According to compiling log, the option
> > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak
> > symbols change into local.
> >
> > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug.
> >
> > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com>
> > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
> > Signed-off-by: Khem Raj<raj.khem@gmail.com>
> 
> thank you. Applied it to openembedded-core

This raises some questions about how the pull model works as I'd been
holding off the python RDEPENDS change until I'd had time to check
something out yet you've applied it. I haven't had the time to be able
to make any informed feedback on the patch yet whether it was ok or not
and being able to give any informed feedback takes time.

My basic concern that that the RDEPENDS shouldn't be having that effect
on native packages and it if it, we probably have a bug somewhere else
that likely needs fixing.

So the question is whether we are going truly for the pull model, who
are the people top of tree, what code review applies to patches from
those people, how absence might get handled and so forth.

As an illustration, it would have been much more useful for me if
someone had pulled the individual patches together into a single git
branch and presented that. This helps me as it highlights the
outstanding patches and is what Saul does with many of the Yocto
patches.

I'm aware there are a few patches pending review and I'm thinking the
best approach may be some kind of staging/-next type branch where we
keep these as we review and then either accept, reject or ask for
improvements.

One other thing I noticed is that Khem merged a patch known to be broken
and then a fixup for it several commits later. I don't like to do that
for known breakage since it means things are not bisectable and in that
case I'd have squashed the changes with an update to the commit message
about the change. Its not a major issue but something to keep in mind
going forwards.

Cheers,

Richard

Re: [poky] [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

[Khem Raj]

On Wed, Mar 9, 2011 at 11:58 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2011-03-08 at 20:54 -0800, Khem Raj wrote:
>> On 3/8/2011 5:26 PM, Nitin A Kamble wrote:
>> > From: Nitin A Kamble<nitin.a.kamble@intel.com>
>> >
>> > [YOCTO #795]
>> >
>> > When we run library check of LSB on qemux86 and qemuppc, we got some failures
>> > about 'libstdc++.so.6'.
>> >
>> > Test environment:
>> > Platform: Qemu-x86, Qemu-ppc
>> > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server)
>> > Library check of LSB: 4.1.0-1
>> >
>> > The error log:
>> > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6
>> > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*,
>> > char*) const
>> > ...
>> >
>> >   found that some weak symbols ('W') change into local ('t') during link time
>> > and be stripped. According to compiling log, the option
>> > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak
>> > symbols change into local.
>> >
>> > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug.
>> >
>> > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com>
>> > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
>> > Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>
>> thank you. Applied it to openembedded-core
>
> This raises some questions about how the pull model works as I'd been
> holding off the python RDEPENDS change until I'd had time to check
> something out yet you've applied it. I haven't had the time to be able
> to make any informed feedback on the patch yet whether it was ok or not
> and being able to give any informed feedback takes time.
>
> My basic concern that that the RDEPENDS shouldn't be having that effect
> on native packages and it if it, we probably have a bug somewhere else
> that likely needs fixing.
>
> So the question is whether we are going truly for the pull model, who
> are the people top of tree, what code review applies to patches from
> those people, how absence might get handled and so forth.
>

> As an illustration, it would have been much more useful for me if
> someone had pulled the individual patches together into a single git
> branch and presented that.

Yes thats probably better

 This helps me as it highlights the
> outstanding patches and is what Saul does with many of the Yocto
> patches.
>
> I'm aware there are a few patches pending review and I'm thinking the
> best approach may be some kind of staging/-next type branch where we
> keep these as we review and then either accept, reject or ask for
> improvements.
>

usually if a patch has reviews that needs retouching it. It should go
back through the same cycle it went first time
which was my assumption here which obviously was not case here. the
patches to oe-core from yocto
I assumed were proposed through the branch to pull from and I think is
a good way to prune errors as patches move into
oe-core

> One other thing I noticed is that Khem merged a patch known to be broken
> and then a fixup for it several commits later. I don't like to do that
> for known breakage since it means things are not bisectable and in that
> case I'd have squashed the changes with an update to the commit message
> about the change. Its not a major issue but something to keep in mind
> going forwards.

Yes bisection is important. I guess I assumed too much even though I
was verifying
We need to have openembedded-core-contrib setup for people who do not
have possibility to use yocto-contrib

Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

[Lu Jingdong]

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

On 03/09/2011 09:26 AM, Nitin A Kamble wrote:
>   .../recipes-devtools/gcc/gcc-configure-runtime.inc |    3 +++
>   meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb     |    2 +-
>   2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> index 6cc11e2..2d214af 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> @@ -1,5 +1,8 @@
>   require gcc-configure-common.inc
>
> +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden',
> +'${CXXFLAGS}', d)}"
> +
I think it should be

CXXFLAGS*:=*  "${@oe_filter_out('-fvisibility-inlines-hidden',
'${CXXFLAGS}', d)}"

otherwise it will give the following error log.
NOTE: Error expanding variable CXXFLAGS###############################################################                                 | ETA:  00:00:00
ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself!

It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error.

>   EXTRA_OECONF_PATHS = " \
>       --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \
>       --with-gxx-include-dir=${includedir}/c++/ \
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> index 093f9bf..c1e680d 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> @@ -1,4 +1,4 @@
> -PR = "r2"
> +PR = "r3"
>
>   require gcc-${PV}.inc
>   require gcc-configure-runtime.inc


-- 
Lu Jingdong
jingdong.lu@windriver.com
China, Wind River


[-- Attachment #2: Type: text/html, Size: 2475 bytes --]

Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

[Kamble, Nitin A]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]



From: Lu Jingdong [mailto:jingdong.lu@windriver.com]
Sent: Wednesday, March 09, 2011 1:45 AM
To: Kamble, Nitin A
Cc: poky@yoctoproject.org; openembedded-core@lists.openembedded.org; Khem Raj
Subject: Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6

On 03/09/2011 09:26 AM, Nitin A Kamble wrote:

 .../recipes-devtools/gcc/gcc-configure-runtime.inc |    3 +++

 meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb     |    2 +-

 2 files changed, 4 insertions(+), 1 deletions(-)



diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc

index 6cc11e2..2d214af 100644

--- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc

+++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc

@@ -1,5 +1,8 @@

 require gcc-configure-common.inc



+CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden',

+'${CXXFLAGS}', d)}"

+
I think it should be


CXXFLAGS := "${@oe_filter_out('-fvisibility-inlines-hidden',

'${CXXFLAGS}', d)}"







This is correct. I also saw the bellow error and I have tested with := only. But missed merging the change back to the commit before pushing.

Sorry about that.



Thanks,

Nitin





otherwise it will give the following error log.

NOTE: Error expanding variable CXXFLAGS###############################################################                                 | ETA:  00:00:00

ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself!



It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error.

 EXTRA_OECONF_PATHS = " \

     --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \

     --with-gxx-include-dir=${includedir}/c++/ \

diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb

index 093f9bf..c1e680d 100644

--- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb

+++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb

@@ -1,4 +1,4 @@

-PR = "r2"

+PR = "r3"



 require gcc-${PV}.inc

 require gcc-configure-runtime.inc




--

Lu Jingdong

jingdong.lu@windriver.com<mailto:jingdong.lu@windriver.com>

China, Wind River

[-- Attachment #2: Type: text/html, Size: 7640 bytes --]