* [PATCH 0/2] eglibc: migrate configurability from oe V5 @ 2011-06-13 9:01 Kang Kai 2011-06-13 9:01 ` [PATCH 1/2] bitbake: add local.conf.sample.extended Kang Kai 2011-06-13 9:01 ` [PATCH 2/2] eglibc: migrate configurability from oe Kang Kai 0 siblings, 2 replies; 10+ messages in thread From: Kang Kai @ 2011-06-13 9:01 UTC (permalink / raw) To: sgw; +Cc: openembedded-core From: Kang Kai <kai.kang@windriver.com> Hi Saul, This update only add file local.conf.sample.extended, not source it any more. Using DISTRO_FEATURES_LIBC to manage eglibc configurable options suggested by Koen and Martin, and set DISTRO_FEATURES_LIBC in default-distrovars.inc to enable all eglibc configurable options by default to make current compilation succeed. Regards, The following changes since commit 7f34cd1eb2a459709006ae985a14decd4d2152e6: tzcode: Update to 2011g (2011-06-06 15:58:42 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib kangkai/distro http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro Kang Kai (2): bitbake: add local.conf.sample.extended eglibc: migrate configurability from oe meta-yocto/conf/local.conf.sample.extended | 12 ++++ meta/conf/distro/include/default-distrovars.inc | 9 +++- meta/recipes-core/eglibc/eglibc-options.inc | 62 +++++++++++++++++++++++ meta/recipes-core/eglibc/eglibc.inc | 6 ++ 4 files changed, 88 insertions(+), 1 deletions(-) create mode 100644 meta-yocto/conf/local.conf.sample.extended create mode 100644 meta/recipes-core/eglibc/eglibc-options.inc -- 1.7.5.1.300.gc565c ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] bitbake: add local.conf.sample.extended 2011-06-13 9:01 [PATCH 0/2] eglibc: migrate configurability from oe V5 Kang Kai @ 2011-06-13 9:01 ` Kang Kai 2011-06-13 9:01 ` [PATCH 2/2] eglibc: migrate configurability from oe Kang Kai 1 sibling, 0 replies; 10+ messages in thread From: Kang Kai @ 2011-06-13 9:01 UTC (permalink / raw) To: sgw; +Cc: openembedded-core From: Kang Kai <kai.kang@windriver.com> Add a new configuration file local.conf.sample.extended, and more advanced settings what user can configure could put in this file. Signed-off-by: Kang Kai <kai.kang@windriver.com> --- meta-yocto/conf/local.conf.sample.extended | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) create mode 100644 meta-yocto/conf/local.conf.sample.extended diff --git a/meta-yocto/conf/local.conf.sample.extended b/meta-yocto/conf/local.conf.sample.extended new file mode 100644 index 0000000..277ee2a --- /dev/null +++ b/meta-yocto/conf/local.conf.sample.extended @@ -0,0 +1,12 @@ +# eglibc configurability is used to reduce minimal images's size. +# the all supported eglibc options are listed in DISTRO_FEATURES_LIBC +# and disabled by default. Uncomment and copy the DISTRO_FEATURES_LIBC +# and DISTRO_FEATURES definitions to local.conf to enable the options. +#DISTRO_FEATURES_LIBC = "ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \ +# libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \ +# libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \ +# libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \ +# libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \ +# libc-posix-wchar-io" + +#DISTRO_FEATURES = "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" -- 1.7.5.1.300.gc565c ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:01 [PATCH 0/2] eglibc: migrate configurability from oe V5 Kang Kai 2011-06-13 9:01 ` [PATCH 1/2] bitbake: add local.conf.sample.extended Kang Kai @ 2011-06-13 9:01 ` Kang Kai 2011-06-13 9:05 ` Phil Blundell 1 sibling, 1 reply; 10+ messages in thread From: Kang Kai @ 2011-06-13 9:01 UTC (permalink / raw) To: sgw; +Cc: openembedded-core From: Kang Kai <kai.kang@windriver.com> Migrate configurability from oe, try to shrink minimal image size All eglibc configuration options are included in conf/distro/include/default-distrovars.inc. Define DISTRO_FEATURES_LIBC and DISTRO_FEATURES in local.conf with the same way in local.conf.sample.extended to enable those options. Signed-off-by: Kang Kai <kai.kang@windriver.com> --- meta/conf/distro/include/default-distrovars.inc | 9 +++- meta/recipes-core/eglibc/eglibc-options.inc | 62 +++++++++++++++++++++++ meta/recipes-core/eglibc/eglibc.inc | 6 ++ 3 files changed, 76 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-core/eglibc/eglibc-options.inc diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc index 4b68a0a..2cde46c 100644 --- a/meta/conf/distro/include/default-distrovars.inc +++ b/meta/conf/distro/include/default-distrovars.inc @@ -10,7 +10,14 @@ LIMIT_BUILT_LOCALES ?= "POSIX en_US en_GB" ENABLE_BINARY_LOCALE_GENERATION ?= "1" LOCALE_UTF8_ONLY ?= "0" -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci" +DISTRO_FEATURES_LIBC ?= "ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \ + libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \ + libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \ + libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \ + libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \ + libc-posix-wchar-io" + +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" IMAGE_FEATURES ?= "" diff --git a/meta/recipes-core/eglibc/eglibc-options.inc b/meta/recipes-core/eglibc/eglibc-options.inc new file mode 100644 index 0000000..119ceef --- /dev/null +++ b/meta/recipes-core/eglibc/eglibc-options.inc @@ -0,0 +1,62 @@ +def eglibc_cfg(feature, features, tokens, cnf): + if type(tokens) == type(""): + tokens = [tokens] + if type(features) == type([]) and feature in features: + cnf.extend([token + ' = y' for token in tokens]) + else: + for token in tokens: + cnf.extend([token + ' = n']) + if token == 'OPTION_EGLIBC_NSSWITCH': + cnf.extend(["OPTION_EGLIBC_NSSWITCH_FIXED_CONFIG = ${S}/nss/nsswitch.conf"]) + cnf.extend(["OPTION_EGLIBC_NSSWITCH_FIXED_FUNCTIONS = ${S}/nss/fixed-nsswitch.functions"]) + +# Map distro features to eglibc options settings +def features_to_eglibc_settings(d): + cnf = ([]) + distro_features = (bb.data.getVar('DISTRO_FEATURES', d, True) or '').split() + eglibc_cfg('ipv6', distro_features, 'OPTION_EGLIBC_ADVANCED_INET6', cnf) + eglibc_cfg('libc-backtrace', distro_features, 'OPTION_EGLIBC_BACKTRACE', cnf) + eglibc_cfg('libc-big-macros', distro_features, 'OPTION_EGLIBC_BIG_MACROS', cnf) + eglibc_cfg('libc-bsd', distro_features, 'OPTION_EGLIBC_BSD', cnf) + eglibc_cfg('libc-cxx-tests', distro_features, 'OPTION_EGLIBC_CXX_TESTS', cnf) + eglibc_cfg('libc-catgets', distro_features, 'OPTION_EGLIBC_CATGETS', cnf) + eglibc_cfg('libc-charsets', distro_features, 'OPTION_EGLIBC_CHARSETS', cnf) + eglibc_cfg('libc-crypt', distro_features, 'OPTION_EGLIBC_CRYPT', cnf) + eglibc_cfg('libc-crypt-ufc', distro_features, 'OPTION_EGLIBC_CRYPT_UFC', cnf) + eglibc_cfg('libc-db-aliases', distro_features, 'OPTION_EGLIBC_DB_ALIASES', cnf) + eglibc_cfg('libc-envz', distro_features, 'OPTION_EGLIBC_ENVZ', cnf) + eglibc_cfg('libc-fcvt', distro_features, 'OPTION_EGLIBC_FCVT', cnf) + eglibc_cfg('libc-fmtmsg', distro_features, 'OPTION_EGLIBC_FMTMSG', cnf) + eglibc_cfg('libc-fstab', distro_features, 'OPTION_EGLIBC_FSTAB', cnf) + eglibc_cfg('libc-ftraverse', distro_features, 'OPTION_EGLIBC_FTRAVERSE', cnf) + eglibc_cfg('libc-getlogin', distro_features, 'OPTION_EGLIBC_GETLOGIN', cnf) + eglibc_cfg('libc-idn', distro_features, 'OPTION_EGLIBC_IDN', cnf) + eglibc_cfg('libc-inet', distro_features, 'OPTION_EGLIBC_INET', cnf) + eglibc_cfg('libc-inet-anl', distro_features, 'OPTION_EGLIBC_INET_ANL', cnf) + eglibc_cfg('libc-libm', distro_features, 'OPTION_EGLIBC_LIBM', cnf) + eglibc_cfg('libc-libm-big', distro_features, 'OPTION_EGLIBC_LIBM_BIG', cnf) + eglibc_cfg('libc-locales', distro_features, 'OPTION_EGLIBC_LOCALES', cnf) + eglibc_cfg('libc-locale-code', distro_features, 'OPTION_EGLIBC_LOCALE_CODE', cnf) + eglibc_cfg('libc-memusage', distro_features, 'OPTION_EGLIBC_MEMUSAGE', cnf) + eglibc_cfg('libc-nis', distro_features, 'OPTION_EGLIBC_NIS', cnf) + eglibc_cfg('libc-nsswitch', distro_features, 'OPTION_EGLIBC_NSSWITCH', cnf) + eglibc_cfg('libc-rcmd', distro_features, 'OPTION_EGLIBC_RCMD', cnf) + eglibc_cfg('libc-rtld-debug', distro_features, 'OPTION_EGLIBC_RTLD_DEBUG', cnf) + eglibc_cfg('libc-spawn', distro_features, 'OPTION_EGLIBC_SPAWN', cnf) + eglibc_cfg('libc-streams', distro_features, 'OPTION_EGLIBC_STREAMS', cnf) + eglibc_cfg('libc-sunrpc', distro_features, 'OPTION_EGLIBC_SUNRPC', cnf) + eglibc_cfg('libc-utmp', distro_features, 'OPTION_EGLIBC_UTMP', cnf) + eglibc_cfg('libc-utmpx', distro_features, 'OPTION_EGLIBC_UTMPX', cnf) + eglibc_cfg('libc-wordexp', distro_features, 'OPTION_EGLIBC_WORDEXP', cnf) + eglibc_cfg('libc-posix-clang-wchar', distro_features, 'OPTION_POSIX_C_LANG_WIDE_CHAR', cnf) + eglibc_cfg('libc-posix-regexp', distro_features, 'OPTION_POSIX_REGEXP', cnf) + eglibc_cfg('libc-posix-regexp-glibc', distro_features, 'OPTION_POSIX_REGEXP_GLIBC', cnf) + eglibc_cfg('libc-posix-wchar-io', distro_features, 'OPTION_POSIX_WIDE_CHAR_DEVICE_IO', cnf) + + # try to fix disable charsets/locales/locale-code compile fail + if 'libc-charsets' in distro_features and 'libc-locales' in distro_features and 'libc-locale-code' in distro_features: + bb.data.setVar('PACKAGE_NO_GCONV', '0', d) + else: + bb.data.setVar('PACKAGE_NO_GCONV', '1', d) + + return "\n".join(cnf) diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc index 46ffa82..616f1af 100644 --- a/meta/recipes-core/eglibc/eglibc.inc +++ b/meta/recipes-core/eglibc/eglibc.inc @@ -28,6 +28,7 @@ DEPENDS = "virtual/${TARGET_PREFIX}gcc-intermediate linux-libc-headers" PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc" PROVIDES += "virtual/libintl virtual/libiconv" inherit autotools +require eglibc-options.inc LEAD_SONAME = "libc.so" @@ -43,3 +44,8 @@ EXTRA_OEMAKE += ${EGLIBCPARALLELISM} PARALLEL_MAKE = "" PACKAGES = "glibc catchsegv sln nscd ldd localedef glibc-utils glibc-dev glibc-doc glibc-locale libsegfault glibc-extra-nss glibc-thread-db glibc-pcprofile" + +OE_FEATURES = "${@features_to_eglibc_settings(d)}" +do_configure_prepend() { + echo '${OE_FEATURES}' > ${B}/option-groups.config +} -- 1.7.5.1.300.gc565c ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:01 ` [PATCH 2/2] eglibc: migrate configurability from oe Kang Kai @ 2011-06-13 9:05 ` Phil Blundell 2011-06-13 9:15 ` Kang Kai 0 siblings, 1 reply; 10+ messages in thread From: Phil Blundell @ 2011-06-13 9:05 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2011-06-13 at 17:01 +0800, Kang Kai wrote: > -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci" > +DISTRO_FEATURES_LIBC ?= "ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \ > + libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \ > + libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \ > + libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \ > + libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \ > + libc-posix-wchar-io" > + > +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" Why is ipv6 in DISTRO_FEATURES_LIBC rather than DISTRO_FEATURES? p. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:05 ` Phil Blundell @ 2011-06-13 9:15 ` Kang Kai 2011-06-13 9:27 ` Phil Blundell 0 siblings, 1 reply; 10+ messages in thread From: Kang Kai @ 2011-06-13 9:15 UTC (permalink / raw) To: openembedded-core On 2011年06月13日 17:05, Phil Blundell wrote: > On Mon, 2011-06-13 at 17:01 +0800, Kang Kai wrote: >> -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci" >> +DISTRO_FEATURES_LIBC ?= "ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \ >> + libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \ >> + libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \ >> + libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \ >> + libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \ >> + libc-posix-wchar-io" >> + >> +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" > Why is ipv6 in DISTRO_FEATURES_LIBC rather than DISTRO_FEATURES? Because eglibc has a feature libc-ipv6, and DISTRO_FEATURES has a ipv6 already. It is not needed to import a new feature name on the same things, so use original ipv6. And eglibc still needs provide this option, then put it in DISTRO_FEATURES_LIBC. > p. > Regards, Kai > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:15 ` Kang Kai @ 2011-06-13 9:27 ` Phil Blundell 2011-06-13 9:34 ` Kang Kai 0 siblings, 1 reply; 10+ messages in thread From: Phil Blundell @ 2011-06-13 9:27 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2011-06-13 at 17:15 +0800, Kang Kai wrote: > On 2011年06月13日 17:05, Phil Blundell wrote: > > On Mon, 2011-06-13 at 17:01 +0800, Kang Kai wrote: > >> -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci" > >> +DISTRO_FEATURES_LIBC ?= "ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \ > >> + libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \ > >> + libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \ > >> + libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \ > >> + libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \ > >> + libc-posix-wchar-io" > >> + > >> +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" > > Why is ipv6 in DISTRO_FEATURES_LIBC rather than DISTRO_FEATURES? > > Because eglibc has a feature libc-ipv6, and DISTRO_FEATURES has a ipv6 > already. It is not needed to import a new feature name on the same > things, so use original ipv6. And eglibc still needs provide this > option, then put it in DISTRO_FEATURES_LIBC. I'm not quite sure I understood what you wrote above. But I think what I was asking was, why doesn't eglibc just look at the existing ipv6 DISTRO_FEATURE? p. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:27 ` Phil Blundell @ 2011-06-13 9:34 ` Kang Kai 2011-06-13 9:42 ` Phil Blundell 0 siblings, 1 reply; 10+ messages in thread From: Kang Kai @ 2011-06-13 9:34 UTC (permalink / raw) To: openembedded-core On 2011年06月13日 17:27, Phil Blundell wrote: > On Mon, 2011-06-13 at 17:15 +0800, Kang Kai wrote: >> On 2011年06月13日 17:05, Phil Blundell wrote: >>> On Mon, 2011-06-13 at 17:01 +0800, Kang Kai wrote: >>>> -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci" >>>> +DISTRO_FEATURES_LIBC ?= "ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \ >>>> + libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \ >>>> + libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \ >>>> + libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \ >>>> + libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \ >>>> + libc-posix-wchar-io" >>>> + >>>> +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" >>> Why is ipv6 in DISTRO_FEATURES_LIBC rather than DISTRO_FEATURES? >> Because eglibc has a feature libc-ipv6, and DISTRO_FEATURES has a ipv6 >> already. It is not needed to import a new feature name on the same >> things, so use original ipv6. And eglibc still needs provide this >> option, then put it in DISTRO_FEATURES_LIBC. > I'm not quite sure I understood what you wrote above. But I think what > I was asking was, why doesn't eglibc just look at the existing ipv6 > DISTRO_FEATURE? It seems DISTRO_FEATURE doesn't want to enable ipv6 by default, but eglibc needs supports it. > p. > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:34 ` Kang Kai @ 2011-06-13 9:42 ` Phil Blundell 2011-06-13 10:00 ` Martin Jansa 0 siblings, 1 reply; 10+ messages in thread From: Phil Blundell @ 2011-06-13 9:42 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2011-06-13 at 17:34 +0800, Kang Kai wrote: > It seems DISTRO_FEATURE doesn't want to enable ipv6 by default, but > eglibc needs supports it. That doesn't seem like it can be right. Why would you want ipv6 in eglibc if your DISTRO isn't using it? The whole point of DISTRO_FEATURES is that it's meant to give you a coherent set of system-wide options. FWIW, I think ipv6 should probably be set on in default-distrovar's DISTRO_FEATURES, but I guess some higher authority would need to make that decision. p. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 9:42 ` Phil Blundell @ 2011-06-13 10:00 ` Martin Jansa 2011-06-13 11:07 ` Phil Blundell 0 siblings, 1 reply; 10+ messages in thread From: Martin Jansa @ 2011-06-13 10:00 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, Jun 13, 2011 at 11:42 AM, Phil Blundell <pb@pbcl.net> wrote: > On Mon, 2011-06-13 at 17:34 +0800, Kang Kai wrote: >> It seems DISTRO_FEATURE doesn't want to enable ipv6 by default, but >> eglibc needs supports it. > > That doesn't seem like it can be right. Why would you want ipv6 in > eglibc if your DISTRO isn't using it? > > The whole point of DISTRO_FEATURES is that it's meant to give you a > coherent set of system-wide options. > > FWIW, I think ipv6 should probably be set on in default-distrovar's > DISTRO_FEATURES, but I guess some higher authority would need to make > that decision. > > p. I see your point but ipv6 as DISTRO_FEATURES_LIBC ends in DISTRO_FEATURES as well DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" so I'm fine with ipv6 in DISTRO_FEATURES_LIBC this way I can expect *libc to be tweaked by DISTRO_FEATURES_LIBC only and the rest of image by whole DISTRO_FEATURES (including libc-* flags and ipv6 from DISTRO_FEATURES_LIBC) Regards, ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] eglibc: migrate configurability from oe 2011-06-13 10:00 ` Martin Jansa @ 2011-06-13 11:07 ` Phil Blundell 0 siblings, 0 replies; 10+ messages in thread From: Phil Blundell @ 2011-06-13 11:07 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2011-06-13 at 12:00 +0200, Martin Jansa wrote: > On Mon, Jun 13, 2011 at 11:42 AM, Phil Blundell <pb@pbcl.net> wrote: > > FWIW, I think ipv6 should probably be set on in default-distrovar's > > DISTRO_FEATURES, but I guess some higher authority would need to make > > that decision. > > I see your point > > but ipv6 as DISTRO_FEATURES_LIBC ends in DISTRO_FEATURES as well > DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost > wifi nfs zeroconf pci ${DISTRO_FEATURES_LIBC}" Oh, so it does. So the effect of this is that we will end up with ipv6 on in DISTRO_FEATURES anyway. I guess I would consider this a good result, if perhaps for the wrong reasons :-) p. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-06-13 11:10 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-06-13 9:01 [PATCH 0/2] eglibc: migrate configurability from oe V5 Kang Kai 2011-06-13 9:01 ` [PATCH 1/2] bitbake: add local.conf.sample.extended Kang Kai 2011-06-13 9:01 ` [PATCH 2/2] eglibc: migrate configurability from oe Kang Kai 2011-06-13 9:05 ` Phil Blundell 2011-06-13 9:15 ` Kang Kai 2011-06-13 9:27 ` Phil Blundell 2011-06-13 9:34 ` Kang Kai 2011-06-13 9:42 ` Phil Blundell 2011-06-13 10:00 ` Martin Jansa 2011-06-13 11:07 ` Phil Blundell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox