[PATCH 0/1] Fix Pseudo on hosts with older compilers

[PATCH 0/1] Fix Pseudo on hosts with older compilers

[Joshua Lock]

The realpath_fix patch included an unitialised variable which modern GCC
cleverly optimises away, however hosts with older GCC like CentOS 5.x weren't
so lucky and... BOOM.

See http://git.yoctoproject.org/cgit/cgit.cgi/pseudo/commit/?id=4a646c8bbe73ca830cb8c2e80be4b457d925cdd4 for a more detailed description.

The following changes since commit 6ca80453618fa308cc2d6329450aaf5dfdf2d610:

  Fixed concurrency problem for ZIP packed recipes. (2011-07-19 18:03:04 +0100)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib josh/pseudo
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/pseudo

Joshua Lock (1):
  pseudo: fix uninitialised variable in realpath_fix.patch

 .../pseudo/pseudo/realpath_fix.patch               |    2 +-
 meta/recipes-devtools/pseudo/pseudo_1.1.1.bb       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.6

[PATCH 1/1] pseudo: fix uninitialised variable in realpath_fix.patch

[Joshua Lock]

Several users reported issues with pseudo on CentOS 5.x hosts, Matthew
McClintock tracked the issue to the realpath_fix.patch and Mark Hatle
supplied the included fix.

CC: Matthew McClintock <msm@freescale.com>
CC: Mark Hatle <mark.hatle@windriver.com>

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 .../pseudo/pseudo/realpath_fix.patch               |    2 +-
 meta/recipes-devtools/pseudo/pseudo_1.1.1.bb       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch b/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch
index 7beea51..4a107e0 100644
--- a/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch
+++ b/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch
@@ -65,7 +65,7 @@ index 600a918..07a4429 100644
  
 +static void
 +pseudo_init_one_wrapper(pseudo_function *func) {
-+	int (*f)(void);
++	int (*f)(void) = (int (*)(void)) NULL;
 +	char *e;
 +	if (*func->real != NULL) {
 +		/* already initialized */
diff --git a/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb b/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb
index f1c8e63..0a61aec 100644
--- a/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb
@@ -1,6 +1,6 @@
 require pseudo.inc
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2 \
            file://oe-config.patch \
-- 
1.7.6

Re: [PATCH 1/1] pseudo: fix uninitialised variable in realpath_fix.patch

[Mark Hatle]

On 7/19/11 6:57 PM, Joshua Lock wrote:
> Several users reported issues with pseudo on CentOS 5.x hosts, Matthew
> McClintock tracked the issue to the realpath_fix.patch and Mark Hatle
> supplied the included fix.
> 
> CC: Matthew McClintock <msm@freescale.com>
> CC: Mark Hatle <mark.hatle@windriver.com>

Ack..  this has also already been included in the upstream pseudo.. when we move
to pseudo 1.1.2 we'll get this fix.

--Mark

> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  .../pseudo/pseudo/realpath_fix.patch               |    2 +-
>  meta/recipes-devtools/pseudo/pseudo_1.1.1.bb       |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch b/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch
> index 7beea51..4a107e0 100644
> --- a/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch
> +++ b/meta/recipes-devtools/pseudo/pseudo/realpath_fix.patch
> @@ -65,7 +65,7 @@ index 600a918..07a4429 100644
>   
>  +static void
>  +pseudo_init_one_wrapper(pseudo_function *func) {
> -+	int (*f)(void);
> ++	int (*f)(void) = (int (*)(void)) NULL;
>  +	char *e;
>  +	if (*func->real != NULL) {
>  +		/* already initialized */
> diff --git a/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb b/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb
> index f1c8e63..0a61aec 100644
> --- a/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb
> +++ b/meta/recipes-devtools/pseudo/pseudo_1.1.1.bb
> @@ -1,6 +1,6 @@
>  require pseudo.inc
>  
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2 \
>             file://oe-config.patch \

Re: [PATCH 0/1] Fix Pseudo on hosts with older compilers

[Saul Wold]

On 07/19/2011 04:57 PM, Joshua Lock wrote:
> The realpath_fix patch included an unitialised variable which modern GCC
> cleverly optimises away, however hosts with older GCC like CentOS 5.x weren't
> so lucky and... BOOM.
>
> See http://git.yoctoproject.org/cgit/cgit.cgi/pseudo/commit/?id=4a646c8bbe73ca830cb8c2e80be4b457d925cdd4 for a more detailed description.
>
> The following changes since commit 6ca80453618fa308cc2d6329450aaf5dfdf2d610:
>
>    Fixed concurrency problem for ZIP packed recipes. (2011-07-19 18:03:04 +0100)
>
> are available in the git repository at:
>    git://git.openembedded.org/openembedded-core-contrib josh/pseudo
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/pseudo
>
> Joshua Lock (1):
>    pseudo: fix uninitialised variable in realpath_fix.patch
>
>   .../pseudo/pseudo/realpath_fix.patch               |    2 +-
>   meta/recipes-devtools/pseudo/pseudo_1.1.1.bb       |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>

Merged into OE-Core

Thanks
	Sau!