Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] dropbear: Change the path to find configuration file and add a configuration file for dropbear
@ 2011-08-31  2:48 Xiaofeng Yan
  2011-08-31  2:48 ` [PATCH 1/1] " Xiaofeng Yan
  0 siblings, 1 reply; 3+ messages in thread
From: Xiaofeng Yan @ 2011-08-31  2:48 UTC (permalink / raw)
  To: openembedded-core

From: Xiaofeng Yan <xiaofeng.yan@windriver.com>

Hi Richard,

I modify my fault. Please review it again. If have any suggestion. I will modify it again.

Thanks
Yan

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: xiaofeng/dropbear
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/dropbear

Thanks,
    Xiaofeng Yan <xiaofeng.yan@windriver.com>
---


Xiaofeng Yan (1):
  dropbear: Change the path to find configuration file and add a
    configuration file for dropbear

 meta/recipes-core/dropbear/dropbear.inc |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] dropbear: Change the path to find configuration file and add a configuration file for dropbear
  2011-08-31  2:48 [PATCH 0/1] dropbear: Change the path to find configuration file and add a configuration file for dropbear Xiaofeng Yan
@ 2011-08-31  2:48 ` Xiaofeng Yan
  2011-08-31 18:56   ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Xiaofeng Yan @ 2011-08-31  2:48 UTC (permalink / raw)
  To: openembedded-core

From: Xiaofeng Yan <xiaofeng.yan@windriver.com>

dropbear will check "/etc/pam.d/sshd" which comes from package "openssh" \
When enabling pam supporting. But if we only install dropbear \
package without package "openssh", then "dropbear" will not \
find a configuration file.
The changes are as follow for fixing this bug:

- Change the path to find configuration file (/etc/pam.d/sshd --> /etc/pam.d/dropbear)
- Add a configuration file "/etc/pam.d/dropbear"

Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
 meta/recipes-core/dropbear/dropbear.inc |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-core/dropbear/dropbear.inc b/meta/recipes-core/dropbear/dropbear.inc
index 5af9ebd..1582f2e 100644
--- a/meta/recipes-core/dropbear/dropbear.inc
+++ b/meta/recipes-core/dropbear/dropbear.inc
@@ -19,7 +19,9 @@ SRC_URI = "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.gz \
 	         file://init \
                  ${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)} "
 
-PAM_SRC_URI = "file://dropbear-enable-pam.patch"
+PAM_SRC_URI = "file://dropbear-enable-pam.patch \
+               file://dropbear-configuration-file.patch \
+               file://dropbear"
 
 inherit autotools update-rc.d
 
@@ -68,6 +70,14 @@ do_install() {
 				  -e 's,/usr/bin,${bindir},g' \
 				  -e 's,/usr,${prefix},g' > ${D}${sysconfdir}/init.d/dropbear
 	chmod 755 ${D}${sysconfdir}/init.d/dropbear
+	for i in ${DISTRO_FEATURES};
+	do
+		if [ ${i} = "pam" ];  then
+			install -d ${D}${sysconfdir}/pam.d
+			install -m 0644 ${WORKDIR}/dropbear  ${D}${sysconfdir}/pam.d/
+		fi
+	done
+
 }
 
 pkg_postinst_${PN} () {
-- 
1.7.0.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] dropbear: Change the path to find configuration file and add a configuration file for dropbear
  2011-08-31  2:48 ` [PATCH 1/1] " Xiaofeng Yan
@ 2011-08-31 18:56   ` Richard Purdie
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2011-08-31 18:56 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Wed, 2011-08-31 at 10:48 +0800, Xiaofeng Yan wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
> 
> dropbear will check "/etc/pam.d/sshd" which comes from package "openssh" \
> When enabling pam supporting. But if we only install dropbear \
> package without package "openssh", then "dropbear" will not \
> find a configuration file.
> The changes are as follow for fixing this bug:
> 
> - Change the path to find configuration file (/etc/pam.d/sshd --> /etc/pam.d/dropbear)
> - Add a configuration file "/etc/pam.d/dropbear"
> 
> Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
> ---
>  meta/recipes-core/dropbear/dropbear.inc |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-31 19:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-31  2:48 [PATCH 0/1] dropbear: Change the path to find configuration file and add a configuration file for dropbear Xiaofeng Yan
2011-08-31  2:48 ` [PATCH 1/1] " Xiaofeng Yan
2011-08-31 18:56   ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox