Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] Enable spaces in RPM packages
@ 2012-01-17 15:47 Mark Hatle
  2012-01-17 15:47 ` [PATCH 1/1] package_rpm.bbclass: Add support for filenames with spaces Mark Hatle
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Hatle @ 2012-01-17 15:47 UTC (permalink / raw)
  To: openembedded-core

RPM packages could not handle spaces in filenames, fix this.

The following changes since commit 7257ded5355ffdc0fc169e7f34daeedb0b3dcd78:

  busybox/uglibc: remove obsolete check for "kernel24" (2012-01-17 15:15:29 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib mhatle/rpm
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/rpm

Mark Hatle (1):
  package_rpm.bbclass: Add support for filenames with spaces

 meta/classes/package_rpm.bbclass |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.7.3.4




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] package_rpm.bbclass: Add support for filenames with spaces
  2012-01-17 15:47 [PATCH 0/1] Enable spaces in RPM packages Mark Hatle
@ 2012-01-17 15:47 ` Mark Hatle
  2012-01-17 17:10   ` Koen Kooi
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Hatle @ 2012-01-17 15:47 UTC (permalink / raw)
  To: openembedded-core

Files with spaces must be fully quoted in an RPM spec file.  It was
easier to quote all file paths, then to do it selectively.

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
 meta/classes/package_rpm.bbclass |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index 2d92efe..bac9de5 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -543,12 +543,12 @@ python write_specfile () {
 			path = rootpath.replace(walkpath, "")
 			for dir in dirs:
 				# All packages own the directories their files are in...
-				target.append("%dir " + path + "/" + dir)
+				target.append('%dir "' + path + '/' + dir + '"')
 			for file in files:
-				if conffiles.count(path + "/" + file):
-					target.append("%config " + path + "/" + file)
+				if conffiles.count(path + '/' + file):
+					target.append('%config "' + path + '/' + file + '"')
 				else:
-					target.append(path + "/" + file)
+					target.append('"' + path + '/' + file + '"')
 
 	# Prevent the prerm/postrm scripts from being run during an upgrade
 	def wrap_uninstall(scriptvar):
-- 
1.7.3.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] package_rpm.bbclass: Add support for filenames with spaces
  2012-01-17 15:47 ` [PATCH 1/1] package_rpm.bbclass: Add support for filenames with spaces Mark Hatle
@ 2012-01-17 17:10   ` Koen Kooi
  0 siblings, 0 replies; 3+ messages in thread
From: Koen Kooi @ 2012-01-17 17:10 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer


Op 17 jan. 2012, om 16:47 heeft Mark Hatle het volgende geschreven:

> Files with spaces must be fully quoted in an RPM spec file.  It was
> easier to quote all file paths, then to do it selectively.
> 
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>

Tested-by: Koen Kooi <koen@dominion.thruhere.net>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-17 17:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 15:47 [PATCH 0/1] Enable spaces in RPM packages Mark Hatle
2012-01-17 15:47 ` [PATCH 1/1] package_rpm.bbclass: Add support for filenames with spaces Mark Hatle
2012-01-17 17:10   ` Koen Kooi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox