Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1 V2] do not split debug pkg when no debugsources.list
@ 2012-03-14  7:16 Robert Yang
  2012-03-14  7:16 ` [PATCH 1/1 V2] package.bbclass: " Robert Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Yang @ 2012-03-14  7:16 UTC (permalink / raw)
  To: openembedded-core

Changes of V2:

* Do not split debug pkg when no debugsources.list rather than create an
  empty debugsources.list as Richard suggested.

// Robert

The following changes since commit 81379dc141e245307ca391a02b7490b199128991:

  dates: Fix unpackaged files warning (2012-03-13 23:18:19 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib robert/debugpkg
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/debugpkg

Robert Yang (1):
  package.bbclass: do not split debug pkg when no debugsources.list

 meta/classes/package.bbclass |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

-- 
1.7.4.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1 V2] package.bbclass: do not split debug pkg when no debugsources.list
  2012-03-14  7:16 [PATCH 0/1 V2] do not split debug pkg when no debugsources.list Robert Yang
@ 2012-03-14  7:16 ` Robert Yang
  2012-03-14 13:29   ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Yang @ 2012-03-14  7:16 UTC (permalink / raw)
  To: openembedded-core

We don't have to split the debug pkg if it is null (No debugsources.list
since the find-debuginfo.sh would not generate it for the null pkg).

Serval pkg's debug pkg is null, and there were a few errors: (53 pkgs
had such errors in a core-image-sato build):

log.do_package:sort: open failed: debugsources.list: No such file or directory

[YOCTO #2076]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/package.bbclass |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 7bcfa02..bdc4d37 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -234,17 +234,17 @@ def splitfile2(debugsrcdir, d):
 
     import commands, stat
 
-    dvar = d.getVar('PKGD', True)
-    pathprefix = "export PATH=%s; " % d.getVar('PATH', True)
-    strip = d.getVar("STRIP", True)
-    objcopy = d.getVar("OBJCOPY", True)
-    debugedit = d.expand("${STAGING_LIBDIR_NATIVE}/rpm/bin/debugedit")
-    workdir = d.getVar("WORKDIR", True)
-    workparentdir = os.path.dirname(workdir)
-    workbasedir = os.path.basename(workdir)
     sourcefile = d.expand("${WORKDIR}/debugsources.list")
+    if debugsrcdir and os.path.isfile(sourcefile):
+       dvar = d.getVar('PKGD', True)
+       pathprefix = "export PATH=%s; " % d.getVar('PATH', True)
+       strip = d.getVar("STRIP", True)
+       objcopy = d.getVar("OBJCOPY", True)
+       debugedit = d.expand("${STAGING_LIBDIR_NATIVE}/rpm/bin/debugedit")
+       workdir = d.getVar("WORKDIR", True)
+       workparentdir = os.path.dirname(workdir)
+       workbasedir = os.path.basename(workdir)
 
-    if debugsrcdir:
        nosuchdir = []
        basepath = dvar
        for p in debugsrcdir.split("/"):
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1 V2] package.bbclass: do not split debug pkg when no debugsources.list
  2012-03-14  7:16 ` [PATCH 1/1 V2] package.bbclass: " Robert Yang
@ 2012-03-14 13:29   ` Richard Purdie
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2012-03-14 13:29 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Wed, 2012-03-14 at 15:16 +0800, Robert Yang wrote:
> We don't have to split the debug pkg if it is null (No debugsources.list
> since the find-debuginfo.sh would not generate it for the null pkg).
> 
> Serval pkg's debug pkg is null, and there were a few errors: (53 pkgs
> had such errors in a core-image-sato build):
> 
> log.do_package:sort: open failed: debugsources.list: No such file or directory
> 
> [YOCTO #2076]
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/package.bbclass |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-14 13:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14  7:16 [PATCH 0/1 V2] do not split debug pkg when no debugsources.list Robert Yang
2012-03-14  7:16 ` [PATCH 1/1 V2] package.bbclass: " Robert Yang
2012-03-14 13:29   ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox