Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/2] Allow Hob to run with sanity checks disabled
@ 2012-04-23 21:36 Joshua Lock
  2012-04-23 21:36 ` [PATCH 1/2] sanity.bbclass: add variable to disable the sanity checks Joshua Lock
  2012-04-23 21:36 ` [PATCH 2/2] scripts/hob: disable sanity checks when launching Joshua Lock
  0 siblings, 2 replies; 3+ messages in thread
From: Joshua Lock @ 2012-04-23 21:36 UTC (permalink / raw)
  To: openembedded-core

Currently sanity check failures prevent Hob from launching, however we want
users to be able to change the various sanity failure causing settings - such
as proxy configuration - from the GUI.

This change and a related set of changes to BitBake allow Hob to start with the
sanity checks disabled and enable them once the GUI is in place to a) report
errors and b) affect settings.

In tandem with an BitBake change fixes [YOCTO #2361].

Regards,

Joshua

The following changes since commit b19af63a201933038a044f29570710fe38365f28:

  self-hosted-image: Update poky revision to point at the 1.2 release branch (2012-04-22 16:07:44 +0100)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib josh/hob
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/hob

Joshua Lock (2):
  sanity.bbclass: add variable to disable the sanity checks
  scripts/hob: disable sanity checks when launching

 meta/classes/sanity.bbclass |    2 +-
 scripts/hob                 |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
1.7.7.6




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] sanity.bbclass: add variable to disable the sanity checks
  2012-04-23 21:36 [PATCH 0/2] Allow Hob to run with sanity checks disabled Joshua Lock
@ 2012-04-23 21:36 ` Joshua Lock
  2012-04-23 21:36 ` [PATCH 2/2] scripts/hob: disable sanity checks when launching Joshua Lock
  1 sibling, 0 replies; 3+ messages in thread
From: Joshua Lock @ 2012-04-23 21:36 UTC (permalink / raw)
  To: openembedded-core

It's useful for Hob to be able to disable the sanity checks completely
without marking them as passed so that the user can get into the GUI to
configure their settings, etc.

Add a variable, DISABLE_SANITY_CHECKS, to do so.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 9cd04c4..c3d4e58 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -453,7 +453,7 @@ def check_sanity(e):
 
 addhandler check_sanity_eventhandler
 python check_sanity_eventhandler() {
-    if bb.event.getName(e) == "ConfigParsed" and e.data.getVar("BB_WORKERCONTEXT", True) != "1":
+    if bb.event.getName(e) == "ConfigParsed" and e.data.getVar("BB_WORKERCONTEXT", True) != "1" and e.data.getVar("DISABLE_SANITY_CHECKS", True) != "1":
         check_sanity(e)
 
     return
-- 
1.7.7.6




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] scripts/hob: disable sanity checks when launching
  2012-04-23 21:36 [PATCH 0/2] Allow Hob to run with sanity checks disabled Joshua Lock
  2012-04-23 21:36 ` [PATCH 1/2] sanity.bbclass: add variable to disable the sanity checks Joshua Lock
@ 2012-04-23 21:36 ` Joshua Lock
  1 sibling, 0 replies; 3+ messages in thread
From: Joshua Lock @ 2012-04-23 21:36 UTC (permalink / raw)
  To: openembedded-core

This enables us to use the GUI to change any settings which might cause
sanity checks to fail, such as the proxy configuration.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 scripts/hob |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/hob b/scripts/hob
index ee80cb3..4a821cb 100755
--- a/scripts/hob
+++ b/scripts/hob
@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-bitbake -u hob
+export BB_ENV_EXTRAWHITE="DISABLE_SANITY_CHECKS $BB_ENV_EXTRAWHITE"
+DISABLE_SANITY_CHECKS=1 bitbake -u hob
 
 ret=$?
 exit $ret
-- 
1.7.7.6




^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-23 21:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23 21:36 [PATCH 0/2] Allow Hob to run with sanity checks disabled Joshua Lock
2012-04-23 21:36 ` [PATCH 1/2] sanity.bbclass: add variable to disable the sanity checks Joshua Lock
2012-04-23 21:36 ` [PATCH 2/2] scripts/hob: disable sanity checks when launching Joshua Lock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox