* [PATCH 0/2] v2 Import the blacklist functionality from meta-oe @ 2012-05-09 20:00 Mark Hatle 2012-05-09 20:00 ` [PATCH 1/2] blacklist: fix typo in name Mark Hatle 2012-05-09 20:00 ` [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] Mark Hatle 0 siblings, 2 replies; 5+ messages in thread From: Mark Hatle @ 2012-05-09 20:00 UTC (permalink / raw) To: openembedded-core Refactor from v1. Include the original functionality from meta-oe, it has been changed based on comments both on the list and off. And I believe greatly simplified. It is expected that distributions who need the old functionality may continue to use the old blacklist.bbclass in their layers. One additional note, I had people ask why I need this functionality. The issue is that we intend to use OE-Core release almost exactly as-is. But we have to sent reasonable support boundries for our customers. This will allow us to declare certain items as unsupported, and if the end user wishes to clear the blacklist they can. The following changes since commit 043871d7e5d2d19c2ff43e54d2ff180c09e8903e: kern-tools: integrate minor fixes (2012-05-08 16:06:15 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib mhatle/blacklist http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/blacklist Mark Hatle (2): blacklist: fix typo in name blacklist.bbclass: Refactor, use PNBLACKLIST[pn] meta/classes/blacklist.bbclass | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 meta/classes/blacklist.bbclass -- 1.7.3.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] blacklist: fix typo in name 2012-05-09 20:00 [PATCH 0/2] v2 Import the blacklist functionality from meta-oe Mark Hatle @ 2012-05-09 20:00 ` Mark Hatle 2012-05-09 20:00 ` [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] Mark Hatle 1 sibling, 0 replies; 5+ messages in thread From: Mark Hatle @ 2012-05-09 20:00 UTC (permalink / raw) To: openembedded-core Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Import directly from meta-openembedded commit: a63c374cdc785ade69d2998978d08280e671dc1f Signed-off-by: Mark Hatle <mark.hatle@windriver.com> --- meta/classes/blacklist.bbclass | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 meta/classes/blacklist.bbclass diff --git a/meta/classes/blacklist.bbclass b/meta/classes/blacklist.bbclass new file mode 100644 index 0000000..7bf4a73 --- /dev/null +++ b/meta/classes/blacklist.bbclass @@ -0,0 +1,20 @@ +# anonymous support class from angstrom +# +# Features: +# +# * blacklist handling, set ANGSTROM_BLACKLIST_pn-blah = "message" +# + +python () { + import bb + + blacklist = bb.data.getVar("ANGSTROM_BLACKLIST", d, 1) + pkgnm = bb.data.getVar("PN", d, 1) + distro = bb.data.getVar("DISTRO", d, 1) + + if blacklist: + bb.note("%s DOES NOT support %s because %s" % (distro,pkgnm, blacklist)) + raise bb.parse.SkipPackage("%s DOES NOT support %s because %s" % (distro,pkgnm, blacklist)) + +} + -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] 2012-05-09 20:00 [PATCH 0/2] v2 Import the blacklist functionality from meta-oe Mark Hatle 2012-05-09 20:00 ` [PATCH 1/2] blacklist: fix typo in name Mark Hatle @ 2012-05-09 20:00 ` Mark Hatle 2012-05-09 20:45 ` Koen Kooi 1 sibling, 1 reply; 5+ messages in thread From: Mark Hatle @ 2012-05-09 20:00 UTC (permalink / raw) To: openembedded-core Revise the handling from ANGSTROM_BLACKLIST to PNBLACKLIST[pn]. Refactor the code to eliminate references to the distribution and recipe name in the message. Change the skipPackage message message from: ERROR: <recipe> was skipped: <distro> DOES NOT support <recipe> because <reason> to: ERROR: <recipe> was skipped: Recipe is blacklisted: <reason> Signed-off-by: Mark Hatle <mark.hatle@windriver.com> --- meta/classes/blacklist.bbclass | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/meta/classes/blacklist.bbclass b/meta/classes/blacklist.bbclass index 7bf4a73..75abd99 100644 --- a/meta/classes/blacklist.bbclass +++ b/meta/classes/blacklist.bbclass @@ -1,20 +1,20 @@ -# anonymous support class from angstrom +# anonymous support class from originally from angstrom # +# To use the blacklist, a distribution should include this +# class in the INHERIT_DISTRO +# +# No longer use ANGSTROM_BLACKLIST, instead use a table of +# recipes in PNBLACKLIST +# # Features: # -# * blacklist handling, set ANGSTROM_BLACKLIST_pn-blah = "message" +# * To add a package to the blacklist, set: +# PNBLACKLIST[pn] = "message" # python () { - import bb - - blacklist = bb.data.getVar("ANGSTROM_BLACKLIST", d, 1) - pkgnm = bb.data.getVar("PN", d, 1) - distro = bb.data.getVar("DISTRO", d, 1) + blacklist = d.getVarFlag('PNBLACKLIST', d.getVar('PN', True), True) if blacklist: - bb.note("%s DOES NOT support %s because %s" % (distro,pkgnm, blacklist)) - raise bb.parse.SkipPackage("%s DOES NOT support %s because %s" % (distro,pkgnm, blacklist)) - + raise bb.parse.SkipPackage("Recipe is blacklisted: %s" % (blacklist)) } - -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] 2012-05-09 20:00 ` [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] Mark Hatle @ 2012-05-09 20:45 ` Koen Kooi 2012-05-09 21:16 ` Mark Hatle 0 siblings, 1 reply; 5+ messages in thread From: Koen Kooi @ 2012-05-09 20:45 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Op 9 mei 2012, om 22:00 heeft Mark Hatle het volgende geschreven: > Revise the handling from ANGSTROM_BLACKLIST to PNBLACKLIST[pn]. > > Refactor the code to eliminate references to the distribution and recipe > name in the message. > > Change the skipPackage message message from: > > ERROR: <recipe> was skipped: <distro> DOES NOT support <recipe> because <reason> > > to: > > ERROR: <recipe> was skipped: Recipe is blacklisted: <reason> > > Signed-off-by: Mark Hatle <mark.hatle@windriver.com> > --- > meta/classes/blacklist.bbclass | 22 +++++++++++----------- > 1 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/meta/classes/blacklist.bbclass b/meta/classes/blacklist.bbclass > index 7bf4a73..75abd99 100644 > --- a/meta/classes/blacklist.bbclass > +++ b/meta/classes/blacklist.bbclass > @@ -1,20 +1,20 @@ > -# anonymous support class from angstrom > +# anonymous support class from originally from angstrom > # > +# To use the blacklist, a distribution should include this > +# class in the INHERIT_DISTRO INHERIT works just fine as well ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] 2012-05-09 20:45 ` Koen Kooi @ 2012-05-09 21:16 ` Mark Hatle 0 siblings, 0 replies; 5+ messages in thread From: Mark Hatle @ 2012-05-09 21:16 UTC (permalink / raw) To: openembedded-core On 5/9/12 3:45 PM, Koen Kooi wrote: > > Op 9 mei 2012, om 22:00 heeft Mark Hatle het volgende geschreven: > >> Revise the handling from ANGSTROM_BLACKLIST to PNBLACKLIST[pn]. >> >> Refactor the code to eliminate references to the distribution and recipe >> name in the message. >> >> Change the skipPackage message message from: >> >> ERROR:<recipe> was skipped:<distro> DOES NOT support<recipe> because<reason> >> >> to: >> >> ERROR:<recipe> was skipped: Recipe is blacklisted:<reason> >> >> Signed-off-by: Mark Hatle<mark.hatle@windriver.com> >> --- >> meta/classes/blacklist.bbclass | 22 +++++++++++----------- >> 1 files changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/meta/classes/blacklist.bbclass b/meta/classes/blacklist.bbclass >> index 7bf4a73..75abd99 100644 >> --- a/meta/classes/blacklist.bbclass >> +++ b/meta/classes/blacklist.bbclass >> @@ -1,20 +1,20 @@ >> -# anonymous support class from angstrom >> +# anonymous support class from originally from angstrom >> # >> +# To use the blacklist, a distribution should include this >> +# class in the INHERIT_DISTRO > > INHERIT works just fine as well Happy to change the comment, but my intention was that a blacklist is specified by a distribution, thus the inherit_distro comment. --Mark > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-09 21:26 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-09 20:00 [PATCH 0/2] v2 Import the blacklist functionality from meta-oe Mark Hatle 2012-05-09 20:00 ` [PATCH 1/2] blacklist: fix typo in name Mark Hatle 2012-05-09 20:00 ` [PATCH 2/2 v2] blacklist.bbclass: Refactor, use PNBLACKLIST[pn] Mark Hatle 2012-05-09 20:45 ` Koen Kooi 2012-05-09 21:16 ` Mark Hatle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox