* [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment
@ 2012-05-11 10:13 xiaofeng.yan
2012-05-11 10:13 ` [PATCH 1/1] archiver.bbclass: Add default set xiaofeng.yan
0 siblings, 1 reply; 6+ messages in thread
From: xiaofeng.yan @ 2012-05-11 10:13 UTC (permalink / raw)
To: openembedded-core
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
Add two default set(SOURCE_ARCHIVE_LOG_WITH_SCRIPTS, SOURCE_ARCHIVE_PACKAGE_TYPE) to archiver.bbclass for avoiding building error when forgetting to assign to them.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/archiver
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/archiver
Thanks,
Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
Xiaofeng Yan (1):
archiver.bbclass: Add default set
meta/classes/archiver.bbclass | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] archiver.bbclass: Add default set
2012-05-11 10:13 [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment xiaofeng.yan
@ 2012-05-11 10:13 ` xiaofeng.yan
2012-05-11 14:14 ` Chris Larson
0 siblings, 1 reply; 6+ messages in thread
From: xiaofeng.yan @ 2012-05-11 10:13 UTC (permalink / raw)
To: openembedded-core
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
Add two default set(SOURCE_ARCHIVE_LOG_WITH_SCRIPTS, \
SOURCE_ARCHIVE_PACKAGE_TYPE) to archiver.bbclass for avoiding \
building error when forgetting to assign to them.
Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
meta/classes/archiver.bbclass | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
index 59b58f4..a720db2 100644
--- a/meta/classes/archiver.bbclass
+++ b/meta/classes/archiver.bbclass
@@ -6,6 +6,10 @@ ARCHIVE_EXCLUDE_FROM ?= ".pc autom4te.cache"
ARCHIVE_TYPE ?= "TAR SRPM"
DISTRO ?= "poky"
PATCHES_ARCHIVE_WITH_SERIES = 'TRUE'
+SOURCE_ARCHIVE_LOG_WITH_SCRIPTS ?= 'logs_with_scripts'
+SOURCE_ARCHIVE_PACKAGE_TYPE ?= 'tar'
+export SOURCE_ARCHIVE_LOG_WITH_SCRIPTS
+export SOURCE_ARCHIVE_PACKAGE_TYPE
def get_bb_inc(d):
'''create a directory "script-logs" including .bb and .inc file in ${WORKDIR}'''
@@ -277,7 +281,7 @@ def get_package(d):
try:
f = open(tarpackage,'r')
line = list(set(f.readline().replace('\n','').split()))
- except IOError:
+ except UnboundLocalError,IOError:
pass
f.close()
return line
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] archiver.bbclass: Add default set
2012-05-11 10:13 ` [PATCH 1/1] archiver.bbclass: Add default set xiaofeng.yan
@ 2012-05-11 14:14 ` Chris Larson
2012-05-14 7:54 ` Xiaofeng Yan
0 siblings, 1 reply; 6+ messages in thread
From: Chris Larson @ 2012-05-11 14:14 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, May 11, 2012 at 3:13 AM, <xiaofeng.yan@windriver.com> wrote:
> diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
> index 59b58f4..a720db2 100644
> --- a/meta/classes/archiver.bbclass
> +++ b/meta/classes/archiver.bbclass
> @@ -6,6 +6,10 @@ ARCHIVE_EXCLUDE_FROM ?= ".pc autom4te.cache"
> ARCHIVE_TYPE ?= "TAR SRPM"
> DISTRO ?= "poky"
> PATCHES_ARCHIVE_WITH_SERIES = 'TRUE'
> +SOURCE_ARCHIVE_LOG_WITH_SCRIPTS ?= 'logs_with_scripts'
> +SOURCE_ARCHIVE_PACKAGE_TYPE ?= 'tar'
> +export SOURCE_ARCHIVE_LOG_WITH_SCRIPTS
> +export SOURCE_ARCHIVE_PACKAGE_TYPE
I don't think you understand what 'export' does or why it exists.
Please fix that, and remove these lines. Thanks.
--
Christopher Larson
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] archiver.bbclass: Add default set
2012-05-11 14:14 ` Chris Larson
@ 2012-05-14 7:54 ` Xiaofeng Yan
0 siblings, 0 replies; 6+ messages in thread
From: Xiaofeng Yan @ 2012-05-14 7:54 UTC (permalink / raw)
To: openembedded-core
On 2012年05月11日 22:14, Chris Larson wrote:
> On Fri, May 11, 2012 at 3:13 AM,<xiaofeng.yan@windriver.com> wrote:
>> diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
>> index 59b58f4..a720db2 100644
>> --- a/meta/classes/archiver.bbclass
>> +++ b/meta/classes/archiver.bbclass
>> @@ -6,6 +6,10 @@ ARCHIVE_EXCLUDE_FROM ?= ".pc autom4te.cache"
>> ARCHIVE_TYPE ?= "TAR SRPM"
>> DISTRO ?= "poky"
>> PATCHES_ARCHIVE_WITH_SERIES = 'TRUE'
>> +SOURCE_ARCHIVE_LOG_WITH_SCRIPTS ?= 'logs_with_scripts'
>> +SOURCE_ARCHIVE_PACKAGE_TYPE ?= 'tar'
>> +export SOURCE_ARCHIVE_LOG_WITH_SCRIPTS
>> +export SOURCE_ARCHIVE_PACKAGE_TYPE
> I don't think you understand what 'export' does or why it exists.
> Please fix that, and remove these lines. Thanks.
Hi Chris Larson,
Thanks for your review. I am testing this according to your
suggestion and put it to OE-core after test.
Thanks
Yan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment
@ 2012-05-16 8:59 xiaofeng.yan
2012-05-18 5:41 ` Saul Wold
0 siblings, 1 reply; 6+ messages in thread
From: xiaofeng.yan @ 2012-05-16 8:59 UTC (permalink / raw)
To: openembedded-core; +Cc: Zhenfeng.Zhao
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
This is V2.
Add two default set(SOURCE_ARCHIVE_LOG_WITH_SCRIPTS, SOURCE_ARCHIVE_PACKAGE_TYPE) to archiver.bbclass for avoiding building error when forgetting to assign to them.
Make some modification according to clarson's suggestion. Thank him correct my fault.
The following changes since commit d4e265661517f8dd4e1648fdc56bac5973f986f6:
Saul Wold (1):
poky.conf: Change WARNS -> ERRORS
are available in the git repository at:
git://git.pokylinux.org/poky-contrib xiaofeng/archiver
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/archiver
Xiaofeng Yan (1):
archiver.bbclass: Add two default set for avoiding error when missing
assignment
meta/classes/archiver.bbclass | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment
2012-05-16 8:59 [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment xiaofeng.yan
@ 2012-05-18 5:41 ` Saul Wold
0 siblings, 0 replies; 6+ messages in thread
From: Saul Wold @ 2012-05-18 5:41 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Zhenfeng.Zhao
On 05/16/2012 11:59 AM, xiaofeng.yan@windriver.com wrote:
> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>
> This is V2.
>
> Add two default set(SOURCE_ARCHIVE_LOG_WITH_SCRIPTS, SOURCE_ARCHIVE_PACKAGE_TYPE) to archiver.bbclass for avoiding building error when forgetting to assign to them.
> Make some modification according to clarson's suggestion. Thank him correct my fault.
>
> The following changes since commit d4e265661517f8dd4e1648fdc56bac5973f986f6:
> Saul Wold (1):
> poky.conf: Change WARNS -> ERRORS
>
> are available in the git repository at:
>
> git://git.pokylinux.org/poky-contrib xiaofeng/archiver
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/archiver
>
> Xiaofeng Yan (1):
> archiver.bbclass: Add two default set for avoiding error when missing
> assignment
>
> meta/classes/archiver.bbclass | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-18 5:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 10:13 [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment xiaofeng.yan
2012-05-11 10:13 ` [PATCH 1/1] archiver.bbclass: Add default set xiaofeng.yan
2012-05-11 14:14 ` Chris Larson
2012-05-14 7:54 ` Xiaofeng Yan
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 8:59 [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment xiaofeng.yan
2012-05-18 5:41 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox