Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] send-pull-request: Make -a really imply -c
@ 2012-08-01 19:18 Darren Hart
  2012-08-01 19:18 ` [PATCH 1/1] " Darren Hart
  0 siblings, 1 reply; 2+ messages in thread
From: Darren Hart @ 2012-08-01 19:18 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit 674d65c94478a1ff33ef9d9c1e49f677091301f4:

  imagetest-qemu.bbclass: Fix whitespace issues (2012-08-01 09:08:25 +0100)

are available in the git repository at:
  git://git.yoctoproject.org/user-contrib/dvhart/oe-core pullrequest
  http://git.yoctoproject.org/cgit.cgi/user-contrib/dvhart/oe-core/log/?h=pullrequest

Darren Hart (1):
  send-pull-request: Make -a really imply -c

 scripts/send-pull-request |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.5.4




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] send-pull-request: Make -a really imply -c
  2012-08-01 19:18 [PATCH 0/1] send-pull-request: Make -a really imply -c Darren Hart
@ 2012-08-01 19:18 ` Darren Hart
  0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2012-08-01 19:18 UTC (permalink / raw)
  To: openembedded-core

The switch statement does not fall through as the comment suggests.
This results in -a not implying -c as was intended.

Add the two lines from -c to -a to achieve the intended behavior.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 scripts/send-pull-request |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/send-pull-request b/scripts/send-pull-request
index 09f4245..18a53c4 100755
--- a/scripts/send-pull-request
+++ b/scripts/send-pull-request
@@ -71,8 +71,9 @@ harvest_recipients()
 while getopts "achp:t:" OPT; do
 	case $OPT in
 	a)
+		AUTO=1
+		GITSOBCC="--signed-off-by-cc"
 		AUTO_CL=1
-		# Fall through to include -c
 		;;
 	c)
 		AUTO=1
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-01 19:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-01 19:18 [PATCH 0/1] send-pull-request: Make -a really imply -c Darren Hart
2012-08-01 19:18 ` [PATCH 1/1] " Darren Hart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox