[PATCH 0/1] Add unique identifier to screen calls

[PATCH 0/1] Add unique identifier to screen calls

[Mark Hatle]

The following changes since commit 968cfc0b630fb409430a46b1512d6bf0de225ad1:

  build-appliance-image: Add vmx* files and build zip file (2012-08-24 17:32:34 +0100)

are available in the git repository at:
  git://git.yoctoproject.org/poky-contrib mhatle/devshell
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mhatle/devshell

Jason Wessel (1):
  terminal.py: use unique ids for screen sessions

 meta/lib/oe/terminal.py |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

-- 
1.7.3.4

[PATCH 1/1] terminal.py: use unique ids for screen sessions

[Mark Hatle]

From: Jason Wessel <jason.wessel@windriver.com>

When running multiple sets of builds on the same
system, it is hard to distinguish which build belongs
to which screen session and you can end up resuming
the wrong session.

The simple solution is to just append the process
id to the screen session invocation to make each
unique.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
 meta/lib/oe/terminal.py |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 3131798..30e8f92 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -94,9 +94,11 @@ class Screen(Terminal):
     command = 'screen -D -m -t "{title}" -S devshell {command}'
 
     def __init__(self, sh_cmd, title=None, env=None):
+        s_id = "devshell_%i" % os.getpid()
+        self.command = "screen -D -m -t \"{title}\" -S %s {command}" % s_id
         Terminal.__init__(self, sh_cmd, title, env)
         logger.warn('Screen started. Please connect in another terminal with '
-                    '"screen -r devshell"')
+                    '"screen -r devshell %s"' % s_id)
 
 
 def prioritized():
-- 
1.7.3.4

Re: [PATCH 0/1] Add unique identifier to screen calls

[Saul Wold]

On 08/24/2012 12:23 PM, Mark Hatle wrote:
> The following changes since commit 968cfc0b630fb409430a46b1512d6bf0de225ad1:
>
>    build-appliance-image: Add vmx* files and build zip file (2012-08-24 17:32:34 +0100)
>
> are available in the git repository at:
>    git://git.yoctoproject.org/poky-contrib mhatle/devshell
>    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mhatle/devshell
>
> Jason Wessel (1):
>    terminal.py: use unique ids for screen sessions
>
>   meta/lib/oe/terminal.py |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
Merged into OE-Core

Thanks
	Sau!