Openembedded Core Discussions
 help / color / mirror / Atom feed
* [denzil][PATCH 0/1] menuconfig fix for denzil
@ 2012-09-24 15:26 Paul Eggleton
  2012-09-24 15:26 ` [denzil][PATCH 1/1] classes/cml1: ensure -c menuconfig forces a rebuild next time Paul Eggleton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2012-09-24 15:26 UTC (permalink / raw)
  To: Scott Garman, openembedded-core

Note that as noted in the patch this relies upon the task tainting
feature in bitbake; this will do nothing with versions of bitbake that
do not have that feature.


The following changes since commit 95756cfbb7a9348b23cb46a49a5509e57e973faf:

  valgrind: fix default.supp missing issue (2012-08-21 11:19:26 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib paule/denzil-force-oecore
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/denzil-force-oecore

Paul Eggleton (1):
  classes/cml1: ensure -c menuconfig forces a rebuild next time

 meta/classes/cml1.bbclass |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

-- 
1.7.9.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [denzil][PATCH 1/1] classes/cml1: ensure -c menuconfig forces a rebuild next time
  2012-09-24 15:26 [denzil][PATCH 0/1] menuconfig fix for denzil Paul Eggleton
@ 2012-09-24 15:26 ` Paul Eggleton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2012-09-24 15:26 UTC (permalink / raw)
  To: Scott Garman, openembedded-core

Ensure the following results in the kernel being rebuilt, repackaged and
re-deployed in the final step:

bitbake virtual/kernel
bitbake -c menuconfig virtual/kernel
[ make changes to the kernel configuration and save ]
bitbake virtual/kernel

If there are no changes to the configuration saved, the rebuild will not
be triggered.

Note that this relies on a function recently added to BitBake and
requires full hashing (i.e. BB_SIGNATURE_HANDLER must be set to a
signature handler that inherits from BasicHash) - if this is not the
case or the function is not available in the version of BitBake being
used this change will do nothing.

Fixes [YOCTO #2256].

(From OE-Core rev: 9bf6b60e1599cf5dd87089d42584583cdfd6807a)

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/cml1.bbclass |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index d429188..678d23c 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -10,7 +10,23 @@ addtask configure after do_unpack do_patch before do_compile
 inherit terminal
 
 python do_menuconfig() {
+        try:
+            mtime = os.path.getmtime(".config")
+        except OSError:
+            mtime = 0
+
         oe_terminal("make menuconfig", '${PN} Configuration', d)
+
+        # FIXME this check can be removed when the minimum bitbake version has been bumped
+        if hasattr(bb.build, 'write_taint'):
+            try:
+                newmtime = os.path.getmtime(".config")
+            except OSError:
+                newmtime = 0
+
+            if newmtime > mtime:
+                bb.note("Configuration changed, recompile will be forced")
+                bb.build.write_taint('do_compile', d)
 }
 do_menuconfig[nostamp] = "1"
 addtask menuconfig after do_configure
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-24 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-24 15:26 [denzil][PATCH 0/1] menuconfig fix for denzil Paul Eggleton
2012-09-24 15:26 ` [denzil][PATCH 1/1] classes/cml1: ensure -c menuconfig forces a rebuild next time Paul Eggleton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox