Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2 0/1] eglibc: always compile with optimization.
@ 2012-11-15  5:19 jackie.huang
  2012-11-15  5:19 ` [PATCH v2 1/1] " jackie.huang
  0 siblings, 1 reply; 2+ messages in thread
From: jackie.huang @ 2012-11-15  5:19 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jackie.Huang, Zhenfeng.Zhao

From: Jackie Huang <jackie.huang@windriver.com>

* Test info:
1) MACHINE=qemux86-64/qemuppc/qemumips
$ bitbake core-image-sato 
$ bitbake eglibc

2) MACHINE=qemux86-64/qemuppc/qemumips
   DEBUG_OPTIMIZATION = "-O0 -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
   DEBUG_BUILD = "1" or SELECTED_OPTIMIZATION = "${DEBUG_OPTIMIZATION}"
$ bitbake core-image-sato
$ bitbake eglibc


The following changes since commit 5e4714a454f9f742bf8af70dad2aa66ccb87e3fd:

  lib/oe/classextend: Ensure we don't extend expressions more than once (2012-11-06 09:29:03 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib jhuang0/d_eglibc_1114_1
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/d_eglibc_1114_1

Jackie Huang (1):
  eglibc: always compile with optimization.

 meta/recipes-core/eglibc/eglibc_2.16.bb |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

-- 
1.7.4




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2 1/1] eglibc: always compile with optimization.
  2012-11-15  5:19 [PATCH v2 0/1] eglibc: always compile with optimization jackie.huang
@ 2012-11-15  5:19 ` jackie.huang
  0 siblings, 0 replies; 2+ messages in thread
From: jackie.huang @ 2012-11-15  5:19 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jackie.Huang, Zhenfeng.Zhao

From: Jackie Huang <jackie.huang@windriver.com>

eglibc fails to compile if someone tries to compile an entire image as -O0:
error "glibc cannot be compiled without optimization"
so in this case, force to use -O2 and give a note about it.

[YOCTO #3405]

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-core/eglibc/eglibc_2.16.bb |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/meta/recipes-core/eglibc/eglibc_2.16.bb b/meta/recipes-core/eglibc/eglibc_2.16.bb
index aa9256c..71bcc30 100644
--- a/meta/recipes-core/eglibc/eglibc_2.16.bb
+++ b/meta/recipes-core/eglibc/eglibc_2.16.bb
@@ -87,6 +87,17 @@ EXTRA_OECONF = "--enable-kernel=${OLDEST_KERNEL} \
 
 EXTRA_OECONF += "${@get_libc_fpu_setting(bb, d)}"
 
+# eglibc can't be built without optimization, if someone tries to compile an
+# entire image as -O0, we override it with -O2 here and give a note about it.
+def get_optimization(d):
+    selected_optimization = d.getVar("SELECTED_OPTIMIZATION", True)
+    if base_contains("SELECTED_OPTIMIZATION", "-O0", "x", "", d) == "x":
+        bb.note("eglibc can't be built with -O0, -O2 will be used instead.")
+        return selected_optimization.replace("-O0", "-O2")
+    return selected_optimization
+
+SELECTED_OPTIMIZATION := "${@get_optimization(d)}"
+
 do_unpack_append() {
     bb.build.exec_func('do_move_ports', d)
 }
-- 
1.7.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-15  5:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-15  5:19 [PATCH v2 0/1] eglibc: always compile with optimization jackie.huang
2012-11-15  5:19 ` [PATCH v2 1/1] " jackie.huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox