[PATCH 0/2] Remove GUPnP

[PATCH 0/2] Remove GUPnP

[Ross Burton]

Hi,

GUPnP is great, but it's untested in oe-core.  It's now in meta-multimedia where
it's been upgraded and live alongside companion projects such as dLeyna and
Rygel.

Ross

The following changes since commit ae118de9a0356ab631eb3024f55b1784fa54e437:

  systemd: remove unused SERIAL_CONSOLE variable (2013-01-21 15:22:36 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ross/dleyna

for you to fetch changes up to 17d63fe6f27fbf6719b3c6d7344ba896e6b45a58:

  packagegroup-sdk-gmae: remove GUPnP stack as it's no longer in oe-core (2013-01-21 15:27:11 +0000)

----------------------------------------------------------------
Ross Burton (2):
      gupnp: remove, migrated to meta-multimedia
      packagegroup-sdk-gmae: remove GUPnP stack as it's no longer in oe-core

 meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb    |   23 ----------------
 meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb  |   15 -----------
 .../gupnp/gupnp-tools_0.8.1.bb                     |   14 ----------
 meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb    |   28 --------------------
 .../packagegroups/packagegroup-sdk-gmae.inc        |    4 ---
 5 files changed, 84 deletions(-)
 delete mode 100644 meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp-tools_0.8.1.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb

Ross Burton (2):
  gupnp: remove, migrated to meta-multimedia
  packagegroup-sdk-gmae: remove GUPnP stack as it's no longer in
    oe-core

 meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb    |   23 ----------------
 meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb  |   15 -----------
 .../gupnp/gupnp-tools_0.8.1.bb                     |   14 ----------
 meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb    |   28 --------------------
 .../packagegroups/packagegroup-sdk-gmae.inc        |    4 ---
 5 files changed, 84 deletions(-)
 delete mode 100644 meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp-tools_0.8.1.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb

-- 
1.7.10.4

[PATCH 1/2] gupnp: remove, migrated to meta-multimedia

[Ross Burton]

The GUPnP stack was stagnating in oe-core and untested.  It's now moved to
meta-multimedia where it's also been upgraded.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb    |   23 ----------------
 meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb  |   15 -----------
 .../gupnp/gupnp-tools_0.8.1.bb                     |   14 ----------
 meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb    |   28 --------------------
 4 files changed, 80 deletions(-)
 delete mode 100644 meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp-tools_0.8.1.bb
 delete mode 100644 meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb

diff --git a/meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb b/meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb
deleted file mode 100644
index 9dc05e5..0000000
--- a/meta/recipes-connectivity/gupnp/gssdp_0.10.0.bb
+++ /dev/null
@@ -1,23 +0,0 @@
-SUMMARY = "Resource discovery and announcement over SSDP"
-DESCRIPTION = "GSSDP implements resource discovery and announcement over SSDP (Simpe Service Discovery Protocol)."
-LICENSE = "LGPLv2"
-LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7"
-DEPENDS = "glib-2.0 libsoup-2.4 gobject-introspection-stub"
-
-PR = "r3"
-
-SRC_URI = "http://gupnp.org/sites/all/files/sources/${BPN}-${PV}.tar.gz"
-
-SRC_URI[md5sum] = "aec6a56ac1d4f8a4837da83f2d152556"
-SRC_URI[sha256sum] = "94de92bb4f7906ed2f047b0146a3b21d53d09908fe1f0149484f61c6afc598ea" 
-
-inherit autotools pkgconfig
-
-PACKAGES =+ "gssdp-tools"
-
-FILES_gssdp-tools = "${bindir}/gssdp* ${datadir}/gssdp/*.glade"
-
-EXTRA_OECONF = "--disable-introspection"
-
-PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'gtk', '', d)}"
-PACKAGECONFIG[gtk] = "--with-gtk,--without-gtk,gtk+"
diff --git a/meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb b/meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb
deleted file mode 100644
index 598aa4d..0000000
--- a/meta/recipes-connectivity/gupnp/gupnp-av_0.8.0.bb
+++ /dev/null
@@ -1,15 +0,0 @@
-SUMMARY = "Helpers for AV applications using UPnP"
-DESCRIPTION = "GUPnP-AV is a collection of helpers for building AV (audio/video) applications using GUPnP."
-LICENSE = "LGPLv2"
-LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
-                    file://libgupnp-av/gupnp-av.h;beginline=1;endline=22;md5=d344132a8766641fcb11213ff5982086"
-DEPENDS = "gupnp"
-
-SRC_URI = "http://gupnp.org/sites/all/files/sources/${BPN}-${PV}.tar.gz"
-
-PR = "r2"
-
-inherit autotools pkgconfig
-
-SRC_URI[md5sum] = "8a41a3bb60b50fceb5ece71c0dc4dcfb"
-SRC_URI[sha256sum] = "e6aa032377488cedc4e347519bd30701c583780b7c54f00bab083f2316a93dc9"
diff --git a/meta/recipes-connectivity/gupnp/gupnp-tools_0.8.1.bb b/meta/recipes-connectivity/gupnp/gupnp-tools_0.8.1.bb
deleted file mode 100644
index 2ee7462..0000000
--- a/meta/recipes-connectivity/gupnp/gupnp-tools_0.8.1.bb
+++ /dev/null
@@ -1,14 +0,0 @@
-DESCRIPTION = "Tools for GUPnP"
-LICENSE = "GPLv2+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
-                    file://src/network-light/main.c;beginline=1;endline=21;md5=033bf37c030780c5a72165846b3003f6"
-DEPENDS = "gupnp gupnp-av gtk+ libglade gnome-icon-theme"
-
-SRC_URI = "http://gupnp.org/sites/all/files/sources/${BPN}-${PV}.tar.gz"
-
-PR = "r0"
-
-inherit autotools pkgconfig
-
-SRC_URI[md5sum] = "d8a44a8c19b1cc10b8e5508448d8493f"
-SRC_URI[sha256sum] = "3b46a76fcbb0188b8d2c406e514edc7662d65f48774c81e5a19f93d7706db302"
diff --git a/meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb b/meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb
deleted file mode 100644
index c226c9e..0000000
--- a/meta/recipes-connectivity/gupnp/gupnp_0.16.1.bb
+++ /dev/null
@@ -1,28 +0,0 @@
-SUMMARY = "UPnP framework"
-DESCRIPTION = "GUPnP is an elegant, object-oriented open source framework for creating UPnP  devices and control points, written in C using GObject and libsoup. The GUPnP API is intended to be easy to use, efficient and flexible. It provides the same set of features as libupnp, but shields the developer from most of UPnP's internals."
-LICENSE = "LGPLv2+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
-                    file://libgupnp/gupnp.h;beginline=1;endline=20;md5=28c49b17d623afc3335efc2e511879e1"
-DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gnome-icon-theme gobject-introspection-stub"
-
-SRC_URI = "http://gupnp.org/sites/all/files/sources/${BPN}-${PV}.tar.gz"
-
-SRC_URI[md5sum] = "021bb237741532af4bca50157ff326e4"
-SRC_URI[sha256sum] = "f01a1f4fd36ce161a3df29fa83e1a0a2fb40d3c9f30f6b403e7791688ad24cfe"
-
-PR = "r2"
-
-EXTRA_OECONF = "--disable-introspection"
-
-inherit autotools pkgconfig
-
-FILES_${PN} = "${libdir}/*.so.*"
-FILES_${PN}-dev += "${bindir}/gupnp-binding-tool"
-
-SYSROOT_PREPROCESS_FUNCS += "gupnp_sysroot_preprocess"
-
-gupnp_sysroot_preprocess () {
-	install -d ${SYSROOT_DESTDIR}${bindir_crossscripts}/
-	install -m 755 ${D}${bindir}/gupnp-binding-tool ${SYSROOT_DESTDIR}${bindir_crossscripts}/
-}
-
-- 
1.7.10.4

[PATCH 2/2] packagegroup-sdk-gmae: remove GUPnP stack as it's no longer in oe-core

[Ross Burton]

GUPnP is now in meta-multimedia, so remove it from this SDK packagegroup.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-gnome/packagegroups/packagegroup-sdk-gmae.inc |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta/recipes-gnome/packagegroups/packagegroup-sdk-gmae.inc b/meta/recipes-gnome/packagegroups/packagegroup-sdk-gmae.inc
index 58bc05b..416e05d 100644
--- a/meta/recipes-gnome/packagegroups/packagegroup-sdk-gmae.inc
+++ b/meta/recipes-gnome/packagegroups/packagegroup-sdk-gmae.inc
@@ -10,10 +10,6 @@ SDK-GMAE = " \
     libxi-dev \
     libsqlite3-dev \
     gnome-desktop \
-    gssdp \
-    gupnp \
-    gupnp-av \
-    gupnp-tools \
     libart-lgpl \
     libtelepathy \
     pulseaudio \
-- 
1.7.10.4

Re: [PATCH 0/2] Remove GUPnP

[Richard Purdie]

On Mon, 2013-01-21 at 15:29 +0000, Ross Burton wrote:
> GUPnP is great, but it's untested in oe-core.  It's now in meta-multimedia where
> it's been upgraded and live alongside companion projects such as dLeyna and
> Rygel.

There is a trend at the moment to remove things from OE-Core. That is
well and good but the question is where to draw the line. I do want to
ensure we keep at least some cross section of software in the core so
that the core can be stressed in a variety of environments.

I'm not saying gupnp shouldn't move out however I do want to figure out
what is going to stay in the core that we can test with. Obviously
things remaining the core really do need end user apps that we can
stress them with.

I was a little sad to see gthumb being removed for example as we now
have no image viewer in the core. It was also a larger gtk app so
stressed more of that side of the apis. I took the patches as it
probably does belong in meta-gnome. How do we test the various image
decoding libraries are in fact working though?

Food for thought...

Cheers,

Richard

Re: [PATCH 0/2] Remove GUPnP

[Burton, Ross]

On 21 January 2013 15:57, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> There is a trend at the moment to remove things from OE-Core. That is
> well and good but the question is where to draw the line. I do want to
> ensure we keep at least some cross section of software in the core so
> that the core can be stressed in a variety of environments.
>
> I'm not saying gupnp shouldn't move out however I do want to figure out
> what is going to stay in the core that we can test with. Obviously
> things remaining the core really do need end user apps that we can
> stress them with.
>
> I was a little sad to see gthumb being removed for example as we now
> have no image viewer in the core. It was also a larger gtk app so
> stressed more of that side of the apis. I took the patches as it
> probably does belong in meta-gnome. How do we test the various image
> decoding libraries are in fact working though?

On the whole, agreed.

Regarding image decoding, were QA actually testing the decoding
libraries in gthumb?  If we want to verify that libpng/libjpeg/etc
work then there are many options that don't involve a desktop image
editor and looking at the screen as that doesn't catch subtle decoding
problems.  This can be part of the automated tests - decode a sample
PNG, md5 the raw data, compare with reference md5sum.

Regarding GUPnP, as fond of it as I am, we were only compile-testing
it in world builds.  Who knows if the libraries were actually worked
because it was never actually linked to.  Now that it and related
projects have a new home we need to work with community members who
also use GUPnP to ensure that there is one canonical location, even if
they prefer to work with copies of the recipes instead of including
meta-oe (which is understandable).

Ross