* [RFC 2/3] core-image-lsb-sdk/dev: Inherit the base image instead of duplicating
2013-01-24 5:55 [RFC 0/3] infrastructure changes in oecore hw codecs nitin.a.kamble
2013-01-24 5:56 ` [RFC 1/3] packagegroup-core-x11-xserver: Add XSERVERCODECS variable nitin.a.kamble
@ 2013-01-24 5:56 ` nitin.a.kamble
2013-01-24 5:56 ` [RFC 3/3] core-image: Add hwcodecs IMAGE_FEATURE nitin.a.kamble
2 siblings, 0 replies; 4+ messages in thread
From: nitin.a.kamble @ 2013-01-24 5:56 UTC (permalink / raw)
To: Openembedded-core, meta-intel, richard.purdie
From: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/recipes-extended/images/core-image-lsb-dev.bb | 12 +++---------
meta/recipes-extended/images/core-image-lsb-sdk.bb | 14 ++++----------
2 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/meta/recipes-extended/images/core-image-lsb-dev.bb b/meta/recipes-extended/images/core-image-lsb-dev.bb
index 013efb9..d2dc9e2 100644
--- a/meta/recipes-extended/images/core-image-lsb-dev.bb
+++ b/meta/recipes-extended/images/core-image-lsb-dev.bb
@@ -1,13 +1,7 @@
+require core-image-lsb.bb
+
DESCRIPTION = "Basic image without X support suitable for development work. It \
can be used for customization and implementations that conform to Linux \
Standard Base (LSB)."
-IMAGE_FEATURES += "splash dev-pkgs ssh-server-openssh"
-
-IMAGE_INSTALL = "\
- ${CORE_IMAGE_BASE_INSTALL} \
- packagegroup-core-basic \
- packagegroup-core-lsb \
- "
-
-inherit core-image
+IMAGE_FEATURES += "dev-pkgs"
diff --git a/meta/recipes-extended/images/core-image-lsb-sdk.bb b/meta/recipes-extended/images/core-image-lsb-sdk.bb
index abddb76..da8c250 100644
--- a/meta/recipes-extended/images/core-image-lsb-sdk.bb
+++ b/meta/recipes-extended/images/core-image-lsb-sdk.bb
@@ -1,16 +1,10 @@
+require core-image-lsb.bb
+
DESCRIPTION = "Basic image without X support suitable for Linux Standard Base \
(LSB) implementations. It includes the full meta-toolchain, plus development \
headers and libraries to form a standalone SDK."
-IMAGE_FEATURES += "splash tools-sdk dev-pkgs ssh-server-openssh \
- tools-debug tools-profile tools-testapps debug-tweaks"
-
+IMAGE_FEATURES += "tools-sdk dev-pkgs tools-debug tools-profile tools-testapps debug-tweaks"
-IMAGE_INSTALL = "\
- ${CORE_IMAGE_BASE_INSTALL} \
- packagegroup-core-basic \
- packagegroup-core-lsb \
- kernel-dev \
- "
+IMAGE_INSTALL += "kernel-dev"
-inherit core-image
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RFC 3/3] core-image: Add hwcodecs IMAGE_FEATURE
2013-01-24 5:55 [RFC 0/3] infrastructure changes in oecore hw codecs nitin.a.kamble
2013-01-24 5:56 ` [RFC 1/3] packagegroup-core-x11-xserver: Add XSERVERCODECS variable nitin.a.kamble
2013-01-24 5:56 ` [RFC 2/3] core-image-lsb-sdk/dev: Inherit the base image instead of duplicating nitin.a.kamble
@ 2013-01-24 5:56 ` nitin.a.kamble
2 siblings, 0 replies; 4+ messages in thread
From: nitin.a.kamble @ 2013-01-24 5:56 UTC (permalink / raw)
To: Openembedded-core, meta-intel, richard.purdie
From: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently hardware codecs are being injected in rather ugly ways and end up
either in no or all images. This adds a dedicated IMAGE_FEATURE for them based
on the MACHINE_HWCODECS variable. We may need to refine this in due course
but this patch at least illustrates the concept.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/classes/core-image.bbclass | 4 ++++
meta/recipes-extended/images/core-image-lsb.bb | 2 +-
meta/recipes-sato/images/core-image-sato.bb | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/meta/classes/core-image.bbclass b/meta/classes/core-image.bbclass
index e0f6dbb..657d5f2 100644
--- a/meta/classes/core-image.bbclass
+++ b/meta/classes/core-image.bbclass
@@ -23,6 +23,7 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
# - ssh-server-dropbear - SSH server (dropbear)
# - ssh-server-openssh - SSH server (openssh)
# - qt4-pkgs - Qt4/X11 and demo applications
+# - hwcodecs - Install hardware acceleration codecs
# - package-management - installs package management tools and preserves the package manager database
# - debug-tweaks - makes an image suitable for development, e.g. allowing passwordless root logins
# - dev-pkgs - development packages (headers, etc.) for all installed packages in the rootfs
@@ -41,6 +42,7 @@ PACKAGE_GROUP_ssh-server-dropbear = "packagegroup-core-ssh-dropbear"
PACKAGE_GROUP_ssh-server-openssh = "packagegroup-core-ssh-openssh"
PACKAGE_GROUP_package-management = "${ROOTFS_PKGMANAGE}"
PACKAGE_GROUP_qt4-pkgs = "packagegroup-core-qt-demoapps"
+PACKAGE_GROUP_hwcodecs = "${MACHINE_HWCODECS}"
# IMAGE_FEATURES_REPLACES_foo = 'bar1 bar2'
@@ -50,6 +52,8 @@ IMAGE_FEATURES_REPLACES_ssh-server-openssh = "ssh-server-dropbear"
# IMAGE_FEATURES_CONFLICTS_foo = 'bar1 bar2'
# An error exception would be raised if both image features foo and bar1(or bar2) are included
+MACHINE_HWCODECS ??= ""
+
python __anonymous() {
# Ensure we still have a splash screen for existing images
if base_contains("IMAGE_FEATURES", "apps-console-core", "1", "", d) == "1":
diff --git a/meta/recipes-extended/images/core-image-lsb.bb b/meta/recipes-extended/images/core-image-lsb.bb
index 2c47dc6..a5f2643 100644
--- a/meta/recipes-extended/images/core-image-lsb.bb
+++ b/meta/recipes-extended/images/core-image-lsb.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "A foundational basic image without support for X that can be \
reasonably used for customization and is suitable for implementations that \
conform to Linux Standard Base (LSB)."
-IMAGE_FEATURES += "splash ssh-server-openssh"
+IMAGE_FEATURES += "splash ssh-server-openssh hwcodecs"
IMAGE_INSTALL = "\
${CORE_IMAGE_BASE_INSTALL} \
diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
index f52a1a5..e3246d2 100644
--- a/meta/recipes-sato/images/core-image-sato.bb
+++ b/meta/recipes-sato/images/core-image-sato.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "Image with Sato, a mobile environment and visual style for \
mobile devices. The image supports X11 with a Sato theme, Pimlico \
applications, and contains terminal, editor, and file manager."
-IMAGE_FEATURES += "splash package-management x11-base x11-sato ssh-server-dropbear"
+IMAGE_FEATURES += "splash package-management x11-base x11-sato ssh-server-dropbear hwcodecs"
LICENSE = "MIT"
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread