* [PATCH 0/1] hwclock.sh: check for the existence of /etc/default/rcS
@ 2013-02-19 7:59 Qi.Chen
2013-02-19 7:59 ` [PATCH 1/1] " Qi.Chen
0 siblings, 1 reply; 4+ messages in thread
From: Qi.Chen @ 2013-02-19 7:59 UTC (permalink / raw)
To: openembedded-core; +Cc: Zhenfeng.Zhao
From: Chen Qi <Qi.Chen@windriver.com>
The following changes since commit c7b23ab68aafc04d9830ef318015912e5d4f0672:
maintainers.inc: update ownership of recipes (2013-02-17 22:33:30 +0000)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/rcs-default
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/rcs-default
Chen Qi (1):
hwclock.sh: check for the existence of /etc/default/rcS
meta/recipes-core/busybox/files/hwclock.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] hwclock.sh: check for the existence of /etc/default/rcS
2013-02-19 7:59 [PATCH 0/1] hwclock.sh: check for the existence of /etc/default/rcS Qi.Chen
@ 2013-02-19 7:59 ` Qi.Chen
2013-02-19 11:10 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 4+ messages in thread
From: Qi.Chen @ 2013-02-19 7:59 UTC (permalink / raw)
To: openembedded-core; +Cc: Zhenfeng.Zhao
From: Chen Qi <Qi.Chen@windriver.com>
/etc/default/rcS might be missing if the init manager is not sysvinit.
So we have to check for the existence of this file before sourcing it.
[YOCTO #3697]
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta/recipes-core/busybox/files/hwclock.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/busybox/files/hwclock.sh b/meta/recipes-core/busybox/files/hwclock.sh
index cc6d286..be5f94d 100644
--- a/meta/recipes-core/busybox/files/hwclock.sh
+++ b/meta/recipes-core/busybox/files/hwclock.sh
@@ -20,7 +20,7 @@
[ ! -x /sbin/hwclock ] && exit 0
-. /etc/default/rcS
+[ -f /etc/default/rcS ] && . /etc/default/rcS
[ "$UTC" = "yes" ] && tz="--utc" || tz="--localtime"
case "$1" in
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] hwclock.sh: check for the existence of /etc/default/rcS
2013-02-19 7:59 ` [PATCH 1/1] " Qi.Chen
@ 2013-02-19 11:10 ` Bernhard Reutner-Fischer
2013-02-20 5:58 ` ChenQi
0 siblings, 1 reply; 4+ messages in thread
From: Bernhard Reutner-Fischer @ 2013-02-19 11:10 UTC (permalink / raw)
To: Qi.Chen; +Cc: Zhenfeng.Zhao, openembedded-core
On 19 February 2013 08:59, <Qi.Chen@windriver.com> wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> /etc/default/rcS might be missing if the init manager is not sysvinit.
> So we have to check for the existence of this file before sourcing it.
>
> [YOCTO #3697]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/recipes-core/busybox/files/hwclock.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/busybox/files/hwclock.sh b/meta/recipes-core/busybox/files/hwclock.sh
> index cc6d286..be5f94d 100644
> --- a/meta/recipes-core/busybox/files/hwclock.sh
> +++ b/meta/recipes-core/busybox/files/hwclock.sh
> @@ -20,7 +20,7 @@
>
> [ ! -x /sbin/hwclock ] && exit 0
>
> -. /etc/default/rcS
> +[ -f /etc/default/rcS ] && . /etc/default/rcS
I'd make that -r fwiw.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] hwclock.sh: check for the existence of /etc/default/rcS
2013-02-19 11:10 ` Bernhard Reutner-Fischer
@ 2013-02-20 5:58 ` ChenQi
0 siblings, 0 replies; 4+ messages in thread
From: ChenQi @ 2013-02-20 5:58 UTC (permalink / raw)
To: Bernhard Reutner-Fischer; +Cc: Zhenfeng.Zhao, openembedded-core
On 02/19/2013 07:10 PM, Bernhard Reutner-Fischer wrote:
> On 19 February 2013 08:59, <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> /etc/default/rcS might be missing if the init manager is not sysvinit.
>> So we have to check for the existence of this file before sourcing it.
>>
>> [YOCTO #3697]
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>> meta/recipes-core/busybox/files/hwclock.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/busybox/files/hwclock.sh b/meta/recipes-core/busybox/files/hwclock.sh
>> index cc6d286..be5f94d 100644
>> --- a/meta/recipes-core/busybox/files/hwclock.sh
>> +++ b/meta/recipes-core/busybox/files/hwclock.sh
>> @@ -20,7 +20,7 @@
>>
>> [ ! -x /sbin/hwclock ] && exit 0
>>
>> -. /etc/default/rcS
>> +[ -f /etc/default/rcS ] && . /etc/default/rcS
> I'd make that -r fwiw.
>
>
Thank you for your review.
In this case, I think they have the same effect.
Best Regards,
Chen Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-20 6:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 7:59 [PATCH 0/1] hwclock.sh: check for the existence of /etc/default/rcS Qi.Chen
2013-02-19 7:59 ` [PATCH 1/1] " Qi.Chen
2013-02-19 11:10 ` Bernhard Reutner-Fischer
2013-02-20 5:58 ` ChenQi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox