Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz
@ 2013-06-05  9:20 Yi Zhao
  2013-06-05  9:20 ` [PATCH 1/1] " Yi Zhao
  0 siblings, 1 reply; 3+ messages in thread
From: Yi Zhao @ 2013-06-05  9:20 UTC (permalink / raw)
  To: openembedded-core

When build an image, It will generate a symbolic link file named modules-${MACHINE}.tgz in tmp/deploy/images directory.
This file should link to the real modules tarball. But now it links to an invalid file which has an extra ".bin" suffix.
This patch fixs this issue.

The following changes since commit a62aed41f2d8f874f7ae24d0e5be5dbc66ea2199:

  lrzsz: check locale.h in configure (2013-06-04 15:55:46 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib yizhao/bug4595
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=yizhao/bug4595

Yi Zhao (1):
  kernel.bbclass: Fix link for modules-${MACHINE}.tgz

 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.9.5



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz
  2013-06-05  9:20 [PATCH 0/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz Yi Zhao
@ 2013-06-05  9:20 ` Yi Zhao
  2013-06-05 10:05   ` Martin Jansa
  0 siblings, 1 reply; 3+ messages in thread
From: Yi Zhao @ 2013-06-05  9:20 UTC (permalink / raw)
  To: openembedded-core

The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}.
But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin.
Remove the extra .bin suffix.

[YOCTO #4595]

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 6550615..40a6b5b 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -375,7 +375,7 @@ kernel_do_deploy() {
 	if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
 		mkdir -p ${D}/lib
 		tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
-		ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
+		ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
 	fi
 
 	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz
  2013-06-05  9:20 ` [PATCH 1/1] " Yi Zhao
@ 2013-06-05 10:05   ` Martin Jansa
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Jansa @ 2013-06-05 10:05 UTC (permalink / raw)
  To: Yi Zhao; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

On Wed, Jun 05, 2013 at 05:20:50PM +0800, Yi Zhao wrote:
> The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}.
> But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin.
> Remove the extra .bin suffix.
> 
> [YOCTO #4595]

Looks good, thanks for fixing it.

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

> 
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
>  meta/classes/kernel.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 6550615..40a6b5b 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -375,7 +375,7 @@ kernel_do_deploy() {
>  	if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
>  		mkdir -p ${D}/lib
>  		tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
> -		ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
> +		ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
>  	fi
>  
>  	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-05 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05  9:20 [PATCH 0/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz Yi Zhao
2013-06-05  9:20 ` [PATCH 1/1] " Yi Zhao
2013-06-05 10:05   ` Martin Jansa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox