[PATCH 0/1] base-files: create /usr/lib/locale dir

[PATCH 0/1] base-files: create /usr/lib/locale dir

[rongqing.li]

From: "Roy.Li" <rongqing.li@windriver.com>

The following changes since commit cf59801be372bda962a94e6a406e97d20744ae45:

  licences: Add SGI license (2013-06-17 16:44:36 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib roy/base-files
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=roy/base-files

Roy.Li (1):
  base-files: create /usr/lib/locale dir

 meta/recipes-core/base-files/base-files_3.0.14.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH 1/1] base-files: create /usr/lib/locale dir

[rongqing.li]

From: "Roy.Li" <rongqing.li@windriver.com>

Lsbtest shows that /usr/lib/locale dir is lost, so create it

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
---
 meta/recipes-core/base-files/base-files_3.0.14.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index ac85ed9..fa1cc58 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -36,7 +36,7 @@ dirs2775 = "/home ${prefix}/src ${localstatedir}/local"
 dirs755 = "/bin /boot /dev ${sysconfdir} ${sysconfdir}/default \
            ${sysconfdir}/skel /lib /mnt /proc ${ROOT_HOME} /run /sbin \
            ${prefix} ${bindir} ${docdir} /usr/games ${includedir} \
-           ${libdir} ${sbindir} ${datadir} \
+           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
            ${datadir}/common-licenses ${datadir}/dict ${infodir} \
            ${mandir} ${datadir}/misc ${localstatedir} \
            ${localstatedir}/backups ${localstatedir}/lib \
-- 
1.7.10.4

Re: [PATCH 1/1] base-files: create /usr/lib/locale dir

[Phil Blundell]

On Tue, 2013-06-18 at 15:19 +0800, rongqing.li@windriver.com wrote:
> -           ${libdir} ${sbindir} ${datadir} \
> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \

This is bogus for a number of reasons.  If the only reason for having it
is for lsbtest, can't it go in some LSB recipe?

p.

Re: [PATCH 0/1] base-files: create /usr/lib/locale dir

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

On Tuesday, 18 June 2013, wrote:

> -           ${libdir} ${sbindir} ${datadir} \
> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \


What Phil said, but also please don't hard-code paths - the rest of the
variable uses ${libdir} for a reason.

Ross

[-- Attachment #2: Type: text/html, Size: 437 bytes --]

Re: [PATCH 0/1] base-files: create /usr/lib/locale dir

[Rongqing Li]

On 06/18/2013 04:24 PM, Burton, Ross wrote:
> On Tuesday, 18 June 2013, wrote:
>
>> -           ${libdir} ${sbindir} ${datadir} \
>> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
>
>
> What Phil said, but also please don't hard-code paths - the rest of the
> variable uses ${libdir} for a reason.
>

${libdir}/locale can be /usr/lib/locale, or /usr/lib64/locale,

but localedef only thinks /usr/lib/locale as its default
outputpath(man localedef), can not /usr/lib64/locale, or
other.


-Roy

> Ross
>

-- 
Best Reagrds,
Roy | RongQing Li

Re: [PATCH 1/1] base-files: create /usr/lib/locale dir

[Rongqing Li]

On 06/18/2013 04:07 PM, Phil Blundell wrote:
> On Tue, 2013-06-18 at 15:19 +0800, rongqing.li@windriver.com wrote:
>> -           ${libdir} ${sbindir} ${datadir} \
>> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
>
> This is bogus for a number of reasons.  If the only reason for having it
> is for lsbtest, can't it go in some LSB recipe?
>
> p.
>

Thanks, How about put it into do_install_append_linuxstdbase

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb 
b/meta/recipes-core/base-files/base-files_3.0.14.bb
index fa1cc58..84663e3 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -139,6 +139,7 @@ do_install_append_linuxstdbase() {
         for d in ${dirs4775}; do
                  install -m 2755 -d ${D}$d
          done
+       install -m 755 -d ${D}/usr/lib/locale
  }

  PACKAGES = "${PN}-doc ${PN} ${PN}-dev ${PN}-dbg"

-Roy



>
>
>

-- 
Best Reagrds,
Roy | RongQing Li

Re: [PATCH 1/1] base-files: create /usr/lib/locale dir

[Phil Blundell]

On Tue, 2013-06-18 at 16:42 +0800, Rongqing Li wrote:
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb 
> b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index fa1cc58..84663e3 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -139,6 +139,7 @@ do_install_append_linuxstdbase() {
>          for d in ${dirs4775}; do
>                   install -m 2755 -d ${D}$d
>           done
> +       install -m 755 -d ${D}/usr/lib/locale

Thanks, that looks better.  Could you not just add it to ${dirs3755}
though?  (Despite the confusing/misleading name, this variable appears
to be a list of LSB directories that should be created with mode 0755,
cf ${dirs4755} which is apparently directories to be created with mode
2755.)

In a stylistic sense it might be better to use ${prefix}/lib/locale (or
whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr",
and presumably lsbtest is looking for "/usr/lib/locale" specifically, so
I don't think it will actually make any functional difference in this
specific case.

p.

Re: [PATCH 1/1] base-files: create /usr/lib/locale dir

[Mark Hatle]

On 6/18/13 4:12 AM, Phil Blundell wrote:
> On Tue, 2013-06-18 at 16:42 +0800, Rongqing Li wrote:
>> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> index fa1cc58..84663e3 100644
>> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> @@ -139,6 +139,7 @@ do_install_append_linuxstdbase() {
>>           for d in ${dirs4775}; do
>>                    install -m 2755 -d ${D}$d
>>            done
>> +       install -m 755 -d ${D}/usr/lib/locale
>
> Thanks, that looks better.  Could you not just add it to ${dirs3755}
> though?  (Despite the confusing/misleading name, this variable appears
> to be a list of LSB directories that should be created with mode 0755,
> cf ${dirs4755} which is apparently directories to be created with mode
> 2755.)
>
> In a stylistic sense it might be better to use ${prefix}/lib/locale (or
> whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr",
> and presumably lsbtest is looking for "/usr/lib/locale" specifically, so
> I don't think it will actually make any functional difference in this
> specific case.

FYI, I agree  ${prefix}/lib/locale is likely the correct directory to reference. 
  It preserves the semantics of the OE way of declaring paths, supports the move 
of prefix to somewhere else, and will still work in an LSB compliant configuration.

--Mark

> p.
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>