[PATCH 0/1] scripts/contrib/mkefidisk.sh: fix bashism

[PATCH 0/1] scripts/contrib/mkefidisk.sh: fix bashism

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

The following changes since commit bd1c441a210cae03fb6006c996227211cc29056b:

  bitbake: bitbake: runqueue: add warning if invalidating invalid task (2013-07-29 15:25:09 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/fix-bashism
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/fix-bashism

Chen Qi (1):
  scripts/contrib/mkefidisk.sh: fix bashism

 scripts/contrib/mkefidisk.sh |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
1.7.9.5

[PATCH 1/1] scripts/contrib/mkefidisk.sh: fix bashism

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

Remove the function keyword.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 scripts/contrib/mkefidisk.sh |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/contrib/mkefidisk.sh b/scripts/contrib/mkefidisk.sh
index bcc2411..af06b4b 100755
--- a/scripts/contrib/mkefidisk.sh
+++ b/scripts/contrib/mkefidisk.sh
@@ -28,14 +28,14 @@ BOOT_SIZE=20
 # 5% for swap
 SWAP_RATIO=5
 
-function usage() {
+usage() {
 	echo "Usage: $(basename $0) DEVICE HDDIMG TARGET_DEVICE"
 	echo "       DEVICE: The device to write the image to, e.g. /dev/sdh"
 	echo "       HDDIMG: The hddimg file to generate the efi disk from"
 	echo "       TARGET_DEVICE: The device the target will boot from, e.g.  /dev/mmcblk0"
 }
 
-function image_details() {
+image_details() {
 	IMG=$1
 	echo "Image details"
 	echo "============="
@@ -46,7 +46,7 @@ function image_details() {
 	echo ""
 }
 
-function device_details() {
+device_details() {
 	DEV=$1
 	BLOCK_SIZE=512
 
@@ -71,7 +71,7 @@ function device_details() {
 	echo ""
 }
 
-function unmount_device() {
+unmount_device() {
 	grep -q $DEVICE /proc/mounts
 	if [ $? -eq 0 ]; then
 		echo -n "$DEVICE listed in /proc/mounts, attempting to unmount..."
-- 
1.7.9.5

Re: [PATCH 0/1] scripts/contrib/mkefidisk.sh: fix bashism

[ChenQi]

On 08/02/2013 02:32 PM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> The following changes since commit bd1c441a210cae03fb6006c996227211cc29056b:
>
>    bitbake: bitbake: runqueue: add warning if invalidating invalid task (2013-07-29 15:25:09 +0100)
>
> are available in the git repository at:
>
>    git://git.pokylinux.org/poky-contrib ChenQi/fix-bashism
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/fix-bashism
>
> Chen Qi (1):
>    scripts/contrib/mkefidisk.sh: fix bashism
>
>   scripts/contrib/mkefidisk.sh |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
Please ignore this patch. It has already been included in another patchset.

//Chen Qi