* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:07 ` Paul Eggleton
@ 2013-08-22 9:14 ` Iorga, Cristian
2013-08-22 9:55 ` Martin Jansa
2013-08-22 9:58 ` Phil Blundell
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Iorga, Cristian @ 2013-08-22 9:14 UTC (permalink / raw)
To: Paul Eggleton, openembedded-core@lists.openembedded.org
-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Paul Eggleton
Sent: Thursday, August 22, 2013 12:08 PM
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
> Paul, Ross:
>
> Please review this set.
>
> It has a number of large changes that I want more EYES on!
>
> Particularly, the python3 patch set, which I may remove before this is
> final due to the world build issue.
>
> There is also a few patches on poky from Beth and myself which need a
> look at and ACK The following changes since commit
> d98f08a7ad95d0b17846276b028a6614f16b6846:
>
> genext2fs: fix memory corruption on powerpc (2013-08-20 07:11:44
> -0700)
>
> are available in the git repository at:
>
> git://git.openembedded.org/openembedded-core-contrib sgw/stage
>
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h
> =sgw/
> stage
>
> Cristian Iorga (4):
> packagegroup-self-hosted: pcmanfm integration
> builder: register directories with pcmanfm
> build-appliance-image: changing the icon theme to sato
> default-providers: Set the preferred provider for bluez
I thought we were going to fix the libasound-module-bluez multiple provider issue by renaming the package?
- Actually, that involves more changes (change in packagegroup-base.bb) and I think that this change will be eliminated once we will make the change to BlueZ5 in the next release (or I hope so :-) ).
> Jonathan Liu (3):
> xf86-video-intel: remove duplicate xf86driproto from DEPENDS
> xf86-video-vesa: remove duplicate xf86driproto from DEPENDS
> mesa: enable additional drivers for gallium-llvm x86/x86-64
>
> Kai Kang (3):
> bc: fix segmentation fault
> libx11: upgrade to 1.6.1
> libx11-diet: upgrade to 1.6.1
"Deleted keysymdef_include patch" - why? Presumably because it was merged upstream, but that needs to be stated.
> Khem Raj (27):
> generate-manifest-3.3.py: Add script to generate python 3.3 manifests
> python-3.3-manifest: Add python3 manifest file
> python3native.bbclass: Add python3 abstraction class
> package_rpm.bbclass:Make the regexp less greedy
> classes/distutils: Introduce PYTHON_PN
> classes: Add distutils for python3
I hadn't noticed earlier, but this set of changes introduces a shedload more bbclasses. Are these really all necessary?
> setuptools.bbclass: Use python-distribute instead of python-setuptools
> distutils3.bbclass: Port the distutils class fix to handle filenames
> with spaces
> setuptools3.bbclass: Remove useless multiline comment
These incremental changes to files added in earlier commits need to be squashed into those commits.
> distutils: Introduce PYTHON_ABI variable
> distutils3: Do build_ext as separate step during compile
> python3: Add recipes
> python3: Add native recipe
> python_2.7.3.bb: Inherit python-dir
> python3-nose: Testing tools for python
> zeromq: Add recipe
> pyzmq: Add recipes using python3
There's inadequate justification given in the commit messages for why these last two need to be added; I already mentioned this in earlier feedback on these changes. What's more, the second commit makes a tweak to the commit before which should be squashed into there instead.
> ipython: Add recipes for ipython2 and ipython3
Again, the commit message needs to mention why we need these.
> python-distribute: Add recipes for python2 and python3
> python3: Upgrade to 3.3.2
> distutils3.bbclass: Fix typo and use proper values for target sysroot
> python3, python3-native: Consider OE staging installation
> python3: Fix host include contamination issue
> distutils3.bbclass: Use MACHINE for sysroot when not building for
> build host
> python3: Fix the compiler invocation and linker flags when cross
> compiling
> python: Add Patch description and status information
> eglibc: Update SRC_URI and fix unpackaged empty dir
I appreciate the work and testing that has gone into this set of changes but it still needs further cleaning up as discussed above IMO.
> Lauren Post (2):
> directfb: Upgrade to 1.6.3
> directfb: add fusion patch for hangs on exit with
The commit messages seem a little bit malformed on these two.
> Mark Hatle (11):
> image.bbclass: Add basic support for PACKAGE_EXCLUDE
> python-smartpm: Add support for excluding package from the install
> package_rpm.bbclass: Add support for PACKAGE_EXCLUDE to RPM installs
> python-smartpm: Add support to disable installing recommends
> package_rpm.bbclass: NO_RECOMMENDATIONS support
> package_deb.bbclass: Use the WORKDIR not SYSROOT for temp files
> package_deb: Add support for NO_RECOMMENDATIONS and PACKAGE_EXCLUDE
> opkg: Add --no-install-recommends option.
> package_ipk: Add support for NO_RECOMMENDATIONS
> opkg: Add support for excluding packages from the install
> package_ipk: Add support for PACKAGE_EXCLUDE
As mentioned earlier I'm still unhappy with not persisting these into the rootfs if package-management is enabled, but I'll try to address that myself in a follow-up.
> Marko Lindqvist (3):
> texinfo: correct dont-depend-on-help2man.patch
> SDL2: add recipe
> boost: fix build when PARALLEL_MAKE is not set
>
> Otavio Salvador (1):
> distro_features_check.bbclass: Allow checking of required/conflicting
> features
I should have asked this earlier - why does this need to be a separate bbclass? The code doesn't do anything if the variables aren't set, so it can't be because it could have an impact on existing setups that don't set them.
> Paul Eggleton (1):
> gst-plugins-good: fix orc enabling via PACKAGECONFIG
>
> Roy.Li (1):
> shadow: backport a patch to make newgrp work
The commit message should really have some detail in it for a change like this.
> Saul Wold (4):
> Add Upstream-Status tags to patches
> libsdl: Backport xData32 patch for x11 update
> valgrind: Backport patch for eglibc 2.18
> gnupg: Update to 2.0.21
>
> Tyler Hall (1):
> cpan-base: Don't use immediate expansion
I assume there's no appreciable impact on build performance with this change?
> Yevhen Kyriukha (1):
> connman: fix systemd support for connman-* packages.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:14 ` Iorga, Cristian
@ 2013-08-22 9:55 ` Martin Jansa
2013-08-22 10:55 ` Iorga, Cristian
0 siblings, 1 reply; 15+ messages in thread
From: Martin Jansa @ 2013-08-22 9:55 UTC (permalink / raw)
To: Iorga, Cristian; +Cc: Paul Eggleton, openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
On Thu, Aug 22, 2013 at 09:14:07AM +0000, Iorga, Cristian wrote:
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Paul Eggleton
> Sent: Thursday, August 22, 2013 12:08 PM
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
Iorga, please get better e-mail client, there is no way to see what was
written by you and what was there from Paul's reply.
> > Cristian Iorga (4):
> > packagegroup-self-hosted: pcmanfm integration
> > builder: register directories with pcmanfm
> > build-appliance-image: changing the icon theme to sato
> > default-providers: Set the preferred provider for bluez
>
> I thought we were going to fix the libasound-module-bluez multiple provider issue by renaming the package?
> - Actually, that involves more changes (change in packagegroup-base.bb) and I think that this change will be eliminated once we will make the change to BlueZ5 in the next release (or I hope so :-) ).
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:55 ` Martin Jansa
@ 2013-08-22 10:55 ` Iorga, Cristian
0 siblings, 0 replies; 15+ messages in thread
From: Iorga, Cristian @ 2013-08-22 10:55 UTC (permalink / raw)
To: Martin Jansa; +Cc: Paul Eggleton, openembedded-core@lists.openembedded.org
Sorry, for the moment, I don't have the necessary time resources to switch to another email client.
I will do it after 1.5 release.
Regards,
Cristian
-----Original Message-----
From: Martin Jansa [mailto:martin.jansa@gmail.com]
Sent: Thursday, August 22, 2013 12:55 PM
To: Iorga, Cristian
Cc: Paul Eggleton; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
On Thu, Aug 22, 2013 at 09:14:07AM +0000, Iorga, Cristian wrote:
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Paul Eggleton
> Sent: Thursday, August 22, 2013 12:08 PM
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
Iorga, please get better e-mail client, there is no way to see what was written by you and what was there from Paul's reply.
> > Cristian Iorga (4):
> > packagegroup-self-hosted: pcmanfm integration
> > builder: register directories with pcmanfm
> > build-appliance-image: changing the icon theme to sato
> > default-providers: Set the preferred provider for bluez
>
> I thought we were going to fix the libasound-module-bluez multiple provider issue by renaming the package?
> - Actually, that involves more changes (change in packagegroup-base.bb) and I think that this change will be eliminated once we will make the change to BlueZ5 in the next release (or I hope so :-) ).
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:07 ` Paul Eggleton
2013-08-22 9:14 ` Iorga, Cristian
@ 2013-08-22 9:58 ` Phil Blundell
2013-08-22 10:20 ` Richard Purdie
` (2 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Phil Blundell @ 2013-08-22 9:58 UTC (permalink / raw)
To: openembedded-core
On Thu, 2013-08-22 at 10:07 +0100, Paul Eggleton wrote:
> On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
> > package_rpm.bbclass:Make the regexp less greedy
That's a rather poor commit message. There are multiple regexps in this
class and none of them is famous enough to be adequately described as
"the regexp".
p.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:07 ` Paul Eggleton
2013-08-22 9:14 ` Iorga, Cristian
2013-08-22 9:58 ` Phil Blundell
@ 2013-08-22 10:20 ` Richard Purdie
2013-08-22 12:48 ` Otavio Salvador
2013-08-22 12:51 ` Paul Eggleton
2013-08-22 17:39 ` Khem Raj
2013-08-22 18:03 ` Khem Raj
4 siblings, 2 replies; 15+ messages in thread
From: Richard Purdie @ 2013-08-22 10:20 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On Thu, 2013-08-22 at 10:07 +0100, Paul Eggleton wrote:
> On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
> > Marko Lindqvist (3):
> > texinfo: correct dont-depend-on-help2man.patch
> > SDL2: add recipe
> > boost: fix build when PARALLEL_MAKE is not set
> >
> > Otavio Salvador (1):
> > distro_features_check.bbclass: Allow checking of required/conflicting
> > features
>
> I should have asked this earlier - why does this need to be a separate
> bbclass? The code doesn't do anything if the variables aren't set, so it can't
> be because it could have an impact on existing setups that don't set them.
FWIW I do have a worry about the shear weight of the core these days as
we're building up piles of anonymous python for example. In many ways I
therefore like the idea of having more classes which get included when
they're needed.
Cheers,
Richard
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 10:20 ` Richard Purdie
@ 2013-08-22 12:48 ` Otavio Salvador
2013-08-22 12:51 ` Paul Eggleton
1 sibling, 0 replies; 15+ messages in thread
From: Otavio Salvador @ 2013-08-22 12:48 UTC (permalink / raw)
To: Richard Purdie
Cc: Paul Eggleton, Patches and discussions about the oe-core layer
On Thu, Aug 22, 2013 at 7:20 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Thu, 2013-08-22 at 10:07 +0100, Paul Eggleton wrote:
>> On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
>> > Marko Lindqvist (3):
>> > texinfo: correct dont-depend-on-help2man.patch
>> > SDL2: add recipe
>> > boost: fix build when PARALLEL_MAKE is not set
>> >
>> > Otavio Salvador (1):
>> > distro_features_check.bbclass: Allow checking of required/conflicting
>> > features
>>
>> I should have asked this earlier - why does this need to be a separate
>> bbclass? The code doesn't do anything if the variables aren't set, so it can't
>> be because it could have an impact on existing setups that don't set them.
>
> FWIW I do have a worry about the shear weight of the core these days as
> we're building up piles of anonymous python for example. In many ways I
> therefore like the idea of having more classes which get included when
> they're needed.
That's why I splitted it in a class. I agree with your concern about
base growing ;-)
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 10:20 ` Richard Purdie
2013-08-22 12:48 ` Otavio Salvador
@ 2013-08-22 12:51 ` Paul Eggleton
2013-08-22 17:51 ` Otavio Salvador
1 sibling, 1 reply; 15+ messages in thread
From: Paul Eggleton @ 2013-08-22 12:51 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Thursday 22 August 2013 11:20:46 Richard Purdie wrote:
> On Thu, 2013-08-22 at 10:07 +0100, Paul Eggleton wrote:
> > On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
> > > Marko Lindqvist (3):
> > > texinfo: correct dont-depend-on-help2man.patch
> > > SDL2: add recipe
> > > boost: fix build when PARALLEL_MAKE is not set
> > >
> > > Otavio Salvador (1):
> > > distro_features_check.bbclass: Allow checking of required/conflicting
> > >
> > > features
> >
> > I should have asked this earlier - why does this need to be a separate
> > bbclass? The code doesn't do anything if the variables aren't set, so it
> > can't be because it could have an impact on existing setups that don't
> > set them.
>
> FWIW I do have a worry about the shear weight of the core these days as
> we're building up piles of anonymous python for example. In many ways I
> therefore like the idea of having more classes which get included when
> they're needed.
For something like this though it just increases complexity for users - unlike
other optional class-supported functionality it's not even clear from the
variable name that you'll need to inherit the class before they can be used.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 12:51 ` Paul Eggleton
@ 2013-08-22 17:51 ` Otavio Salvador
0 siblings, 0 replies; 15+ messages in thread
From: Otavio Salvador @ 2013-08-22 17:51 UTC (permalink / raw)
To: Paul Eggleton; +Cc: Patches and discussions about the oe-core layer
On Thu, Aug 22, 2013 at 9:51 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 22 August 2013 11:20:46 Richard Purdie wrote:
>> On Thu, 2013-08-22 at 10:07 +0100, Paul Eggleton wrote:
>> > On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
>> > > Marko Lindqvist (3):
>> > > texinfo: correct dont-depend-on-help2man.patch
>> > > SDL2: add recipe
>> > > boost: fix build when PARALLEL_MAKE is not set
>> > >
>> > > Otavio Salvador (1):
>> > > distro_features_check.bbclass: Allow checking of required/conflicting
>> > >
>> > > features
>> >
>> > I should have asked this earlier - why does this need to be a separate
>> > bbclass? The code doesn't do anything if the variables aren't set, so it
>> > can't be because it could have an impact on existing setups that don't
>> > set them.
>>
>> FWIW I do have a worry about the shear weight of the core these days as
>> we're building up piles of anonymous python for example. In many ways I
>> therefore like the idea of having more classes which get included when
>> they're needed.
>
> For something like this though it just increases complexity for users - unlike
> other optional class-supported functionality it's not even clear from the
> variable name that you'll need to inherit the class before they can be used.
Both ways works for me. So do the choice and I update the patch.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:07 ` Paul Eggleton
` (2 preceding siblings ...)
2013-08-22 10:20 ` Richard Purdie
@ 2013-08-22 17:39 ` Khem Raj
2013-08-22 18:03 ` Khem Raj
4 siblings, 0 replies; 15+ messages in thread
From: Khem Raj @ 2013-08-22 17:39 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On Aug 22, 2013, at 2:07 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
>> Paul, Ross:
>>
>> Please review this set.
>>
>> It has a number of large changes that I want more EYES on!
>>
>> Particularly, the python3 patch set, which I may remove before
>> this is final due to the world build issue.
>>
>> There is also a few patches on poky from Beth and myself which
>> need a look at and ACK
>> The following changes since commit d98f08a7ad95d0b17846276b028a6614f16b6846:
>>
>> genext2fs: fix memory corruption on powerpc (2013-08-20 07:11:44 -0700)
>>
>> are available in the git repository at:
>>
>> git://git.openembedded.org/openembedded-core-contrib sgw/stage
>>
>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/
>> stage
>>
>> Cristian Iorga (4):
>> packagegroup-self-hosted: pcmanfm integration
>> builder: register directories with pcmanfm
>> build-appliance-image: changing the icon theme to sato
>> default-providers: Set the preferred provider for bluez
>
> I thought we were going to fix the libasound-module-bluez multiple provider
> issue by renaming the package?
>
>> Jonathan Liu (3):
>> xf86-video-intel: remove duplicate xf86driproto from DEPENDS
>> xf86-video-vesa: remove duplicate xf86driproto from DEPENDS
>> mesa: enable additional drivers for gallium-llvm x86/x86-64
>>
>> Kai Kang (3):
>> bc: fix segmentation fault
>> libx11: upgrade to 1.6.1
>> libx11-diet: upgrade to 1.6.1
>
> "Deleted keysymdef_include patch" - why? Presumably because it was merged
> upstream, but that needs to be stated.
>
>> Khem Raj (27):
>> generate-manifest-3.3.py: Add script to generate python 3.3 manifests
>> python-3.3-manifest: Add python3 manifest file
>> python3native.bbclass: Add python3 abstraction class
>> package_rpm.bbclass:Make the regexp less greedy
>> classes/distutils: Introduce PYTHON_PN
>> classes: Add distutils for python3
>
> I hadn't noticed earlier, but this set of changes introduces a shedload more
> bbclasses. Are these really all necessary?
If you look at it the classes are to let python3 live along and share the common code with python2
>
>> setuptools.bbclass: Use python-distribute instead of python-setuptools
>> distutils3.bbclass: Port the distutils class fix to handle filenames
>> with spaces
>> setuptools3.bbclass: Remove useless multiline comment
>
> These incremental changes to files added in earlier commits need to be squashed
> into those commits.
I have kept them for history, except the last one other two are worthwhile to have separate
commits
>
>> distutils: Introduce PYTHON_ABI variable
>> distutils3: Do build_ext as separate step during compile
>> python3: Add recipes
>> python3: Add native recipe
>> python_2.7.3.bb: Inherit python-dir
>> python3-nose: Testing tools for python
>> zeromq: Add recipe
>> pyzmq: Add recipes using python3
>
> There's inadequate justification given in the commit messages for why these
> last two need to be added; I already mentioned this in earlier feedback on
> these changes. What's more, the second commit makes a tweak to the commit
> before which should be squashed into there instead.
*mq and *nose are needed for ipython, which is a powerful tool commonly used but
on a second thought actually I will drop ipython
from OE-Core and put it in some other layer like meta-oe and if there are enough
users who then want it, we can make a case of moving it into OE-Core
>
>> ipython: Add recipes for ipython2 and ipython3
>
> Again, the commit message needs to mention why we need these.
>
see above.
>> python-distribute: Add recipes for python2 and python3
>> python3: Upgrade to 3.3.2
>> distutils3.bbclass: Fix typo and use proper values for target sysroot
>> python3, python3-native: Consider OE staging installation
>> python3: Fix host include contamination issue
>> distutils3.bbclass: Use MACHINE for sysroot when not building for
>> build host
>> python3: Fix the compiler invocation and linker flags when cross
>> compiling
>> python: Add Patch description and status information
>> eglibc: Update SRC_URI and fix unpackaged empty dir
>
> I appreciate the work and testing that has gone into this set of changes but
> it still needs further cleaning up as discussed above IMO.
>
>> Lauren Post (2):
>> directfb: Upgrade to 1.6.3
>> directfb: add fusion patch for hangs on exit with
>
> The commit messages seem a little bit malformed on these two.
>
>> Mark Hatle (11):
>> image.bbclass: Add basic support for PACKAGE_EXCLUDE
>> python-smartpm: Add support for excluding package from the install
>> package_rpm.bbclass: Add support for PACKAGE_EXCLUDE to RPM installs
>> python-smartpm: Add support to disable installing recommends
>> package_rpm.bbclass: NO_RECOMMENDATIONS support
>> package_deb.bbclass: Use the WORKDIR not SYSROOT for temp files
>> package_deb: Add support for NO_RECOMMENDATIONS and PACKAGE_EXCLUDE
>> opkg: Add --no-install-recommends option.
>> package_ipk: Add support for NO_RECOMMENDATIONS
>> opkg: Add support for excluding packages from the install
>> package_ipk: Add support for PACKAGE_EXCLUDE
>
> As mentioned earlier I'm still unhappy with not persisting these into the
> rootfs if package-management is enabled, but I'll try to address that myself
> in a follow-up.
>
>> Marko Lindqvist (3):
>> texinfo: correct dont-depend-on-help2man.patch
>> SDL2: add recipe
>> boost: fix build when PARALLEL_MAKE is not set
>>
>> Otavio Salvador (1):
>> distro_features_check.bbclass: Allow checking of required/conflicting
>> features
>
> I should have asked this earlier - why does this need to be a separate
> bbclass? The code doesn't do anything if the variables aren't set, so it can't
> be because it could have an impact on existing setups that don't set them.
>
>> Paul Eggleton (1):
>> gst-plugins-good: fix orc enabling via PACKAGECONFIG
>>
>> Roy.Li (1):
>> shadow: backport a patch to make newgrp work
>
> The commit message should really have some detail in it for a change like
> this.
>
>> Saul Wold (4):
>> Add Upstream-Status tags to patches
>> libsdl: Backport xData32 patch for x11 update
>> valgrind: Backport patch for eglibc 2.18
>> gnupg: Update to 2.0.21
>>
>> Tyler Hall (1):
>> cpan-base: Don't use immediate expansion
>
> I assume there's no appreciable impact on build performance with this change?
>
>> Yevhen Kyriukha (1):
>> connman: fix systemd support for connman-* packages.
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [CONSOLIDATED PULL 00/62] Python3, Packge Exlude and more (Initial ACK Please)!
2013-08-22 9:07 ` Paul Eggleton
` (3 preceding siblings ...)
2013-08-22 17:39 ` Khem Raj
@ 2013-08-22 18:03 ` Khem Raj
4 siblings, 0 replies; 15+ messages in thread
From: Khem Raj @ 2013-08-22 18:03 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On Aug 22, 2013, at 2:07 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> On Wednesday 21 August 2013 22:58:55 Saul Wold wrote:
>> Paul, Ross:
>>
>> Please review this set.
>>
>> It has a number of large changes that I want more EYES on!
>>
>> Particularly, the python3 patch set, which I may remove before
>> this is final due to the world build issue.
>>
>> There is also a few patches on poky from Beth and myself which
>> need a look at and ACK
>> The following changes since commit d98f08a7ad95d0b17846276b028a6614f16b6846:
>>
>> genext2fs: fix memory corruption on powerpc (2013-08-20 07:11:44 -0700)
>>
>> are available in the git repository at:
>>
>> git://git.openembedded.org/openembedded-core-contrib sgw/stage
>>
>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/
>> stage
>>
>> Cristian Iorga (4):
>> packagegroup-self-hosted: pcmanfm integration
>> builder: register directories with pcmanfm
>> build-appliance-image: changing the icon theme to sato
>> default-providers: Set the preferred provider for bluez
>
> I thought we were going to fix the libasound-module-bluez multiple provider
> issue by renaming the package?
>
>> Jonathan Liu (3):
>> xf86-video-intel: remove duplicate xf86driproto from DEPENDS
>> xf86-video-vesa: remove duplicate xf86driproto from DEPENDS
>> mesa: enable additional drivers for gallium-llvm x86/x86-64
>>
>> Kai Kang (3):
>> bc: fix segmentation fault
>> libx11: upgrade to 1.6.1
>> libx11-diet: upgrade to 1.6.1
>
> "Deleted keysymdef_include patch" - why? Presumably because it was merged
> upstream, but that needs to be stated.
>
>> Khem Raj (27):
>> generate-manifest-3.3.py: Add script to generate python 3.3 manifests
>> python-3.3-manifest: Add python3 manifest file
>> python3native.bbclass: Add python3 abstraction class
>> package_rpm.bbclass:Make the regexp less greedy
>> classes/distutils: Introduce PYTHON_PN
>> classes: Add distutils for python3
>
> I hadn't noticed earlier, but this set of changes introduces a shedload more
> bbclasses. Are these really all necessary?
>
>> setuptools.bbclass: Use python-distribute instead of python-setuptools
>> distutils3.bbclass: Port the distutils class fix to handle filenames
>> with spaces
>> setuptools3.bbclass: Remove useless multiline comment
>
> These incremental changes to files added in earlier commits need to be squashed
> into those commits.
>
>> distutils: Introduce PYTHON_ABI variable
>> distutils3: Do build_ext as separate step during compile
>> python3: Add recipes
>> python3: Add native recipe
>> python_2.7.3.bb: Inherit python-dir
>> python3-nose: Testing tools for python
>> zeromq: Add recipe
>> pyzmq: Add recipes using python3
>
> There's inadequate justification given in the commit messages for why these
> last two need to be added; I already mentioned this in earlier feedback on
> these changes. What's more, the second commit makes a tweak to the commit
> before which should be squashed into there instead.
>
>> ipython: Add recipes for ipython2 and ipython3
>
> Again, the commit message needs to mention why we need these.
>
>> python-distribute: Add recipes for python2 and python3
>> python3: Upgrade to 3.3.2
>> distutils3.bbclass: Fix typo and use proper values for target sysroot
>> python3, python3-native: Consider OE staging installation
>> python3: Fix host include contamination issue
>> distutils3.bbclass: Use MACHINE for sysroot when not building for
>> build host
>> python3: Fix the compiler invocation and linker flags when cross
>> compiling
>> python: Add Patch description and status information
>> eglibc: Update SRC_URI and fix unpackaged empty dir
>
> I appreciate the work and testing that has gone into this set of changes but
> it still needs further cleaning up as discussed above IMO.
Paul and All
I have rehashed the pull tree. http://git.openembedded.org/openembedded-core-contrib/log/?h=kraj/python3
Squashed the commits
Removed ipython and its deps
Take a look again and let me know if you have more comments.
^ permalink raw reply [flat|nested] 15+ messages in thread